Repository navigation
Model filesystem read outcomes without fusing transport - #9296
Merged
Merged
Conversation
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Model
Filesystem.Readsuccess and refusal as theFilesystemReadOutcomecoproduct through a pure.dagfold over the existing scalar transport channels. Convertgunbc.ci_yaml_validateas the first production consumer, preserving read refusal separately from YAML parse refusal before its existing generated-artifact policy projects either refusal tofalse.The adoption standing is deliberately mitigatable, not mechanically preventable. Its subject is unconverted consumption: a bound read result projected outside the arguments of
filesystem_read_outcome. Baseline measurement atorigin/mainb21b710d5378387ae0c841f07323292c5d72fabafound 92 unconverted consumption sites across 48 files. This PR routes one through the fold; 91 unconverted sites across 47 files remain. Calls and their three projections remain because they supply the fold, so they are not the adoption denominator. The standing explicitly excludes its own prose carrier from enumeration and defines the reachable next rung as zero unconverted consumption sites.The compiler-only
filesystem_readintrinsic is a separate replacement migration and is untouched. No service grammar or Rust realization change is needed: scalar channels remain the wire observation, while the interface authority owns their modeled fold. The branch has merged current main; the PR's three-dot diff is exactly three.dagfiles and contains no v1 compiler changes.Test plan
ctrl-build --remote -- bash -lc 'cargo run --release -p v1-compiler --bin gunbc -- run --source-root dag --source-root src/v2 --entry dag/test/claim/filesystem_read_outcome_witness_test.dag --function filesystem_read_success_carries_content --claim-run && cargo run --release -p v1-compiler --bin gunbc -- run --source-root dag --source-root src/v2 --entry dag/test/claim/filesystem_read_outcome_witness_test.dag --function filesystem_read_refusal_carries_error --claim-run && cargo run --release -p v1-compiler --bin gunbc -- run --source-root dag --source-root src/v2 --entry dag/test/claim/filesystem_read_outcome_witness_test.dag --function ci_yaml_read_refusal_is_not_parse_refusal --claim-run'— all three PASS after merging current main.git diff --check— PASS.cargo fmt --all --check— PASS.