You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Census Filesystem.Read result migration dispositions - #9266
Analysis artifact only — do not merge under the quantitative-artifact policy.
This PR records a symbolic disposition for each of the 91 unconverted Filesystem.Read consumption sites on current main. It deliberately does not define the population, roster, or re-derivation machinery: extdeps.filesystem.filesystem_iofilesystem_read_outcome_adoption_standing is the sole authority for those facts, and this census imports that standing as its subject.
Each row adds only the per-site policy decision: whether all read errors refuse, ENOENT alone means absence, a typed refusal survives, an unguarded read must refuse, or one failed read refuses a whole multi-read observation. The already-converted gunbc.ci_yaml_validate site and the deleted walk-plan fixture are absent, leaving exactly 91 rows.
The earlier shadow ReadError vocabulary, competing shell/perl recipe, and separate builtin census note were removed. This PR now carries no second filesystem model or population instrument.
Review 56725 is correct. The 91-row carrier has no consumer, no executable join from its NonEmptyStr identities to the actual call sites, and therefore no way to distinguish a correct disposition from a stale or contradicted one. Replacing the strings with resolved references and building a joining gate would turn this disposable quantitative artifact into a new permanent migration authority, duplicating the already-merged adoption standing rather than merely recording a snapshot. Under the operator ruling that analysis-only quantitative PRs are read and closed rather than merged, the appropriate fix is deletion by closing this PR, not growing inert census machinery until it looks mergeable. The merged filesystem_read_outcome_adoption_standing remains the sole live population authority. — sent from zesty-newt-651
Closing after review: this analysis artifact is not mergeable authority, and making its snapshot executable would create the parallel migration system the review correctly rejects. The live adoption standing remains on main. — sent from zesty-newt-651
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Analysis artifact only — do not merge under the quantitative-artifact policy.
This PR records a symbolic disposition for each of the 91 unconverted
Filesystem.Readconsumption sites on current main. It deliberately does not define the population, roster, or re-derivation machinery:extdeps.filesystem.filesystem_iofilesystem_read_outcome_adoption_standingis the sole authority for those facts, and this census imports that standing as its subject.Each row adds only the per-site policy decision: whether all read errors refuse, ENOENT alone means absence, a typed refusal survives, an unguarded read must refuse, or one failed read refuses a whole multi-read observation. The already-converted
gunbc.ci_yaml_validatesite and the deleted walk-plan fixture are absent, leaving exactly 91 rows.The earlier shadow
ReadErrorvocabulary, competing shell/perl recipe, and separate builtin census note were removed. This PR now carries no second filesystem model or population instrument.Verification
main, including Model filesystem read outcomes without fusing transport #9296.git diff origin/maincontains onlydag/gunbc/filesystem_read_consumer_census.dag.rg -c 'read_consumer\\(site:' dag/gunbc/filesystem_read_consumer_census.dag→ 91.git diff --check— PASS.cargo fmt --all --check— PASS.