Repository navigation
Floor: pay the shared MultiEntryIndex in preparation, not in an arbitrary claim - #8491
Merged
Merged
Conversation
…rary claim commit_witness_claim_pair_resolvable and its two siblings (ci_floor_commit_witness_claim_pairs, commit_witness_claim_roster_defects) called build_multi_entry_index directly instead of going through process_shared_index, the existing thread-local cache every other production call site already uses. That billed a full corpus walk+parse against whichever claim ran first — measured 62.7-83.0s for a single call to commit_witness_claim_pair_resolvable, on a witness with a ~1-5s budget. load_sources_for_entry had the same defect. Same fix as #8470's module-path-index warm: route the call sites through process_shared_index, and warm it explicitly during run_required_floor's preparation phase so the cost is paid there instead of falling on an arbitrary claim. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This was referenced Aug 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
commit_witness_claim_pair_resolvable(and its two siblingsci_floor_commit_witness_claim_pairs/commit_witness_claim_roster_defects) calledbuild_multi_entry_indexdirectly instead of going throughprocess_shared_index, the existing thread-local shared-index cache every other production call site already uses. Every call re-walked and re-parsed the whole witness corpus, uncached — measured 62.7-83.0s for a single call tocommit_witness_claim_pair_resolvable, on a witness with a ~1-5s fast-lane budget.load_sources_for_entryhad the same defect.process_shared_index, and add an explicit warm call for it duringrun_required_floor's preparation phase, so the one-time cost is deterministically paid there instead of falling on whichever claim happens to run first.Test plan
cargo check -p v1-compiler --bin claim_executor(local build) - cleancargo build --release -p v1-compiler --bin claim_executor --bin gunbc(local) - clean, verified real runnable binariescargo fmt -p v1-compiler --check- cleancargo clippy -p v1-compiler --bin claim_executor(local, informational scope) - 38 pre-existing warnings, none in the lines touched by this diffcommit_witness_claim_roster_red_control_holds) viagunbc runpost-fix - still asserts correctly (RED control on the synthetic stale pair still holds).dagfile making two calls tocommit_witness_claim_pair_resolvablewith identical args ran in ~87s total (not ~2x the ~92s single-call cost), confirming the second call served fromprocess_shared_index's cache instead of re-walking the corpusbuild_multi_entry_index(confirms no remaining unfixed production call sites - only the legitimate internal build insideprocess_shared_indexitself and pre-existing#[cfg(test)]-only sites remain🤖 Generated with Claude Code