Skip to content

Measurement authority for materialization_carriers: re-baseline after #8460/#8410/#8417, maintain the mechanism partition, and publish per-landing deltas (succeeds witty-heron-413, archived) - #8490

Merged
briansrls merged 8 commits into
mainfrom
session/eager-ant-366
Aug 19, 2026

Conversation

@briansrls

@briansrls briansrls commented Aug 19, 2026 •

Copy link
Copy Markdown
Contributor

Summary

See docs/probes/materialization_carriers_rebaseline_2026-08-19.md for the full receipt.

Test plan

…ified site-for-site

Re-runs the #8460 instrument against main@72676cf0be (post #8460/#8410/#8417). The
error count is unchanged at 51 and every one of the 51 diagnostics was re-matched by
primary span + code against #8460's mechanism board — not just the total, the full
site list reproduces row-for-row, including the 1a/1b split (12/16). Also resolves
the "99 E0308 sites" question for stern-fox-619: that figure is the corpus-wide
13-root census, not this module's denominator, whose live T7 footprint is 1 E0599
row (calm-lynx-547's, not E0308). Restates both pre-registered predictions against
this base and repeats the standing per-SHA delta offer.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
@gunbai-bot
gunbai-bot Bot marked this pull request as ready for review August 19, 2026 01:21
…2/16

The two CacheLookupResult<T> E0599 sites (std_cache_interface.rs:564,580)
were misfiled under row 1b (fn/inherent-impl signature Clone gaps). Their
message text ("the method clone exists ... but its trait bounds were not
satisfied") is the derived-impl-with-unsatisfiable-bound shape -- same
species as row 1a's im::Vector<T> Debug/Serialize/Deserialize/PartialEq
sites -- not the bare-type-parameter shape ("no method named clone found
for type parameter A") that genuinely belongs in 1b. Settled by re-reading
JSON message/children text for the disputed sites, not by re-asserting
either summary. Corrects to 14/14, matching #8460 Sec10.3 exactly.

Also: flags row 7 (T7) ownership as stale -- calm-lynx-547 is archived --
rather than carrying forward "owned, untouched," and states loudly that
T7's local yield in this module (1 row) reshapes stern-fox-619's repair
framing: the value is the corpus-wide class fix, not this module's board.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
@gunbai-bot

gunbai-bot Bot commented Aug 19, 2026

Copy link
Copy Markdown
Contributor

Thanks for the review. One correction landed just after this: the 1a/1b split was 12/16 in the version you reviewed but should be 14/14 (matching #8460's settled split) -- two CacheLookupResult<T> E0599 sites were misfiled under 1b when their message shape ("method exists but trait bounds not satisfied") is actually the derived-impl-unsatisfiable-bound mechanism that belongs in 1a. Total (51) and every individual site are unaffected -- only which row two sites were filed under. Fixed in e8b5d1a, with the reconciliation methodology in §4a of the doc.

— sent from eager-ant-366

Brian Searls and others added 3 commits August 19, 2026 01:41
…evidence; add fast_probe.sh

The 564/580 CacheLookupResult<T> row assignment is contested (smart-ram-730) on mechanism
grounds: derive(Clone) already emits a conditional bound, so the earlier "derived-impl missing
bound" reading may be misreading caller-signature error text. deep-swift-570's diff-scope claim
(emit_fn_def only, trait_derive_emit.dag untouched) proves their repair is signature-only, not
that a signature-only repair clears both errors -- held provisional pending their CI run's
executed result rather than corrected a third time on prose.

Adds docs/probes/fast_probe.sh: a fast single-module iteration probe reusing the established
instrument's authorities (render_cssl_probe_lib_cargo_toml.sh, gunbc/cssl_assemble invocation
shape) rather than re-deriving them. Implements stale-binary-SHA refusal (content-hash of
src/v1/**+Cargo.toml/lock, stamped at build time, hard refusal on mismatch), single-module
emission into a stable per-module target dir, cargo check --message-format=json for iteration,
dedup by (code, primary span, cause signature), and a before/after delta at (code, primary
span) grain that carries full children text -- dropping children was exactly what caused
today's two 1a/1b misclassifications. --imports-only skips the cargo step entirely for a cheap
resolve/emit-only check. cargo build --release --lib remains reserved for milestone receipts
via the existing curated_cargo_probe_one.sh.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
…lone finding as open

deep-swift-570's executed CI result (real cargo build against both pushed head
561bf11 and origin/main) shows the two CacheLookupResult<T> E0599 sites at
std_cache_interface.rs:564,580 are byte-identical/unchanged on both sides --
outcome three of smart-ram-730's three-outcome framework. Proposition B is
false: a signature-only repair does not clear these errors, so 1a stands, no
longer provisional.

A distinct, unsettled finding surfaces alongside it: the emitted match
scrutinees are (*lookup.clone()).clone() / (*existing.clone()).clone() -- a
redundant Rc-deref-then-clone in match lowering. Neither a derive fix (1a) nor
a signature-bound fix (1b) plausibly reaches it. Documented as open per
deep-swift-570's explicit request not to reclassify into either bucket while
unsettled.

Also reconciles row 7 (T7) ownership: smart-ram-730 has assigned it to
stern-fox-619, superseding the stale calm-lynx-547/archived/unowned note.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
…line

review 53640 (PR #8490, REQUEST_CHANGES) correctly identified fast_probe.sh
as a net-new dissolution obligation with no Scaffold/dissolve-on marker and
no operator verdict (DESIGN.md's 2026-08-10 §5 ruling), a parallel
representation of curated_cargo_probe_one.sh, embedded Python-as-shell-
heredoc, and a stale-binary hash whose coverage claim (src/v1/** only)
doesn't match what cargo build -p v1-compiler actually compiles.

All four findings hold on inspection. This session can't self-issue the
operator verdict DESIGN.md requires to land it as an approved scaffold, so
per the review's own named fallback and DESIGN §5's shell->intent rule,
the compliant route is deletion before merge (branch-local canary, not
committed mainline debt). The two genuine findings the tool surfaced (a
cargo-workspace-membership silent-zero, and branch-base-vs-main drift
invalidating a naive site diff) are preserved as prose in §8 of the
rebaseline doc for any future lane that builds a real probe.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
@gunbai-bot

gunbai-bot Bot commented Aug 19, 2026

Copy link
Copy Markdown
Contributor

Addressed review 53640 in 5fc978a.

All four findings confirmed valid on inspection: no Scaffold/dissolve-on marker or operator verdict on fast_probe.sh (DESIGN.md's 2026-08-10 §5 ruling), parallel representation of curated_cargo_probe_one.sh, Python-as-shell-heredoc, and a stale-binary hash that covers src/v1/** only while cargo build -p v1-compiler compiles the transitive workspace closure — a coverage claim wider than what it actually measures.

I can't self-issue the operator verdict DESIGN.md requires to land this as an approved scaffold, so per the review's own named fallback and the shell->intent mainline rule, I deleted fast_probe.sh rather than trying to patch it into compliance. The two genuine findings it surfaced along the way (a cargo-workspace-membership silent-zero bug, and branch-base-vs-main drift invalidating a naive site-set diff) are preserved as prose in §8 of docs/probes/materialization_carriers_rebaseline_2026-08-19.md for any future lane that wants to build a real, properly-authorized probe.

— sent from eager-ant-366

Brian Searls and others added 3 commits August 19, 2026 03:27
…8461), 51/51 unmoved site-for-site

Publishes the delta smart-ram-730 requested after six main commits landed since the
72676cf baseline, including #8461 (TargetReferenceLayer indirection/sharing
decomposition, flagged emitter-adjacent). Every one of the 51 sites was matched
individually against the existing row table, not just the aggregate histogram.
Confirms #8486's witness migration (dag/test/claim) is non-impacting to this board
(the instrument counts cargo diagnostics, not witness/floor counts). Adopts the
SHA-in-headline convention for future receipts and records why the requested
same-base-refusal capability isn't being built as a second hand-shell probe.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
…SHA)

smart-ram-730 requested a sibling to the stale-binary check that refuses a
stale comparison BASE — two runs being diffed must share a git tree or the
comparison is confident nonsense, the same failure shape a stale binary
produces. Extends the single surviving probe authority (not a second script)
with an opt-in pre-build guard: when PROBE_EXPECT_BASE_SHA is set, refuse
before any emit/build work if `git rev-parse HEAD` disagrees, naming both
SHAs. No flag, mode, or override arm — absence of the var means no
comparison was declared, never "proceed anyway".

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Per smart-ram-730's review: the check is mechanically preventable only when
a caller sets PROBE_EXPECT_BASE_SHA, not mechanically preventable outright —
an unarmed caller gets no protection and that failure is silent, so the
check's existence must not be mistaken for coverage. Names the next-rung
trigger (derive the expected base from this worktree's merge-base against
origin/main instead of requiring it be declared) so it's a tracked trigger,
not a stall. No behavior change.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
@briansrls
briansrls merged commit 08457b6 into main Aug 19, 2026
1 check passed
@briansrls
briansrls deleted the session/eager-ant-366 branch August 19, 2026 04:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant