Repository navigation
docs: PM bundle — R1 Closure Manager + escalation-paths union map - #847
Merged
Merged
Conversation
Two PM-portion deliverables, bundled per the user-preferred bundling cadence
for multiple workstreams.
## R1 Closure Manager (new) — docs/briefs/r1-closure-manager.md
Strict-interpretation gate-close authority. Per-HEAD gate audit against
ROADMAP.md §"Lane acceptance — .dag gates" surfaced 12+ unwired gates
under strict reading ("the release gate IS a .dag program" per THESIS):
- T-P0 (3): repeat_string_correct / no_fabrication_sentinel /
rest_ops_aligned — features work, no .dag TestClaim wrappers
- T-Sub (1): sub_type_alias_where_lowers — PR #703 landed feature,
no fixture wrapper
- T-TestGen (1 compiles-only): testgen_mock_backed_integration_safe —
runner returns NotYetImplemented; M1(2.8) data body blocker
- T-PB census (6): hand_rust_at_shim_floor / lens_producer_files_remaining
/ self_compile_fixed_point / compiler_std_ratchet_zero (T-PB-A) +
test_file_generated_from_dag / rust_tests_outside_residual_zero
(T-PB-B) — enforced as Rust ratchets, not .dag TestClaims
- T-Emit (3): rust_fixtures_rustc_green / generic_bounds_survive /
omni_demo_fixtures_green — host-harness only, no .dag wrappers
- T-Demo (1): demo_user_authored_lens_rejects_violating_program —
no fixture
Six mutually-exclusive lanes (R1C-A through R1C-F) at the
fixture-file / runner-dispatch-arm level. R1C-A (T-TestGen schema
extensions) unblocks R1C-D (T-PB census-as-.dag); other 4 lanes
parallel-dispatchable Day-1.
Lane variants per user direction: T-PB-A and T-PB-B merged into R1C-D
(single predicate-shape work); T-Emit kept (no host-harness pragmatic
acceptance).
Manager dissolves on R1 all-gates-green declaration; R2 managers spawn
post-dissolution per docs/r2-structure.md transition mechanics. No
overlap with R2 managers (R2 spawn gated on this manager's close).
## Escalation paths union map (new) — docs/escalation-paths.md
Sweep against main HEAD 407a8bc cataloged 45 "if X happens, escalate"
clauses across INVARIANTS / ROADMAP / THESIS / r2-structure.md / all
docs/briefs / docs/design-*.md / docs/thesis.
- 73% GROUNDED (32 clauses): trigger condition is concrete +
measurable (specific gate names, file:line citations, mechanical
search verifiable)
- 27% SOFT (13 clauses): trigger requires human judgment to fire
No significant authority conflicts. Three minor naming-tightening
opportunities surfaced as Fix 1 / Fix 2 / Fix 3 (applied below). One
near-orphan (DB-revision target unattested on main) — resolved by R2
promotion housekeeping; not load-bearing now.
Sweep boundary: main only. PR #835 (PM portion) and PR #836 (Director
portion) are NOT in this map's current sweep — second-pass sweep
planned on those PRs' merge to main.
## Three surgical fixes to source authority docs
Each fix is a 1-2 line edit closing an open-resolution-path gap the
sweep surfaced:
### Fix 1 — Signal channel naming (docs/r2-structure.md)
New paragraph in §"Manager structure" preamble naming the escalation
signal channel: GitHub session-inbox issue comment for human-target
escalations; cross-manager queue (per R1 "Cross-manager notifications
queued" pattern) for inter-manager signals. Worker-brief STOP-AND-
ESCALATE clauses no longer need to restate the channel.
### Fix 2 — Director decision-artifact format (docs/r2-structure.md)
Extended the "Scope-change escalation" bullet in §"Director" to name
where Director's adjudication decision lands: (a) amendment PR to the
originating brief OR (b) sibling brief if scope creates new program.
Closes the escalation cycle explicitly — originating brief stays open
until artifact lands.
### Fix 3 — C1 lane explicit owner (docs/design-substrate-carrier-port-program.md)
Two STOP-AND-ESCALATE clauses (Lane E-T :120 and Lane E-P :148)
rewritten from "→ C1 lane" to "→ escalate to Director (Director opens
a C1 substrate-capability lane if escalation requires substrate work)."
Director becomes the explicit receiver; C1 lane becomes the optional
dispatch outcome.
## Out of scope for this PR
- §6a follow-through brief authoring (next PM deliverable per inbox #828
PM portion; tracked in r2-release-manager.md per PR #835)
- B5 / B6 / B7 brief authoring (next PM deliverables per inbox #828 PM
portion)
- Thesis-claim coverage mapping table (lands at R1 close → R2 promotion
transition per r2-structure.md)
- Authority matrix structural normalization (per openai-pro PAUSE_AND_REGROUP
meta-review on PR #835; deferred — escalation-paths.md provides initial
evidence base for any future matrix authoring)
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 265d97fb5d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| | 19 | `docs/briefs/t-impossiblebugs-nested-optional-flatten-worker.md:72` | Surface-upstream investigation reveals `T??` parses to something other than nested `OptionalOf` | STOP; Director-call on which surface to dissolve | GROUNDED | | ||
| | 20 | `docs/briefs/t-impossiblebugs-nested-optional-flatten-worker.md:72` | Only some-but-not-all consumers see nested form | STOP; surface for dissolution decision | GROUNDED | | ||
| | 21 | `docs/briefs/t-impossiblebugs-nested-optional-flatten-worker.md:73` | Substrate-attachment requires inventing fundamental new vocabulary beyond cardinality-substrate | STOP; may indicate lane is mis-scoped | SOFT | | ||
| | 22 | `docs/design-substrate-carrier-port-program.md:120` (Lane E-T) | Carrier requires substrate connective not already present | Escalate to C1 lane (Director opens C1 substrate-capability lane — see Fix 3 below) | GROUNDED | |
There was a problem hiding this comment.
The union map now diverges from the source authority doc: after this commit, docs/design-substrate-carrier-port-program.md routes these substrate-connective cases to Director, but this row still says “Escalate to C1 lane.” Because this file is framed as the lookup for in-flight escalations, that mismatch can send workers to a non-owner route and defeats the “single source” purpose.
Useful? React with 👍 / 👎.
Contributor
Author
|
Review metadata
Findings:
Verdict: APPROVE_WITH_COMMENTS. The PR is documentation-only and the R1 closure manager is bounded with a clear dissolution trigger, but the new escalation map should not introduce competing authority language. |
…h worker brief Two additions to the PM bundle. ## ROADMAP §"R1 Closure Manager" section (new) Small registration section between §"Lane acceptance — .dag gates" and §"Scheduled cleanups". Names the manager + lane structure (R1C-A through R1C-F) + critical-path edge (R1C-A → R1C-D); points at the brief at docs/briefs/r1-closure-manager.md as authority for the per-lane scope. Parallel registration shape to docs/r2-structure.md's §"Manager structure" treatment for R2 managers — short authoritative pointer in ROADMAP, full manager scope in the brief. Manager dissolves on R1 all-gates-green; R2 spawn gated on this dissolution. ## §6a follow-through worker brief (new) Per inbox #828 PM-portion split, this is the next PM deliverable in the queue. Anchored against the existing pick-worker brief at docs/briefs/t-permethodmetadata-pick-worker.md (landed PR #794) so there's no duplicate decision authority — pick is closed; this brief is post-pick scope only. Three consumer-side requirements: 1. Inventory current consumption sites in cost.dag / complexity.dag for the three carrier fields (size_effect / cost_shape / callback_element_position). 2. Bulk-migrate to MethodContract-keyed lookup; retire lens-local reads of *_templates() result fields. 3. Track field-by-field dissolution triggers as named ROADMAP debt rows per §6a:175 (each field has a named upstream-fact landing condition that retires the carrier; when all three trigger conditions fire, MethodContract retires). Slice: inventory → migrate → track. 1-3 PRs at worker discretion. STOP-AND-ESCALATE clauses cite the new escalation channel discipline from docs/escalation-paths.md (channel: GitHub session-inbox; Director decision artifact = amendment PR or sibling brief). Behavioral-regression on R1 gates is non-negotiable STOP; DB-8 drift is STOP; carrier-shape gap discovery is STOP (the pick may need amending). ## What this PR now contains (cumulative) - docs/briefs/r1-closure-manager.md (new) — R1 Closure Manager brief - docs/escalation-paths.md (new) — 45-clause union map - docs/briefs/r2-release-6a-follow-through-worker.md (new) — post-pick worker brief - ROADMAP.md edit — R1 Closure Manager registration section - docs/r2-structure.md edits — signal channel + Director decision-artifact format (Fixes 1+2) - docs/design-substrate-carrier-port-program.md edits — C1 lane explicit owner (Fix 3) ## Out of scope Still-pending PM deliverables per inbox #828: B5 Loop construction-closure audit brief; B6 file-preference rank checklist completion; B7 priority-hint relay (cross-manager signal); thesis-claim coverage mapping table (lands at R1 close → R2 promotion). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
5 tasks
Codex on #847 sha 265d97f flagged that line 3's "Authoritative single source for ... escalation clauses" contradicts line 18's "descriptive, not prescriptive ... source briefs remain authoritative" — direct P2 single-authority ambiguity per INVARIANTS.md. Fix: line 3 now reads "Authoritative union receipt + conflict map ... The source briefs remain authoritative on their own escalation clauses (per §How to use below); this doc owns the union view + cross-brief consistency surfacing." Surface change only; the doc's actual authority scope is unchanged from the §"How to use" semantics — clauses live in source briefs; this doc surfaces the union + conflicts. The status line now matches the body. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Contributor
Author
Codex APPROVE_WITH_COMMENTS on
|
Per inbox #828 PM portion, three deliverables completing the B-wave Tier 2 PM authoring queue per docs/briefs/debt-paydown-synthesis- 2026-04-25.md §5 (lines 526-528). All three target R2 Release Manager ownership (post-spawn). ## B5 — Loop construction-closure audit (worker brief) S, R2-coupled. Audit-FIRST per parent scope statement (lines 300-314). Step 1: enumerate every Behavior::Loop construction site in lower.rs + anywhere; trace caller path. Step 2 (conditional on audit): - Closure-holds (preferred per feedback_construction_over_ratchets): deliverable is structural integration test asserting closure; speculative LoopKind marker retired. - Closure-fails: marker spec authored as separate brief; escalates to substrate-amendment per synthesis-doc STOP discipline. STOP-AND-ESCALATE clauses cover: (a) ambiguous construction-site origin; (b) marker spec requiring new substrate connective (C1-class escalation per feedback_compiler_is_dag_processor); (c) self-fulfilling closure if audit's own scaffold triggers. ## B6 — file-preference rank checklist completion (worker brief) XS-trivial. Audit-first per feedback_audit_adjacent_authority_first. Two paths: (a) add the three missing modules (computation/induction/ termination) to dag.rs:2735-2764 checklist; (b) document exemption in source if the modules are intentionally exempt. Single-PR deliverable; either +3 line addition or +1 line comment cite. STOP if rank-function semantics are genuinely ambiguous, or if "fix" turns out to require substrate work (don't ratchet on a scaffold already named for dissolution). ## B7 — priority-hint relay to Pure Bootstrap Manager (signal doc, NOT worker brief) Cross-manager signal content snapshot. NOT a worker brief — documents the signal R2 Release Manager queues to R2 Pure Bootstrap Manager once both spawn at R1 close. Payload: lift patch_lower_helpers_generated_type_alias_refinement retirement to PB-Tier1-Sweep priority within R2 Pure Bootstrap Manager's owned-deliverable queue. Pre-spawn: this file documents content. Post-spawn: R2 Release Manager queues the signal as one of its first dispatch actions; R2 PB Manager acks + adjusts priority. Closure trigger: signal delivered + consumed (or dissolution already fired pre-R1); file marks RESOLVED in follow-up cleanup. Distinguished from B5 / B6 worker briefs by the explicit "NOT a worker brief" framing in the synthesis doc; preserves single-authority discipline (deliverables vs signals do not blur). ## Cumulative PR contents (PR #847) - docs/briefs/r1-closure-manager.md - docs/briefs/r2-release-6a-follow-through-worker.md - docs/briefs/r2-release-b5-loop-construction-closure-audit-worker.md (this commit) - docs/briefs/r2-release-b6-file-preference-rank-checklist-worker.md (this commit) - docs/briefs/r2-release-b7-priority-hint-relay-to-pure-bootstrap.md (this commit) - docs/escalation-paths.md - ROADMAP.md (R1 Closure Manager registration section) - docs/r2-structure.md (Fixes 1+2 + earlier signal-channel section) - docs/design-substrate-carrier-port-program.md (Fix 3 — C1 lane explicit owner) ## What's left in PM inbox-#828 queue - Thesis-claim coverage mapping table — gated on R1 close → R2 promotion per docs/r2-structure.md Open call 1; not in this PR. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
…-B / -C / -E / -F) Per user direction "lets do the trivial ones" — authoring the four R1 Closure Manager lanes that don't depend on R1C-A (T-TestGen schema extensions). All four are parallel-dispatchable Day-1 once R1 Closure Manager spawns; sized S or smaller per the manager brief. ## R1C-B — T-P0 fixtures (S; 3 gates) - p0_repeat_string_correct (Day-1, DB-15 schema): authored immediately - p0_no_fabrication_sentinel (ext): audit predicate shape; possibly blocks on R1C-A - p0_rest_ops_aligned (ext): audit predicate shape; possibly blocks on R1C-A Branch on audit per gate; bundle PRs if all DB-15-suffices, split if any blocks on R1C-A schema landing. ## R1C-C — T-Sub sub_type_alias_where_lowers fixture (XS; 1 gate) PR #703 already landed the feature with test_db11_type_alias_where_* integration receipts. Brief authors the .dag wrapper; predicate likely Compiles on a fixture program exercising type-alias where lowering. Single PR; dispatchable Day-1. ## R1C-E — T-Emit .dag TestClaim wrappers (S; 3 gates) PB-Runtime ExecuteCommand (PR #792) is the runner enabler. Three gates: - emit_rust_fixtures_rustc_green: ExecuteCommand running rustc on emitted output - emit_generic_bounds_survive: audit-decided shape (ExecuteCommand+grep or structural) - emit_omni_demo_fixtures_green: multi-target; ForAllTargets quantifier may need R1C-A schema, OR can be expressed as 3 ExecuteCommand claims (1 per target) STOP if ForAllTargets needed and not in scope; STOP if PR #792 ExecuteCommand runner doesn't cover the bounded-execution shape. ## R1C-F — T-Demo demo_user_authored_lens_rejects_violating_program (S; 1 gate) Built on T-LensAPI user_authored_lens_compiles (GREEN). Three components: - ~20-line user-authored lens in .dag (e.g., "max external HTTP calls per workflow" per THESIS canonical example) - Violating program (~10-20 lines) - TestClaim with FailsWithDiagnostic predicate (asserts lens rejects violator) Demo artifact also authored per docs/r2-structure.md §"Demo discipline". ## Discipline anchors applied - feedback_construction_over_ratchets — fixtures ground in observable behavior (compiles / output / exit-code), not parallel asserts - feedback_audit_adjacent_authority_first — every brief mandates audit step before authoring (pick predicate / pick lens example / pick path) - All four briefs cite docs/escalation-paths.md as escalation discipline authority ## Out of scope - R1C-A T-TestGen schema extensions worker brief (M; meatier; authored separately) - R1C-D T-PB census-as-.dag worker brief (M-L; meatier; gated on R1C-A; authored separately) - Implementation of any of these briefs (worker dispatch happens at R1 Closure Manager spawn) Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Contributor
Author
|
Review metadata
1. Story of the diffThis PR is a documentation/coordination bundle, not a compiler implementation change. It registers a short-lived R1 Closure Manager in 2. Invariant categories
P2 Boundary Discipline / single-authority metadata: the new escalation map says, “every escalation clause shipped in a brief should be traceable here” at The same sync problem appears in the “C1 lane” fix: the source clauses are rewritten to “escalate to Director” at
3. VerdictREQUEST_CHANGES The overall structure is sound and most of the new docs are disciplined, but the PR’s central new single-authority artifact is not synchronized with the escalation clauses and source-doc fixes introduced by the same diff. Updating |
Contributor
Author
|
Review metadata
Docs-only PR. Verdict: APPROVE — Documentation/PM bundle only; no code changes, no invariant surface touched. Nothing to flag against INVARIANTS/modeling/CODING/TESTING. |
Per docs/r2-structure.md §"Open calls" item 1 — required pre-promotion audit table mapping every THESIS claim to R1-closed / R2-gated / post-R2-external disposition with gate name + evidence + status. ## Sweep result 74 claims cataloged across THESIS.md §"Thesis claims — complete list" (Tier 1 / Tier 2 / Tier 3 + categorical claims under Concept unifications, Epistemic stacking, Substrate shape, Free consequences, Omni-emission, Meta-process modeling, Self-hosting, Audience duality, Adoption model, Tests-as-data, Enumerable impossible-bug classes, Modeling discipline). ## Coverage statistics - R1-closed: 52 - R2-gated: 18 - post-R2-external: 4 - GAP (no disposition): 0 **Pre-promotion blocker count: 0.** Open call 1's gate is satisfied — every thesis claim has a named disposition + documented evidence. ## Coverage anomalies (partial-status, NOT blockers) Four claims have partial-status notes: 1. Ownership (Tier 1) — full infrastructure may have post-R1 tail 2. Shape A omni-emission — R1 demonstrates 3 of 6+ targets (TS/Swift/HDL post-R1) 3. Self-hosting fixed-point + tests-as-data — [ext] gates pending T-TestGen runner closure; structural commitment R1 4. Grounding completeness — Tier 1 but R2-gated (intentional, single co-anchor claim per docs/r2-structure.md) ## Doc shape (mirrors escalation-paths.md authority pattern) - Status: PROPOSAL pre-R1-close; promotes to ACTIVE on R1 close → R2 promotion - Authority: descriptive (union receipt + GAP-surfacing); THESIS + ROADMAP + r2-structure.md remain authoritative on claim text + dispositions - Refresh discipline: every release transition; rebuild on new claims ## What this PR (#847) now contains Cumulative deliverables: - docs/briefs/r1-closure-manager.md (R1 Closure Manager brief, 6 lanes) - docs/briefs/r1c-b/c/e/f-*.md (4 trivial R1C lane worker briefs) - docs/briefs/r2-release-6a-follow-through-worker.md - docs/briefs/r2-release-b5-loop-construction-closure-audit-worker.md - docs/briefs/r2-release-b6-file-preference-rank-checklist-worker.md - docs/briefs/r2-release-b7-priority-hint-relay-to-pure-bootstrap.md - docs/escalation-paths.md (45-clause union map) - docs/thesis-claim-coverage.md (74-claim coverage map; this commit) - ROADMAP.md edit — R1 Closure Manager registration section - docs/r2-structure.md edits — Fix 1+2 (signal channel + Director decision artifact) - docs/design-substrate-carrier-port-program.md edits — Fix 3 (C1 lane explicit owner) ## Out of scope - R1C-A (M) and R1C-D (M-L) worker briefs — meatier; defer to next PM iteration - Implementation of any worker brief (R1 Closure Manager dispatches at spawn) - Authority matrix structural normalization per openai-pro PAUSE_AND_REGROUP meta-review — escalation-paths.md + thesis-claim-coverage.md provide evidence base; matrix authoring optional next iteration Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
briansrls
commented
Apr 26, 2026
briansrls
left a comment
briansrls
left a comment
Contributor
Author
There was a problem hiding this comment.
Review metadata
- Provider / model:
codex/unknown - Commit:
3a4e668e· Trigger:schedule - Thinking:
309s wall
BLOCKING (2)
Root Cause
docs/briefs/r1-closure-manager.mdR1C-B/C/E/F worker briefs were added after the manager brief's status section was drafted → mark B/C/E/F as authored, leave only A/D pending, and refresh the working-state line.docs/escalation-paths.mdFix 3 updated docs/design-substrate-carrier-port-program.md but the map rows were not refreshed → change rows 22 and 25 to Director as the receiver and C1 lane as only the optional dispatch outcome.
Non-blocking — Improvements (fix in-PR if easy, else defer to roadmap)
ROADMAP.mdThe new R1 Closure Manager paragraph cites THESIS.md §"Tests are structural data", but that heading is not present; use the existing ROADMAP gate authority or add the missing thesis anchor before relying on it.
|
|
||
| ## Sub-briefs (authored / pending) | ||
|
|
||
| Authored: none (this is a new manager; lane sub-briefs dispatch from this document). |
Contributor
Author
There was a problem hiding this comment.
BLOCKING: The manager brief still says Authored: none and lists R1C-B/C/E/F as pending even though this PR adds those worker briefs, so the dispatch authority is stale and violates P2 single-authority/P5 status discipline.
| | 19 | `docs/briefs/t-impossiblebugs-nested-optional-flatten-worker.md:72` | Surface-upstream investigation reveals `T??` parses to something other than nested `OptionalOf` | STOP; Director-call on which surface to dissolve | GROUNDED | | ||
| | 20 | `docs/briefs/t-impossiblebugs-nested-optional-flatten-worker.md:72` | Only some-but-not-all consumers see nested form | STOP; surface for dissolution decision | GROUNDED | | ||
| | 21 | `docs/briefs/t-impossiblebugs-nested-optional-flatten-worker.md:73` | Substrate-attachment requires inventing fundamental new vocabulary beyond cardinality-substrate | STOP; may indicate lane is mis-scoped | SOFT | | ||
| | 22 | `docs/design-substrate-carrier-port-program.md:120` (Lane E-T) | Carrier requires substrate connective not already present | Escalate to C1 lane (Director opens C1 substrate-capability lane — see Fix 3 below) | GROUNDED | |
Contributor
Author
There was a problem hiding this comment.
BLOCKING: The union map still records the E-T/E-P action as "Escalate to C1 lane" after this PR rewrites the source clauses to escalate to Director, so the new single escalation map conflicts with the fixed authorities it summarizes.
…eta-review) Per openai-pro PAUSE_AND_REGROUP meta-review on PR #835 sha bfaab66, the recurring "authority ambiguity at stage boundaries" pattern (B7 dual-contract, Grounding pending unbounded, §6a stale framing, B4.1 stale BLOCKING) was being fixed instance-by-instance via wording sweeps. The structural fix is a shared authority matrix that makes the categories disjoint at brief-authoring time. This commit graduates the recurring class out of per-instance review. ## docs/briefs/r2-manager-brief-authority-matrix.md (new) 5 disjoint artifact categories with explicit invariants: 1. Worker brief — dispatchable authoring task; produces concrete deliverable 2. Decision brief — scoped design call (pick + lock); follow-through is distinct Category 1 worker brief (resolves §6a anti-pattern) 3. Cross-manager signal — routes priority/scope info; NOT a worker brief (resolves B7 anti-pattern) 4. Standing reporting duty — continuous-state ledger / monitor; activates on spawn, dissolves on manager dissolution 5. Pre-spawn placeholder — skeleton authored before spawn; graduates into 1-4 OR dissolves at spawn Per-manager deliverable inventory tags every owned deliverable from all 6 R2 managers (Grounding / Substrate / Modeling / Impossible-Bugs / Pure Bootstrap / Release) with category. Inventory references PR #835 (manager briefs), PR #836 (14 Director worker briefs), and PR #847 (this PR's worker briefs + signal doc). Local review checklist (per meta-review recommendation #3): Owned deliverables + Pre-spawn vs post-spawn authority + Autonomous dispatch authority + Sub-briefs sections must agree on owner + artifact type per matrix categorization. Doesn't need new top-level INVARIANTS rule; P2 + P5 already cover; this is the local invariant for the manager-brief family. ## Sweep verification — current state of 6 R2 manager briefs (PR #835 sha 3260d71) All 6 manager briefs verified consistent with matrix: - Grounding: ✅ no category conflicts (Pending bounds fixed in f916fba) - Substrate: ✅ no category conflicts (B4.1 staleness fixed in 74b679b) - Modeling: ✅ no category conflicts - Impossible-Bugs: ✅ no category conflicts (filenames fixed 70df547) - Pure Bootstrap: ✅ no category conflicts - Release: ✅ no category conflicts (B7 dual-contract fixed f916fba; §6a stale framing fixed 74b679b + 3260d71) No additional fix-pushes needed on PR #835 from this matrix introduction. ## docs/r2-structure.md (edit) Added "Manager-brief authority matrix" paragraph in §"Manager structure" preamble, citing the matrix doc as authority. Manager briefs now cite the matrix and stop self-categorizing. ## What this PR (#847) now contains Cumulative deliverables: - docs/briefs/r1-closure-manager.md (R1 Closure Manager brief, 6 lanes) - docs/briefs/r1c-b/c/e/f-*.md (4 trivial R1C lane worker briefs) - docs/briefs/r2-release-6a-follow-through-worker.md - docs/briefs/r2-release-b5-loop-construction-closure-audit-worker.md - docs/briefs/r2-release-b6-file-preference-rank-checklist-worker.md - docs/briefs/r2-release-b7-priority-hint-relay-to-pure-bootstrap.md - docs/briefs/r2-manager-brief-authority-matrix.md (this commit) - docs/escalation-paths.md (45-clause union map) - docs/thesis-claim-coverage.md (74-claim coverage map; 0 GAPs) - ROADMAP.md edit — R1 Closure Manager registration section - docs/r2-structure.md edits — signal channel + Director decision artifact + authority matrix reference (this commit) - docs/design-substrate-carrier-port-program.md edits — Fix 3 (C1 lane explicit owner) ## What's outstanding (out of scope for this PR) - R1C-A and R1C-D worker briefs (M and M-L; meatier; deferred per user's "trivial ones" direction) - Sweep of PR #836's 14 worker briefs against the matrix at PR #836 merge (current sweep is main-only) - Authority matrix becomes ACTIVE on R1 closure → R2 promotion transition per the matrix's status; PROPOSAL until then Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Contributor
Author
|
Review metadata
Docs-only PR adding manager briefs and escalation/authority infrastructure. No code, no substrate types touched. Cross-references look consistent. Edits to existing docs are additive and align with the manager-brief discipline already in r2-structure.md. Verdict: APPROVE — Docs-only PR (briefs + cross-cutting escalation map + authority matrix). Modifications to existing docs are additive and internally consistent (escalation channel single-authority clause matches the new union map; C1-lane references in design-substrate-carrier-port-program.md correctly redirected through Director per the new escalation discipline). Nothing in the diff touches substrate, carriers, or Rust code, so the modeling/coding/testing rubrics don't bind here. No concerns. |
…ants Two additions to the local review checklist on the R2 manager-brief authority matrix, both surfaced by review activity since the matrix's initial landing: ## Status-consistency rule openai-pro APPROVE_WITH_COMMENTS on PR #835 sha 3260d71 found T-Ground-Rust in two contradictory states: deliverables table said DISPATCHED, but Sub-briefs Pending list said "T-Ground-Rust full implementation" pending. Same lane, two authoritative states — the matrix's existing checklist covered owner + artifact type but not status, leaving room for this class. Added rule: a single deliverable cannot be both DISPATCHED/AUTHORED in the deliverables table AND Pending/NOT YET AUTHORED in the Sub-briefs section. Partial-state lanes must scope the partial explicitly in the table (e.g., "PARTIAL — Pilot PR #X done; full implementation pending"). Sub-briefs section is single authority for authored-vs-pending; deliverables table cites that authority without duplicating ambiguously. Fixed in 3ef1509 on PR #835 (T-Ground-Rust row scoped to NOT YET AUTHORED). ## Pre-author verification invariant Director's PR #836 hit feedback_verify_thesis_claims 7 times in one PR authoring cycle (consistently: brief authored without grepping source-of-truth before slicing). The pattern is a separate failure class from categorization — not what the matrix's prior checklist addressed. Added invariant: before authoring a brief that references substrate state, gate condition, existing brief, or design-doc disposition, grep src/v3/std/ + src/v3/spec/ + src/v3/compiler/src/ for state cited; grep docs/briefs/ for existing canonical briefs; read the design doc's §Director-actionable / §Q-recommendation / §Decision in full. Cite specific file:line / brief filename / §ref in Read first. State audit receipt before slicing. This operationalizes feedback_verify_thesis_claims for the brief-authoring family. Doesn't need a new INVARIANTS rule; cited existing P2 + P5 + feedback_verify_thesis_claims as authority. Local invariant collected here as a single review checkpoint. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
…er briefs) Per user direction "lets keep going here until we have full dispatch/briefing for both with thorough review please" — authored the two non-trivial R1 Closure Manager lane worker briefs deferred earlier per "do the trivial ones" direction. R1 Closure Manager lane queue now fully authored. ## R1C-A — T-TestGen schema extensions (M-L; was M before audit) Pre-author audit at main HEAD 407a8bc (per matrix verification invariant) revealed three coupled sub-deliverables, sized M-L total: - **Sub-deliverable A — M1(2.8) list-body lowering for `data` declarations.** Compiler work in lower.rs:2446 (currently rejects `data: List<T> = [...]` as ValueBody::Unparsed). Predecessor for MockBackedInvariant fixture authoring + 6 PB-census predicate authoring. Substrate dependency: T-Substrate ValueBody-list/sum (PR #790; R2 sub-lane) — verify substrate state at brief- dispatch time per feedback_thesis_gate_state_drift. - **Sub-deliverable B — Predicate-shape scoping for 6 PB-census gates.** No `.dag` predicate shape exists for any of the 6 census gates today; ROADMAP line 65 names T-TestGen as scoping authority. R1C-A authors them from scratch. Proposed shapes: CensusBoundCheck / CensusSubsetCount / FixedPointConverges / RatchetZero / GeneratedFromDag (per gate). Audit-first: grep dsl/std/ test_infrastructure.dag for existing predicate-variant pattern; mirror schema discipline. - **Sub-deliverable C — MockBackedInvariant minimal-demo fixture.** Closes testgen_mock_backed_integration_safe gate. Depends on Sub-deliverable A (fixture body uses list literal). 5-10 lines `.dag`. Slice: A → B → C, sequential. STOP-AND-ESCALATE if substrate variant absent, predicate shapes need substrate work, or DB-8 drifts. ## R1C-D — T-PB census-as-`.dag` (M-L) Pre-author audit established census authority at sg0_census_test.rs:166-297 (EXPECTED_HAND_AUTHORED_NON_TEST 41 entries; EXPECTED_HAND_AUTHORED_TEST 77 entries; EXPECTED_HAND_AUTHORED_FRAGMENTS 1 entry). Drift test sg0_v3_hand _authored_census at :387-451 panics with narrative on mismatch. 6 fixtures, one per census gate, each consuming an R1C-A Sub-deliverable B predicate shape: - D.1 pb_hand_rust_at_shim_floor (CensusBoundCheck on NON_TEST list) - D.2 lens_producer_files_remaining (CensusSubsetCount on lens-producer pattern) - D.3 pb_self_compile_fixed_point (FixedPointConverges on bootstrap snapshot) - D.4 pb_compiler_std_ratchet_zero (RatchetZero on consolidation ratchet) - D.5 pb_test_file_generated_from_dag (GeneratedFromDag on test partition) - D.6 pb_rust_tests_outside_residual_zero (CensusBoundCheck on TEST list) Dispatch gated on R1C-A Sub-deliverable B landing. STOP-AND-ESCALATE if predicate shapes don't capture gate semantics (back-pressure to R1C-A); or if cascade-promotion 0-floor work hasn't reduced census to 0 by R1 close declaration time (gates D.1/D.2/D.6 stay RED; Director arbitration). ## R1 Closure Manager status sync Updated r1-closure-manager.md deliverables table + Sub-briefs section to reflect all 6 lane worker briefs as AUTHORED (per matrix's status-consistency rule — table cannot say NOT YET AUTHORED while worker briefs are landed). R1C-A row sized up from M to M-L per audit revealing Sub-deliverable A is compiler work. ## Matrix invariants applied Both new briefs follow the matrix's local checklist: - Categorization: Category 1 (worker brief) — explicit in Cross-refs - Owner / artifact type / status — consistent across deliverables, slice, acceptance, STOP-AND-ESCALATE sections - Pre-author verification — explicit audit receipt section at top of each brief with file:line citations to runner / lowering / schema / census - Discipline anchors named (feedback_construction_over_ratchets, feedback_audit_adjacent_authority_first, feedback_thesis_gate_state_drift, feedback_verify_thesis_claims, feedback_compiler_is_dag_processor, feedback_foundation_over_speed) ## What this PR (#847) now contains (final state expected) - R1 Closure Manager brief + ROADMAP registration + 6 lane worker briefs (R1C-A through R1C-F) — full R1 closure dispatch surface - §6a follow-through worker brief - B5 / B6 / B7 (worker briefs + signal doc) - Escalation-paths union map (45 clauses) - Thesis-claim coverage map (74 claims, 0 GAPs) - Authority matrix (5 categories + per-manager inventory + status-consistency + pre-author verification invariants) - ROADMAP + r2-structure.md + design-substrate-carrier-port-program.md edits R2 spin-up brief queue: complete. R1 closure brief queue: complete. PM inbox #828 fully delivered. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Contributor
Author
|
Review metadata
Findings
Verdict: APPROVE_WITH_COMMENTS — The bundle is coherent on P2-style single authority for union maps (“descriptive union, sources prescriptive”), P5-style scaffolds with named dissolution triggers, and the escalation-path / Exploratory (optional): Several thesis rows lean on T-Emit / T-P0 gates that this PR still treats as closure work in other files; a quick pass for the same “ |
Self-review pass against the matrix's pre-author verification invariant caught two factual citation misses in r1c-a-t-testgen-schema-extensions-worker.md: ## BLOCKING — wrong file path for TestClaim schema (4 occurrences) Brief cited `dsl/std/test_infrastructure.dag` and `src/v3/std/test_infrastructure.dag` in 4 places (audit receipt at :17 + Sub-deliverable B framing at :61, :66 + Slice PR-B at :87 + Cross-refs Schema authority at :119). That file does NOT exist on main HEAD 407a8bc. The actual TestClaim schema authority lives at: - DSL-side: `dsl/std/verification.dag` (TestClaim at :36; full schema) - v3-mirror: `src/v3/std/verification.dag` (TestClaim.requires at :187) All 4 occurrences corrected to point at the real file. Schema authority line in Cross-refs now also explicitly cites `dsl/std/verification.dag:36` (DSL-side type declaration) for completeness. ## MINOR — predicate dispatch line range was off Brief cited "Predicate dispatch inventory at test_runner.rs:1423-1431 has all 10 predicates wired" — but lines 1423-1431 only contain 9 predicates (Compiles through ExecuteCommand); MockBackedInvariant arm starts at line 1432 and runs through 1448. Corrected to: "in the match block at test_runner.rs:1424-1448 has all 10 predicates wired (Compiles / FailsWithDiagnostic / OutputEquals / PortHasState / CostBounded / LensOutputEquals / DifferentialEquals / AlgebraicLaw / ExecuteCommand wired across :1424-1431; MockBackedInvariant arm at :1432-1448)." ## MINOR — ResourceReference line range corrected Brief cited `src/v3/std/resources.dag:25-27` — actual range is :25-26 (the type spans 2 lines, not 3). Corrected. ## Discipline note Both misses were exactly the failure mode `feedback_verify_thesis_claims` names: state cited from memory rather than grepped at brief-authoring time. The pre-author audit was largely accurate (runner :1432-1448 quote was exact; lower.rs:2446 diagnostic was exact; census line ranges all correct), but two slips made it through. The matrix's pre-author verification invariant worked at the self-review pass level — caught before automated reviewers. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Contributor
Author
|
Review metadata
Findings
Verdict: REQUEST_CHANGES. The overall structure is coherent, but the matrix needs to either land with the manager briefs it governs or clearly downgrade the PR #835-derived inventory to a non-authoritative pending snapshot until those files exist on main. |
This was referenced Apr 26, 2026
briansrls
added a commit
that referenced
this pull request
Apr 26, 2026
…close in r1-surface-manager.md Per codex API review on commit 5d8d333 (BLOCKING #1 of 2): "Gate status conflates implementation receipts with R1 acceptance gates → split receipt progress from .dag TestClaim status and leave gates unchecked until the claim exists and evaluates." Fix: - SUPERSEDED banner at top declaring R1 Closure Manager owns gate-close authority post-PR-#847; brief stays as historical receipt. - Working state table reshaped into Impl / Gate / Owner columns: * T-P0: 3× impl [x], 3× gate [ ] (owned R1C-B) * T-Sub: match closed (impl + gate); type-alias impl [x] gate [ ] (R1C-C); charclass-2 phase-2 reclassified to R2 substrate * T-Emit: all 3 impl partial, all 3 gate [ ] (R1C-E wraps host harness via ExecuteCommand) The strict-reading R1 closure criterion (per ROADMAP single authority + THESIS "the release gate IS a .dag program") makes implementation-receipt [x] insufficient for gate close. R1 Closure Manager dispatch lanes are the actual gate-close path. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This was referenced Apr 26, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two PM-portion deliverables, bundled per the user-preferred bundling cadence for multiple workstreams.
1. R1 Closure Manager brief (
docs/briefs/r1-closure-manager.md)Strict-interpretation gate-close authority. Per-HEAD audit found 12+ unwired R1 gates under strict reading ("the release gate IS a
.dagprogram" per THESIS):MockBackedInvariantrunner returnsNotYetImplemented(M1(2.8)List<ResourceReference>data body blocker).dagTestClaims.dagwrappersSix mutually-exclusive lanes (R1C-A through R1C-F) at fixture-file / runner-dispatch-arm level. R1C-A unblocks R1C-D; other 4 lanes parallel Day-1. Per user direction: T-PB-A+B merged into R1C-D; T-Emit kept (no host-harness pragmatic acceptance).
Manager dissolves on R1 all-gates-green; R2 managers spawn post-dissolution. No overlap.
2. Escalation-paths union map (
docs/escalation-paths.md)Sweep against main HEAD
407a8bcb1cataloged 45 "if X happens, escalate" clauses across INVARIANTS / ROADMAP / THESIS / r2-structure.md / docs/briefs / docs/design / docs/thesis.No significant authority conflicts. Three minor naming-tightening opportunities surfaced; addressed inline as the three surgical fixes below.
Sweep boundary is main-only. PR #835 (PM 6 R2 manager briefs) and PR #836 (Director 14 worker briefs) are NOT in this sweep — second-pass map merge planned on those PRs' merge to main.
3. Three surgical fixes to source authority docs
Each closes an open-resolution-path gap the sweep surfaced:
docs/r2-structure.md§"Manager structure"). New paragraph naming GitHub session-inbox issue comment as the escalation channel for human-target; cross-manager queue for inter-manager signals.docs/r2-structure.md§"Director"). Extended scope-change-escalation bullet to name where Director's adjudication lands: amendment PR or sibling brief.docs/design-substrate-carrier-port-program.md). Two STOP-AND-ESCALATE clauses (Lane E-T:120+ Lane E-P:148) rewritten from "→ C1 lane" to "→ escalate to Director (Director opens a C1 substrate-capability lane if escalation requires substrate work)."Out of scope for this PR
escalation-paths.mdprovides initial evidence base for future matrix authoring)Per-PR dissolution gate
src/v3/. Two new doc files (intentional creation per the PM mandate); two surgical text edits to existing authority docs (1-2 lines each).Test plan
escalation-paths.mdreference real file:line citations on main HEAD407a8bcb1🤖 Generated with Claude Code