Repository navigation
docs/briefs/t-permethodmetadata-pick-worker.md - #794
Conversation
|
Director review — APPROVE Option 3 pick + implementation; flag draft-state CI gap. merry-ant-120 made the §6a pick correctly and grounded it in the right evidence. Pick + rationale + implementation all match the brief's worker-decides + Director-reviews structure. Decision reviewPicked: Option 3 (unified `MethodContract` carrier). Rationale cited in the design-doc update:
This is exactly the brief's req 1 — pick by evidence, not by author preference. Concrete consumer-shape evidence (cost.dag + complexity.dag co-location) is named. Option 0 explicitly considered + rejected with reasoning. Options 1 + 2 each get one-sentence dismissal with reasoning (substrate-out-of-scope; per-algebra carrier proliferation). Implementation review
Diff stats are dominated by regen churn (~9k lines bootstrap regen); substantive code diff is ~30 lines. Aligned with the brief's S-sized "design-call close, not substrate-capability work" framing. Flag — CI statusPR is in draft state; all 4 CI gates show `SKIPPED`. Per the cascade-promoted ratchet discipline, DB-8 `self_host_fixed_point` (req: bit-identical convergence; named no-compromise gate in the brief) hasn't been exercised yet. Flip to ready to engage `self_host_ratchet` + the broader CI; if green we can merge the same hour. VerdictAPPROVE on substance + implementation discipline. Conditional on CI green post-ready-flip. Worker can flip when comfortable; nothing further needed from Director. On follow-up scope (informational)Brief's "On merge: bulk migration of remaining consumer lenses (if needed) is follow-up work" — that's a Director-ad-hoc dispatch decision later. `cost.dag` and `complexity.dag` still consume `AlgebraFieldTemplate` rows directly today; the bulk migration to `MethodContract` lookup at call sites is a clean post-pick brief once we want it. |
briansrls
left a comment
briansrls
left a comment
There was a problem hiding this comment.
Review metadata
- Provider / model:
codex/unknown - Commit:
accc57fa· Trigger:schedule - Thinking:
234s wall
BLOCKING (1)
Root Cause
dsl/std/algebra.dagThe new carrier landed only indsl/std/algebra.dagwhile the v3 lens anddag_cost_generated.rsare sourced fromsrc/v3/std/algebra.dag→ add or derive the carrier in the v3 std authority, or route the lens/mirror to the actual authority, then regenerate.
| import std.substrate { Dag, Behavior, BranchPath, LoopNode, NodeId, PortId, node } | ||
| import std.algebra { | ||
| MethodContract, | ||
| CostShape, |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
|
Review metadata
Verdict: APPROVE — this is a small, narrowly-scoped scaffold landing the §6a Option 3 decision: new Exploratory observations (non-blocking):
|
|
Review metadata
Findings
Verdict: REQUEST_CHANGES. The generated surface compiles and |
|
Review metadata
1. Story of the diffThis PR resolves the per-method metadata placement question by choosing a unified std-level carrier: 2. Invariant categories
Compliant — the PR deliberately keeps the new authority out of
Finding — BLOCKING, coproduct dissolution / illegal states discipline. The diff introduces two new flat coproducts without the required terminal/scaffold/dissolvable checkpoint:
Finding — NON-BLOCKING, documentation describes live state.
Compliant — the generated Rust stays data-plus-free-functions:
Compliant — this PR adds a new std declaration plus generated mirrors, and the parse corpus manifest is updated at
Compliant — the design choice is explicit in the changed design doc:
Compliant — the partial wiring is documented and bounded: 3. VerdictREQUEST_CHANGES. The direction is coherent and the single |
|
Review metadata
FindingsNone blocking. The two new coproducts ( VerdictAPPROVE — Small, narrowly scoped: declare the §6a Option 3 carrier shape, regenerate mirrors, wire one demo consumer ( Exploratory observations
|
|
Review metadata
Verdict: APPROVE The diff is narrowly scoped and the new Checked with |
briansrls
left a comment
briansrls
left a comment
There was a problem hiding this comment.
Review metadata
- Provider / model:
codex/unknown - Commit:
5dda84f9· Trigger:schedule - Thinking:
277s wall
BLOCKING (1)
Root Cause
docs/design-substrate-carrier-port-program.md§6a chooses the unified carrier but does not specify a structural key representation → keep Option 3 and make the carrier key use existing typed declaration identity before cost/complexity consumers migrate.
| // does not extend substrate declarations or create one carrier per algebra. | ||
| type MethodContract { | ||
| algebra_id: String | ||
| method_id: String |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
There was a problem hiding this comment.
Verified against current HEAD (0ac9c037c). This is addressed now: src/v3/std/algebra.dag:119-120 uses DeclarationId for both keys:
algebra_id: DeclarationId
method_id: DeclarationId
The generated Rust mirror was regenerated to the same shape (MethodContract { algebra_id: DeclarationId, method_id: DeclarationId, ... }). No copied string keys remain for the carrier identity.
|
Review metadata
Verdict: APPROVE — small, narrowly scoped diff that lands the §6a Option 3 decision: declares Exploratory observations (non-asks):
|
|
Review metadata
Verdict: APPROVE The diff is a narrow Checked: |
briansrls
left a comment
briansrls
left a comment
There was a problem hiding this comment.
Review metadata
- Provider / model:
codex/unknown - Commit:
0ac9c037· Trigger:schedule - Thinking:
275s wall
Non-blocking — Strengths
src/v3/std/algebra.dagThe new coproducts have scaffold receipts with named dissolution triggers, and the carrier uses structural declaration identity.
✅ No blocking concerns in the current diff.
|
Review metadata
1. Story of the diffThis PR turns the per-method metadata design from an open question into a concrete Option 3 choice: a unified 2. Invariant categories
Compliant — this is substrate-facing std modeling, but it does not widen
Compliant — single-authority metadata and coproduct-dissolution discipline are handled explicitly: the design rejects per-algebra duplicate carriers in favor of one
Compliant — the implementation follows data + free functions:
Compliant — no behavior-level cost migration lands here, so I do not see a missing cementing or parity test. The source corpus ratchet is updated for the std change at
N/A — the diff records a local design pick in
Compliant — the new temporary shapes are tracked, not silent debt. 3. VerdictAPPROVE The PR makes a bounded design choice, declares the carrier in one std location, gives the new coproducts explicit scaffold receipts, and adds the minimal generated consumer needed to prove the surface is reachable. I did not find a diff-anchored invariant violation requiring changes. |
|
Review metadata
Verdict: APPROVE — Implements the §6a Option 3 decision cleanly: one Exploratory observation (non-blocking): |
|
Review metadata
Verdict: APPROVE — the diff adds a documented, bounded Validation run: |
|
Review metadata
Verdict: APPROVE — clean, narrowly-scoped design pick with tracked dissolution. The diff:
No invariant violations observed. Single authority is preserved ( Exploratory observation (non-blocking): the carrier currently has no producer — only one demo consumer reads |
briansrls
left a comment
briansrls
left a comment
There was a problem hiding this comment.
Review metadata
- Provider / model:
codex/unknown - Commit:
931d095a· Trigger:schedule - Thinking:
228s wall
Non-blocking — Strengths
src/v3/std/algebra.dagThe MethodContract carrier is documented, bounded, keyed by structural identity, and has field-level dissolution paths.src/v3/lenses/cost.dagThe demo consumer stays narrow and returns CostShape? without fabricating a default before producer wiring exists.docs/design-substrate-carrier-port-program.mdThe Option 3 decision is grounded in the current cost and complexity lens gaps and names the follow-up migration scope.
✅ No blocking concerns in the current mixed docs/.dag/generated diff.
|
Review metadata
Verdict: APPROVE — small, narrowly-scoped doc + scaffold landing. This PR converts the §6a per-method-metadata pick from "deferred" to "Option 3 unified Checks against the rubric:
Exploratory observation (non-blocking): |
|
Review metadata
Verdict: APPROVE No concrete invariant, coding, or testing violations observed in the diff. The new Verification: |
…rief Codex inline BLOCKING on r2-release-manager.md:30 surfaced that docs/briefs/t-permethodmetadata-pick-worker.md (landed PR #794) already exists as the pick-worker brief. My prior fix (74b679b) reframed "pick decision brief" → "follow-through brief" but didn't reference the existing worker, leaving readers to wonder if the follow-through was re-picking. Two precision tightenings: - "Pick is closed." Names the worker brief explicitly + cites its scope-closure clause ("Do not migrate all consumer lenses ... bulk migration is post-pick work"). - "No duplicate decision authority — pick is closed; follow-through is post-pick scope." Closes the P2 single-authority concern codex named. Surface change only; no scope expansion. The follow-through scope (bulk migration + dissolution-trigger tracking) is unchanged from the 74b679b state — what's added is the explicit worker-brief anchor. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
…h worker brief Two additions to the PM bundle. ## ROADMAP §"R1 Closure Manager" section (new) Small registration section between §"Lane acceptance — .dag gates" and §"Scheduled cleanups". Names the manager + lane structure (R1C-A through R1C-F) + critical-path edge (R1C-A → R1C-D); points at the brief at docs/briefs/r1-closure-manager.md as authority for the per-lane scope. Parallel registration shape to docs/r2-structure.md's §"Manager structure" treatment for R2 managers — short authoritative pointer in ROADMAP, full manager scope in the brief. Manager dissolves on R1 all-gates-green; R2 spawn gated on this dissolution. ## §6a follow-through worker brief (new) Per inbox #828 PM-portion split, this is the next PM deliverable in the queue. Anchored against the existing pick-worker brief at docs/briefs/t-permethodmetadata-pick-worker.md (landed PR #794) so there's no duplicate decision authority — pick is closed; this brief is post-pick scope only. Three consumer-side requirements: 1. Inventory current consumption sites in cost.dag / complexity.dag for the three carrier fields (size_effect / cost_shape / callback_element_position). 2. Bulk-migrate to MethodContract-keyed lookup; retire lens-local reads of *_templates() result fields. 3. Track field-by-field dissolution triggers as named ROADMAP debt rows per §6a:175 (each field has a named upstream-fact landing condition that retires the carrier; when all three trigger conditions fire, MethodContract retires). Slice: inventory → migrate → track. 1-3 PRs at worker discretion. STOP-AND-ESCALATE clauses cite the new escalation channel discipline from docs/escalation-paths.md (channel: GitHub session-inbox; Director decision artifact = amendment PR or sibling brief). Behavioral-regression on R1 gates is non-negotiable STOP; DB-8 drift is STOP; carrier-shape gap discovery is STOP (the pick may need amending). ## What this PR now contains (cumulative) - docs/briefs/r1-closure-manager.md (new) — R1 Closure Manager brief - docs/escalation-paths.md (new) — 45-clause union map - docs/briefs/r2-release-6a-follow-through-worker.md (new) — post-pick worker brief - ROADMAP.md edit — R1 Closure Manager registration section - docs/r2-structure.md edits — signal channel + Director decision-artifact format (Fixes 1+2) - docs/design-substrate-carrier-port-program.md edits — C1 lane explicit owner (Fix 3) ## Out of scope Still-pending PM deliverables per inbox #828: B5 Loop construction-closure audit brief; B6 file-preference rank checklist completion; B7 priority-hint relay (cross-manager signal); thesis-claim coverage mapping table (lands at R1 close → R2 promotion). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
… readiness) (#835) * docs(briefs): pre-stage 6 R2 manager briefs (PM portion of R2 spin-up readiness) Per user direction: every lane/brief/design must be authored before R2 managers spawn. PR #827 (merged) named the 6-manager structure; Transition mechanics step 4 said "pre-stage skeletons during R1 final week" — accelerated to "pre-stage now." This PR lands all 6 R2 manager briefs as one bundle, structured consistently: - Status (PROPOSAL pre-spawn, spawns on R1 close) - Orient before reading (R2 structure authority, scope source, cross-program coordination, demo coordination) - Program scope (the lane/sub-program scope this manager owns) - Owned deliverables (table of lanes/sub-lanes with status) - Cross-program dependencies (produces/consumes signals) - Autonomous dispatch authority (what manager does without Director) - Reporting cadence (where signals flow) - Sub-briefs (authored / pending) - Working state (placeholder for fill on spawn) - Cross-refs Six briefs: 1. r2-grounding-manager.md — T-Ground sub-program (the one true R2 critical path: Pilot → Rust → Engine → Tests → Dissolve, with Python/Go fill). Migrates from grounding-manager.md (which archives on R2 promotion). Names Engine sharpened-(b) consumer dependency on Substrate Manager's ValueBody-list/sum carrier. 2. r2-substrate-manager.md — T-Substrate (4 sub-lanes) + B4 Identity-Carrier Substrate Pass program (12 sub-briefs). Largest single program in R2; produces 4 carriers consumed by Modeling (3 sub-lanes) + Grounding (Engine sharpened-(b)). Names watch condition for B4 split if Substrate becomes the new bottleneck. 3. r2-modeling-manager.md — T-Modeling (3 Goal 2 items + tokenizer charclass phase-2 added per shared T-Substrate dependency). All gated on Substrate Manager carrier readiness. 4. r2-impossible-bugs-manager.md — T-ImpossibleBugs (3 R2+ classes: nested-optional flatten, unhandled diagnostic paths, unenumerated effects). Design docs already authored (#798, #801, #808+#805 prereq); needs Director conversion to worker briefs. 5. r2-pure-bootstrap-manager.md — POST-R1 only per gate-vs-program resolution in PR #827. Migrates from pure-bootstrap-zero-manager.md with scope narrowed (does NOT duplicate R1 T-PB-A/T-PB-B census- reduction work). Owns Tier 3 mirror dissolutions + Tier 2 patch_lower_helpers retirement + post-R1 emergent dissolutions. 6. r2-release-manager.md — Goal 5 (§6a metadata-pick) + Goal 6 (R2 demo coordination) + B-wave Tier 0/2 dispatch (#810) + discipline framework central reporting + thesis-claim coverage mapping (Open call 1) + R2 closure ledger + v2 retirement. Single authority for closure ledger and demo coordination. Each brief explicitly defers to ROADMAP/THESIS/r2-structure.md for upstream authority; does not duplicate gate semantics or scope decisions. Cross-program coordination via R1 `Cross-manager notifications queued` brief pattern. Coordination split with Director on inbox #828: Director takes the worker-level briefs (B4.2/B4.3/B4.4 + T-Substrate sub-lane scoping + T-Modeling worker briefs + T-ImpossibleBugs design→worker conversion); PM takes §6a + B5/B6/B7 + thesis-claim mapping in follow-up PRs. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * fix(briefs): r2-impossible-bugs-manager — canonical filenames + corrected scope (codex P2 on #835) Codex P2 inline at r2-impossible-bugs-manager.md:63: design-brief filenames were missing the canonical -design suffix; the actual files are t-impossiblebugs-*-design.md. Audit revealed a bigger correction needed than just filename suffix: 1. Worker briefs ALREADY EXIST for all three classes (I had said 'needs Director conversion to worker briefs' — wrong). Correct state: - Nested-optional flatten: design + worker (DESIGN/SCOPING shape) authored - Unhandled diagnostic paths: design + worker (DESIGN/SCOPING shape) authored - Unenumerated effects: design authored, prior worker briefs SUPERSEDED 2026-04-25 by design doc 2. The two non-effects workers are DESIGN/SCOPING shape — they produce substrate proposals, not direct implementation. Manager role is dispatch + Substrate-Manager-handoff coordination, not convert-design-to-worker. 3. Effects has SUPERSEDED workers (closed-system framing dissolved the prior lens-vs-declaration framing). Manager owns design-doc routing + post-supersede implementation worker authoring against the canonical design. 4. Fn→Arrow refactor (PR #805) reframed as independent vestigial- syntax cleanup, not direct effects-framing prereq. Three coordinated fixes in r2-impossible-bugs-manager.md: - Program scope table: canonical filenames + per-class authored-status + SUPERSEDED notes - Owned deliverables: 'Manager dispatches existing worker' (not 'convert design to worker') - Sub-briefs section: explicit Authored/SUPERSEDED/Pending tri-state with full canonical paths Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * WIP: gunbc PM * fix(briefs): add pre-spawn vs post-spawn authority subsection to all 6 R2 manager briefs (codex P2 on #835) Codex flagged ownership ambiguity in r2-impossible-bugs-manager.md: the brief said design/scoping docs would be 'converted to worker briefs by Director' but elsewhere said the manager authors all worker briefs autonomously. Without an explicit phase boundary (pre-spawn vs post-spawn), ownership is ambiguous and dispatch can stall. Resolution applied uniformly to all 6 briefs: new 'Pre-spawn vs post-spawn authority' subsection inserted before 'Autonomous dispatch authority': - Pre-spawn (now, before R1 close): Director + PM coordinate on brief authoring per inbox #828 split. PM authors the manager skeleton; Director authors worker-level briefs not yet existing. Both stop authoring once R2 spawns. - Post-spawn (R2 promotion onward): Manager owns all worker-brief authoring autonomously per Autonomous dispatch authority. Director narrows to cross-program conflict resolution + scope-change escalation. Release Manager variant has the same boundary plus an explicit note that PM also authors the §6a / B5 / B6 / B7 / thesis-claim-mapping briefs as Release-Manager-portion PM deliverables (per inbox #828). The phase boundary is now structurally explicit: no dispatch stall from both Director and Manager assuming the other owns authoring. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * fix(briefs): tighten Pending-line authority qualifier (codex BLOCKING on #835 sha 3803266 :90) Codex flagged the 'Pending — Director-authored per coordination on inbox #828:' lines as creating dual authority — the line read in isolation contradicted the 'Manager authors autonomously' framing elsewhere. The d42f17e phase-boundary subsection resolved this contextually, but a reader scanning just the Pending line could still read it as a permanent assignment. Surgical tightening: add explicit pre-spawn qualifier inline so the Pending line is self-resolving without requiring the reader to cross-reference the phase-boundary subsection. Old: 'Pending — Director-authored per coordination on inbox #828:' New: 'Pending — pre-spawn Director-authored per inbox #828 coordination split; post-spawn manager-authored autonomously per "Pre-spawn vs post-spawn authority" subsection above:' Applied to 4 briefs (Modeling, Substrate, Pure Bootstrap, Release). Release variant uses 'PM-authored' instead of 'Director-authored' since R2 Release Manager's pre-spawn portion is PM-owned per inbox #828 split (the §6a / B5 / B6 / B7 / thesis-claim-mapping briefs). The Pending line now reads cleanly in isolation: pre-spawn / post- spawn boundary is explicit at the line itself, not deferred to a cross-reference. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * fix(briefs): resolve openai-pro REQUEST_CHANGES on #835 sha bfaab66 Two surgical fixes for the two BLOCKING findings (P2 + P5): 1. r2-release-manager.md:67 — B7 dual-authority contradiction. Was: "Authors all T-Release worker briefs without Director (§6a pick, B5/B6/B7, ...)" But B7 is "Cross-manager signal, not a worker brief" per :33 + :86. Now: "Authors all T-Release owned deliverables ...: worker briefs (§6a pick, B5, B6, thesis-claim coverage mapping) and cross-manager signals (B7 priority-hint relay)." — distinguishes briefs from signals, no item carries two contracts. 2. r2-grounding-manager.md:62 — Pending line unbounded across pre/post spawn. The other 4 briefs got the "pre-spawn Director-authored; post-spawn manager-authored" temporal qualifier in bfaab66; Grounding was missed. Same pattern applied here. Both fixes mechanical; no scope or authority change beyond removing the ambiguity openai-pro flagged. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * fix(briefs): resolve codex BLOCKING on #835 sha bfaab66 — stale §6a + B4.1 status Two codex BLOCKING findings, both about briefs copying status from earlier state without verifying against live receipts: 1. r2-release-manager.md §6a — DECISION already locked. docs/design-substrate-carrier-port-program.md §6a:171 says "pick **Option 3, unified MethodContract carrier**." :173 names the live receipt (src/v3/std/algebra.dag declares MethodContract; src/v3/lenses/cost.dag imports it via method_contract_cost_shape). :175 names the dissolution trigger (size_effect / cost_shape / callback_element_position field-by-field retirement). Brief was framing this as "DECISION BRIEF NOT YET AUTHORED — write up the 4 options ... recommend one based on E-I evidence." Stale. Fix: rename "pick decision brief" → "follow-through brief"; status from "NOT YET AUTHORED" to "DECISION LOCKED — Option 3 ... live receipt landed"; describe remaining work as bulk migration + dissolution-trigger tracking. Updated the deliverable table row, the Core deliverables list, the Autonomous dispatch authority line, the Sub-briefs Pending list, and the Cross-refs §6a source. 2. r2-substrate-manager.md B4.1 — BLOCKING already resolved. PR #819 ("docs(briefs): add B4.1a DeclarationRef runner migration brief") merged 2026-04-26 01:13:32. The §0.2 scope gap was resolved in 6f564f5 BEFORE merge per Director receipt on inbox #828. B4.1a follow-on brief landed in the same PR. Real open residual is the first-consumer migration at PR #826 (regen drift on r1_gates.dag — worker CI-fix, not brief authoring). Brief was still saying "DRAFTED (with §0.2 BLOCKING outstanding — codex finding on PR #819)" and "with outstanding BLOCKING ... resolution pending." Stale on both the BLOCKING and the residual shape. Fix: status to "BRIEF LANDED (PR #819, merged 2026-04-26 — §0.2 scope gap resolved in 6f564f5 before merge); B4.1a runner-migration follow-on brief landed same PR. Real residual: first-consumer migration #826 OPEN with regen drift (worker CI-fix)." Updated the deliverable table row, the Sub-briefs Authored list, and the Cross-refs adjacent line. Both findings: feedback_verify_thesis_claims violation on the PM authoring side. Two surgical text updates per finding; no scope or authority change. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * fix(briefs): anchor §6a follow-through against existing pick worker brief Codex inline BLOCKING on r2-release-manager.md:30 surfaced that docs/briefs/t-permethodmetadata-pick-worker.md (landed PR #794) already exists as the pick-worker brief. My prior fix (74b679b) reframed "pick decision brief" → "follow-through brief" but didn't reference the existing worker, leaving readers to wonder if the follow-through was re-picking. Two precision tightenings: - "Pick is closed." Names the worker brief explicitly + cites its scope-closure clause ("Do not migrate all consumer lenses ... bulk migration is post-pick work"). - "No duplicate decision authority — pick is closed; follow-through is post-pick scope." Closes the P2 single-authority concern codex named. Surface change only; no scope expansion. The follow-through scope (bulk migration + dissolution-trigger tracking) is unchanged from the 74b679b state — what's added is the explicit worker-brief anchor. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * fix(briefs): resolve openai-pro APPROVE_WITH_COMMENTS on #835 sha 3260d71 Finding (P2 single-authority): T-Ground-Rust had two contradictory states — deliverables table at :23 said DISPATCHED, but Sub-briefs Pending list at :62-63 listed "T-Ground-Rust full implementation" as pending pre-spawn work. Same lane, two authoritative states. Audit: T-Ground-Rust full lane (Rust target-spec primitive declarations end-to-end) has not been authored. Pilot (PR #765) and Engine Phase 1 typestructure (PR #788) are separate dispatched lanes (their own rows in the table); the "DISPATCHED (Engine implementation parked pending loader-close)" parenthetical was a status leak from the Engine row's parking note. Fix: row status now reads "NOT YET AUTHORED — listed under Sub-briefs Pending below; gated on pre-spawn Director scope refinement per inbox #828. (Pilot PR #765 + Engine Phase 1 typestructure PR #788 are separate dispatched lanes — see those rows; the prior 'DISPATCHED' status here was a parenthetical leak from the Engine row's loader-close parking note.)" Now table status matches Sub-briefs Pending list. Single authority restored. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * fix(briefs): refresh impossible-bugs manager against PR #836 merge Codex BLOCKING on r2-impossible-bugs-manager.md:78 (sha bfaab66) was correct in spirit and now newly actionable: the brief's Pending section re-dispatched the older DESIGN/SCOPING workers (t-impossiblebugs-nested-optional-flatten-worker.md + t-impossiblebugs-unhandled-diagnostic-paths-worker.md) even though their design docs (PR #798 + PR #801) had landed with next-step recommendations + PR #836 just authored the IMPLEMENTATION workers (r2-impossible-bugs-{nested-optional-flatten,unhandled-diagnostic-paths, unenumerated-effects}-worker.md). Re-dispatching DESIGN/SCOPING workers when implementation workers are authored = duplicate decision authority under P2 + accumulating ad-hoc state under P5. Codex was right. Three sections updated to reflect PR #836-merged state: ## Program scope table (lines 17-19) Reframed columns: "Design authority + implementation worker (post PR #836 merge)" / "Implementation status" / "Substrate gating". Each class row now names: - Design doc PR + closed-in-scope status - Implementation worker filename (PR #836) + IMPLEMENTATION WORKER LANDED - UNGATED status per design-doc audit (Director's reframes #1, #2 confirmed no substrate gates — substrate-constructor invariant for nested-optional; totality-by-omission for unhandled-diagnostic; closed-system for effects) The OLD DESIGN/SCOPING workers are explicitly named SUPERSEDED for unenumerated-effects already; nested-optional + unhandled-diagnostic older workers are now also marked superseded by their PR #836 implementation counterparts. ## Owned deliverables (lines 25-31) Reframed from "Worker brief is already authored ... DESIGN/SCOPING shape" to "Implementation worker brief landed on main via PR #836 merge ... do not re-dispatch the older workers." Substrate-gap escalation reframed as the exception path (was the expected path under the older DESIGN/SCOPING worker assumption); expected path is direct implementation per design-doc Director-actionable recommendation. ## Sub-briefs Pending (lines 78-86) Reframed from "Dispatch nested-optional-flatten worker (DESIGN/SCOPING produces substrate proposal → escalate)" to "Dispatch nested-optional-flatten implementation worker (ungated; dispatchable Day-1 post-spawn)" + same pattern for the other two classes. PR #836's 3 implementation workers are now the canonical dispatch targets. Added explicit SUPERSEDED list for the older workers (4 entries: 2 DESIGN/SCOPING + 2 effects-worker variants) with their respective implementation-worker successors named. ## Discipline note This finding was real, not an echo. PR #836 merging changed the substrate of facts the manager brief grounds against. Same class as the §6a stale framing on Release Manager + the B4.1 stale BLOCKING on Substrate Manager: brief authored against pre-merge state; merge surfaces the staleness. The matrix's pre-author verification invariant catches state-drift at authoring time; the matrix's status-consistency rule catches dual-state within a single brief. This finding is a third class: cross-PR state drift (brief A's Pending list cites brief B's content; brief B merges and brief A's content goes stale). Worth noting as a refresh-discipline trigger separately from authoring discipline. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
* docs: PM bundle — R1 Closure Manager + escalation-paths union map
Two PM-portion deliverables, bundled per the user-preferred bundling cadence
for multiple workstreams.
## R1 Closure Manager (new) — docs/briefs/r1-closure-manager.md
Strict-interpretation gate-close authority. Per-HEAD gate audit against
ROADMAP.md §"Lane acceptance — .dag gates" surfaced 12+ unwired gates
under strict reading ("the release gate IS a .dag program" per THESIS):
- T-P0 (3): repeat_string_correct / no_fabrication_sentinel /
rest_ops_aligned — features work, no .dag TestClaim wrappers
- T-Sub (1): sub_type_alias_where_lowers — PR #703 landed feature,
no fixture wrapper
- T-TestGen (1 compiles-only): testgen_mock_backed_integration_safe —
runner returns NotYetImplemented; M1(2.8) data body blocker
- T-PB census (6): hand_rust_at_shim_floor / lens_producer_files_remaining
/ self_compile_fixed_point / compiler_std_ratchet_zero (T-PB-A) +
test_file_generated_from_dag / rust_tests_outside_residual_zero
(T-PB-B) — enforced as Rust ratchets, not .dag TestClaims
- T-Emit (3): rust_fixtures_rustc_green / generic_bounds_survive /
omni_demo_fixtures_green — host-harness only, no .dag wrappers
- T-Demo (1): demo_user_authored_lens_rejects_violating_program —
no fixture
Six mutually-exclusive lanes (R1C-A through R1C-F) at the
fixture-file / runner-dispatch-arm level. R1C-A (T-TestGen schema
extensions) unblocks R1C-D (T-PB census-as-.dag); other 4 lanes
parallel-dispatchable Day-1.
Lane variants per user direction: T-PB-A and T-PB-B merged into R1C-D
(single predicate-shape work); T-Emit kept (no host-harness pragmatic
acceptance).
Manager dissolves on R1 all-gates-green declaration; R2 managers spawn
post-dissolution per docs/r2-structure.md transition mechanics. No
overlap with R2 managers (R2 spawn gated on this manager's close).
## Escalation paths union map (new) — docs/escalation-paths.md
Sweep against main HEAD 407a8bc cataloged 45 "if X happens, escalate"
clauses across INVARIANTS / ROADMAP / THESIS / r2-structure.md / all
docs/briefs / docs/design-*.md / docs/thesis.
- 73% GROUNDED (32 clauses): trigger condition is concrete +
measurable (specific gate names, file:line citations, mechanical
search verifiable)
- 27% SOFT (13 clauses): trigger requires human judgment to fire
No significant authority conflicts. Three minor naming-tightening
opportunities surfaced as Fix 1 / Fix 2 / Fix 3 (applied below). One
near-orphan (DB-revision target unattested on main) — resolved by R2
promotion housekeeping; not load-bearing now.
Sweep boundary: main only. PR #835 (PM portion) and PR #836 (Director
portion) are NOT in this map's current sweep — second-pass sweep
planned on those PRs' merge to main.
## Three surgical fixes to source authority docs
Each fix is a 1-2 line edit closing an open-resolution-path gap the
sweep surfaced:
### Fix 1 — Signal channel naming (docs/r2-structure.md)
New paragraph in §"Manager structure" preamble naming the escalation
signal channel: GitHub session-inbox issue comment for human-target
escalations; cross-manager queue (per R1 "Cross-manager notifications
queued" pattern) for inter-manager signals. Worker-brief STOP-AND-
ESCALATE clauses no longer need to restate the channel.
### Fix 2 — Director decision-artifact format (docs/r2-structure.md)
Extended the "Scope-change escalation" bullet in §"Director" to name
where Director's adjudication decision lands: (a) amendment PR to the
originating brief OR (b) sibling brief if scope creates new program.
Closes the escalation cycle explicitly — originating brief stays open
until artifact lands.
### Fix 3 — C1 lane explicit owner (docs/design-substrate-carrier-port-program.md)
Two STOP-AND-ESCALATE clauses (Lane E-T :120 and Lane E-P :148)
rewritten from "→ C1 lane" to "→ escalate to Director (Director opens
a C1 substrate-capability lane if escalation requires substrate work)."
Director becomes the explicit receiver; C1 lane becomes the optional
dispatch outcome.
## Out of scope for this PR
- §6a follow-through brief authoring (next PM deliverable per inbox #828
PM portion; tracked in r2-release-manager.md per PR #835)
- B5 / B6 / B7 brief authoring (next PM deliverables per inbox #828 PM
portion)
- Thesis-claim coverage mapping table (lands at R1 close → R2 promotion
transition per r2-structure.md)
- Authority matrix structural normalization (per openai-pro PAUSE_AND_REGROUP
meta-review on PR #835; deferred — escalation-paths.md provides initial
evidence base for any future matrix authoring)
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
* docs: add R1 Closure Manager ROADMAP registration + §6a follow-through worker brief
Two additions to the PM bundle.
## ROADMAP §"R1 Closure Manager" section (new)
Small registration section between §"Lane acceptance — .dag gates" and
§"Scheduled cleanups". Names the manager + lane structure (R1C-A through
R1C-F) + critical-path edge (R1C-A → R1C-D); points at the brief at
docs/briefs/r1-closure-manager.md as authority for the per-lane scope.
Parallel registration shape to docs/r2-structure.md's §"Manager structure"
treatment for R2 managers — short authoritative pointer in ROADMAP, full
manager scope in the brief. Manager dissolves on R1 all-gates-green; R2
spawn gated on this dissolution.
## §6a follow-through worker brief (new)
Per inbox #828 PM-portion split, this is the next PM deliverable in the
queue. Anchored against the existing pick-worker brief at
docs/briefs/t-permethodmetadata-pick-worker.md (landed PR #794) so there's
no duplicate decision authority — pick is closed; this brief is post-pick
scope only.
Three consumer-side requirements:
1. Inventory current consumption sites in cost.dag / complexity.dag for
the three carrier fields (size_effect / cost_shape / callback_element_position).
2. Bulk-migrate to MethodContract-keyed lookup; retire lens-local reads
of *_templates() result fields.
3. Track field-by-field dissolution triggers as named ROADMAP debt rows
per §6a:175 (each field has a named upstream-fact landing condition
that retires the carrier; when all three trigger conditions fire,
MethodContract retires).
Slice: inventory → migrate → track. 1-3 PRs at worker discretion.
STOP-AND-ESCALATE clauses cite the new escalation channel discipline from
docs/escalation-paths.md (channel: GitHub session-inbox; Director decision
artifact = amendment PR or sibling brief). Behavioral-regression on R1
gates is non-negotiable STOP; DB-8 drift is STOP; carrier-shape gap
discovery is STOP (the pick may need amending).
## What this PR now contains (cumulative)
- docs/briefs/r1-closure-manager.md (new) — R1 Closure Manager brief
- docs/escalation-paths.md (new) — 45-clause union map
- docs/briefs/r2-release-6a-follow-through-worker.md (new) — post-pick worker brief
- ROADMAP.md edit — R1 Closure Manager registration section
- docs/r2-structure.md edits — signal channel + Director decision-artifact format (Fixes 1+2)
- docs/design-substrate-carrier-port-program.md edits — C1 lane explicit owner (Fix 3)
## Out of scope
Still-pending PM deliverables per inbox #828: B5 Loop construction-closure
audit brief; B6 file-preference rank checklist completion; B7 priority-hint
relay (cross-manager signal); thesis-claim coverage mapping table (lands
at R1 close → R2 promotion).
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
* fix(escalation-paths): resolve P2 single-authority wording ambiguity
Codex on #847 sha 265d97f flagged that line 3's "Authoritative single
source for ... escalation clauses" contradicts line 18's "descriptive,
not prescriptive ... source briefs remain authoritative" — direct P2
single-authority ambiguity per INVARIANTS.md.
Fix: line 3 now reads "Authoritative union receipt + conflict map ...
The source briefs remain authoritative on their own escalation clauses
(per §How to use below); this doc owns the union view + cross-brief
consistency surfacing."
Surface change only; the doc's actual authority scope is unchanged
from the §"How to use" semantics — clauses live in source briefs;
this doc surfaces the union + conflicts. The status line now matches
the body.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
* docs: B5 / B6 / B7 — R2 Release Manager B-wave Tier 2 (PM portion)
Per inbox #828 PM portion, three deliverables completing the B-wave
Tier 2 PM authoring queue per docs/briefs/debt-paydown-synthesis-
2026-04-25.md §5 (lines 526-528). All three target R2 Release Manager
ownership (post-spawn).
## B5 — Loop construction-closure audit (worker brief)
S, R2-coupled. Audit-FIRST per parent scope statement (lines 300-314).
Step 1: enumerate every Behavior::Loop construction site in lower.rs
+ anywhere; trace caller path. Step 2 (conditional on audit):
- Closure-holds (preferred per feedback_construction_over_ratchets):
deliverable is structural integration test asserting closure;
speculative LoopKind marker retired.
- Closure-fails: marker spec authored as separate brief; escalates
to substrate-amendment per synthesis-doc STOP discipline.
STOP-AND-ESCALATE clauses cover: (a) ambiguous construction-site
origin; (b) marker spec requiring new substrate connective (C1-class
escalation per feedback_compiler_is_dag_processor); (c) self-fulfilling
closure if audit's own scaffold triggers.
## B6 — file-preference rank checklist completion (worker brief)
XS-trivial. Audit-first per feedback_audit_adjacent_authority_first.
Two paths: (a) add the three missing modules (computation/induction/
termination) to dag.rs:2735-2764 checklist; (b) document exemption
in source if the modules are intentionally exempt.
Single-PR deliverable; either +3 line addition or +1 line comment cite.
STOP if rank-function semantics are genuinely ambiguous, or if "fix"
turns out to require substrate work (don't ratchet on a scaffold
already named for dissolution).
## B7 — priority-hint relay to Pure Bootstrap Manager (signal doc, NOT worker brief)
Cross-manager signal content snapshot. NOT a worker brief — documents
the signal R2 Release Manager queues to R2 Pure Bootstrap Manager
once both spawn at R1 close.
Payload: lift patch_lower_helpers_generated_type_alias_refinement
retirement to PB-Tier1-Sweep priority within R2 Pure Bootstrap
Manager's owned-deliverable queue.
Pre-spawn: this file documents content. Post-spawn: R2 Release
Manager queues the signal as one of its first dispatch actions; R2
PB Manager acks + adjusts priority. Closure trigger: signal delivered
+ consumed (or dissolution already fired pre-R1); file marks RESOLVED
in follow-up cleanup.
Distinguished from B5 / B6 worker briefs by the explicit "NOT a worker
brief" framing in the synthesis doc; preserves single-authority discipline
(deliverables vs signals do not blur).
## Cumulative PR contents (PR #847)
- docs/briefs/r1-closure-manager.md
- docs/briefs/r2-release-6a-follow-through-worker.md
- docs/briefs/r2-release-b5-loop-construction-closure-audit-worker.md (this commit)
- docs/briefs/r2-release-b6-file-preference-rank-checklist-worker.md (this commit)
- docs/briefs/r2-release-b7-priority-hint-relay-to-pure-bootstrap.md (this commit)
- docs/escalation-paths.md
- ROADMAP.md (R1 Closure Manager registration section)
- docs/r2-structure.md (Fixes 1+2 + earlier signal-channel section)
- docs/design-substrate-carrier-port-program.md (Fix 3 — C1 lane explicit owner)
## What's left in PM inbox-#828 queue
- Thesis-claim coverage mapping table — gated on R1 close → R2 promotion
per docs/r2-structure.md Open call 1; not in this PR.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
* docs: R1 Closure Manager — 4 trivial-to-small lane worker briefs (R1C-B / -C / -E / -F)
Per user direction "lets do the trivial ones" — authoring the four
R1 Closure Manager lanes that don't depend on R1C-A (T-TestGen schema
extensions). All four are parallel-dispatchable Day-1 once R1 Closure
Manager spawns; sized S or smaller per the manager brief.
## R1C-B — T-P0 fixtures (S; 3 gates)
- p0_repeat_string_correct (Day-1, DB-15 schema): authored immediately
- p0_no_fabrication_sentinel (ext): audit predicate shape; possibly blocks on R1C-A
- p0_rest_ops_aligned (ext): audit predicate shape; possibly blocks on R1C-A
Branch on audit per gate; bundle PRs if all DB-15-suffices, split if any
blocks on R1C-A schema landing.
## R1C-C — T-Sub sub_type_alias_where_lowers fixture (XS; 1 gate)
PR #703 already landed the feature with test_db11_type_alias_where_*
integration receipts. Brief authors the .dag wrapper; predicate likely
Compiles on a fixture program exercising type-alias where lowering.
Single PR; dispatchable Day-1.
## R1C-E — T-Emit .dag TestClaim wrappers (S; 3 gates)
PB-Runtime ExecuteCommand (PR #792) is the runner enabler. Three gates:
- emit_rust_fixtures_rustc_green: ExecuteCommand running rustc on emitted output
- emit_generic_bounds_survive: audit-decided shape (ExecuteCommand+grep or structural)
- emit_omni_demo_fixtures_green: multi-target; ForAllTargets quantifier may need
R1C-A schema, OR can be expressed as 3 ExecuteCommand claims (1 per target)
STOP if ForAllTargets needed and not in scope; STOP if PR #792 ExecuteCommand
runner doesn't cover the bounded-execution shape.
## R1C-F — T-Demo demo_user_authored_lens_rejects_violating_program (S; 1 gate)
Built on T-LensAPI user_authored_lens_compiles (GREEN). Three components:
- ~20-line user-authored lens in .dag (e.g., "max external HTTP calls per workflow"
per THESIS canonical example)
- Violating program (~10-20 lines)
- TestClaim with FailsWithDiagnostic predicate (asserts lens rejects violator)
Demo artifact also authored per docs/r2-structure.md §"Demo discipline".
## Discipline anchors applied
- feedback_construction_over_ratchets — fixtures ground in observable
behavior (compiles / output / exit-code), not parallel asserts
- feedback_audit_adjacent_authority_first — every brief mandates audit
step before authoring (pick predicate / pick lens example / pick path)
- All four briefs cite docs/escalation-paths.md as escalation discipline
authority
## Out of scope
- R1C-A T-TestGen schema extensions worker brief (M; meatier; authored separately)
- R1C-D T-PB census-as-.dag worker brief (M-L; meatier; gated on R1C-A; authored separately)
- Implementation of any of these briefs (worker dispatch happens at R1
Closure Manager spawn)
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
* docs: thesis-claim coverage map (R2 promotion Open call 1 deliverable)
Per docs/r2-structure.md §"Open calls" item 1 — required pre-promotion
audit table mapping every THESIS claim to R1-closed / R2-gated /
post-R2-external disposition with gate name + evidence + status.
## Sweep result
74 claims cataloged across THESIS.md §"Thesis claims — complete list"
(Tier 1 / Tier 2 / Tier 3 + categorical claims under Concept unifications,
Epistemic stacking, Substrate shape, Free consequences, Omni-emission,
Meta-process modeling, Self-hosting, Audience duality, Adoption model,
Tests-as-data, Enumerable impossible-bug classes, Modeling discipline).
## Coverage statistics
- R1-closed: 52
- R2-gated: 18
- post-R2-external: 4
- GAP (no disposition): 0
**Pre-promotion blocker count: 0.** Open call 1's gate is satisfied —
every thesis claim has a named disposition + documented evidence.
## Coverage anomalies (partial-status, NOT blockers)
Four claims have partial-status notes:
1. Ownership (Tier 1) — full infrastructure may have post-R1 tail
2. Shape A omni-emission — R1 demonstrates 3 of 6+ targets (TS/Swift/HDL post-R1)
3. Self-hosting fixed-point + tests-as-data — [ext] gates pending T-TestGen
runner closure; structural commitment R1
4. Grounding completeness — Tier 1 but R2-gated (intentional, single co-anchor
claim per docs/r2-structure.md)
## Doc shape (mirrors escalation-paths.md authority pattern)
- Status: PROPOSAL pre-R1-close; promotes to ACTIVE on R1 close → R2 promotion
- Authority: descriptive (union receipt + GAP-surfacing); THESIS + ROADMAP
+ r2-structure.md remain authoritative on claim text + dispositions
- Refresh discipline: every release transition; rebuild on new claims
## What this PR (#847) now contains
Cumulative deliverables:
- docs/briefs/r1-closure-manager.md (R1 Closure Manager brief, 6 lanes)
- docs/briefs/r1c-b/c/e/f-*.md (4 trivial R1C lane worker briefs)
- docs/briefs/r2-release-6a-follow-through-worker.md
- docs/briefs/r2-release-b5-loop-construction-closure-audit-worker.md
- docs/briefs/r2-release-b6-file-preference-rank-checklist-worker.md
- docs/briefs/r2-release-b7-priority-hint-relay-to-pure-bootstrap.md
- docs/escalation-paths.md (45-clause union map)
- docs/thesis-claim-coverage.md (74-claim coverage map; this commit)
- ROADMAP.md edit — R1 Closure Manager registration section
- docs/r2-structure.md edits — Fix 1+2 (signal channel + Director decision artifact)
- docs/design-substrate-carrier-port-program.md edits — Fix 3 (C1 lane explicit owner)
## Out of scope
- R1C-A (M) and R1C-D (M-L) worker briefs — meatier; defer to next PM iteration
- Implementation of any worker brief (R1 Closure Manager dispatches at spawn)
- Authority matrix structural normalization per openai-pro PAUSE_AND_REGROUP
meta-review — escalation-paths.md + thesis-claim-coverage.md provide
evidence base; matrix authoring optional next iteration
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
* docs: R2 manager-brief authority matrix (resolves PAUSE_AND_REGROUP meta-review)
Per openai-pro PAUSE_AND_REGROUP meta-review on PR #835 sha bfaab66, the
recurring "authority ambiguity at stage boundaries" pattern (B7 dual-contract,
Grounding pending unbounded, §6a stale framing, B4.1 stale BLOCKING) was being
fixed instance-by-instance via wording sweeps. The structural fix is a shared
authority matrix that makes the categories disjoint at brief-authoring time.
This commit graduates the recurring class out of per-instance review.
## docs/briefs/r2-manager-brief-authority-matrix.md (new)
5 disjoint artifact categories with explicit invariants:
1. Worker brief — dispatchable authoring task; produces concrete deliverable
2. Decision brief — scoped design call (pick + lock); follow-through is
distinct Category 1 worker brief (resolves §6a anti-pattern)
3. Cross-manager signal — routes priority/scope info; NOT a worker brief
(resolves B7 anti-pattern)
4. Standing reporting duty — continuous-state ledger / monitor; activates
on spawn, dissolves on manager dissolution
5. Pre-spawn placeholder — skeleton authored before spawn; graduates into
1-4 OR dissolves at spawn
Per-manager deliverable inventory tags every owned deliverable from all 6 R2
managers (Grounding / Substrate / Modeling / Impossible-Bugs / Pure Bootstrap /
Release) with category. Inventory references PR #835 (manager briefs), PR #836
(14 Director worker briefs), and PR #847 (this PR's worker briefs + signal doc).
Local review checklist (per meta-review recommendation #3): Owned deliverables
+ Pre-spawn vs post-spawn authority + Autonomous dispatch authority + Sub-briefs
sections must agree on owner + artifact type per matrix categorization. Doesn't
need new top-level INVARIANTS rule; P2 + P5 already cover; this is the local
invariant for the manager-brief family.
## Sweep verification — current state of 6 R2 manager briefs (PR #835 sha 3260d71)
All 6 manager briefs verified consistent with matrix:
- Grounding: ✅ no category conflicts (Pending bounds fixed in f916fba)
- Substrate: ✅ no category conflicts (B4.1 staleness fixed in 74b679b)
- Modeling: ✅ no category conflicts
- Impossible-Bugs: ✅ no category conflicts (filenames fixed 70df547)
- Pure Bootstrap: ✅ no category conflicts
- Release: ✅ no category conflicts (B7 dual-contract fixed f916fba; §6a
stale framing fixed 74b679b + 3260d71)
No additional fix-pushes needed on PR #835 from this matrix introduction.
## docs/r2-structure.md (edit)
Added "Manager-brief authority matrix" paragraph in §"Manager structure"
preamble, citing the matrix doc as authority. Manager briefs now cite the
matrix and stop self-categorizing.
## What this PR (#847) now contains
Cumulative deliverables:
- docs/briefs/r1-closure-manager.md (R1 Closure Manager brief, 6 lanes)
- docs/briefs/r1c-b/c/e/f-*.md (4 trivial R1C lane worker briefs)
- docs/briefs/r2-release-6a-follow-through-worker.md
- docs/briefs/r2-release-b5-loop-construction-closure-audit-worker.md
- docs/briefs/r2-release-b6-file-preference-rank-checklist-worker.md
- docs/briefs/r2-release-b7-priority-hint-relay-to-pure-bootstrap.md
- docs/briefs/r2-manager-brief-authority-matrix.md (this commit)
- docs/escalation-paths.md (45-clause union map)
- docs/thesis-claim-coverage.md (74-claim coverage map; 0 GAPs)
- ROADMAP.md edit — R1 Closure Manager registration section
- docs/r2-structure.md edits — signal channel + Director decision artifact
+ authority matrix reference (this commit)
- docs/design-substrate-carrier-port-program.md edits — Fix 3 (C1 lane
explicit owner)
## What's outstanding (out of scope for this PR)
- R1C-A and R1C-D worker briefs (M and M-L; meatier; deferred per user's
"trivial ones" direction)
- Sweep of PR #836's 14 worker briefs against the matrix at PR #836 merge
(current sweep is main-only)
- Authority matrix becomes ACTIVE on R1 closure → R2 promotion transition
per the matrix's status; PROPOSAL until then
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
* docs(matrix): add status-consistency + pre-author verification invariants
Two additions to the local review checklist on the R2 manager-brief
authority matrix, both surfaced by review activity since the matrix's
initial landing:
## Status-consistency rule
openai-pro APPROVE_WITH_COMMENTS on PR #835 sha 3260d71 found T-Ground-Rust
in two contradictory states: deliverables table said DISPATCHED, but
Sub-briefs Pending list said "T-Ground-Rust full implementation" pending.
Same lane, two authoritative states — the matrix's existing checklist
covered owner + artifact type but not status, leaving room for this class.
Added rule: a single deliverable cannot be both DISPATCHED/AUTHORED in the
deliverables table AND Pending/NOT YET AUTHORED in the Sub-briefs section.
Partial-state lanes must scope the partial explicitly in the table (e.g.,
"PARTIAL — Pilot PR #X done; full implementation pending"). Sub-briefs
section is single authority for authored-vs-pending; deliverables table
cites that authority without duplicating ambiguously.
Fixed in 3ef1509 on PR #835 (T-Ground-Rust row scoped to NOT YET AUTHORED).
## Pre-author verification invariant
Director's PR #836 hit feedback_verify_thesis_claims 7 times in one PR
authoring cycle (consistently: brief authored without grepping
source-of-truth before slicing). The pattern is a separate failure class
from categorization — not what the matrix's prior checklist addressed.
Added invariant: before authoring a brief that references substrate state,
gate condition, existing brief, or design-doc disposition, grep
src/v3/std/ + src/v3/spec/ + src/v3/compiler/src/ for state cited; grep
docs/briefs/ for existing canonical briefs; read the design doc's
§Director-actionable / §Q-recommendation / §Decision in full. Cite
specific file:line / brief filename / §ref in Read first. State audit
receipt before slicing.
This operationalizes feedback_verify_thesis_claims for the brief-authoring
family. Doesn't need a new INVARIANTS rule; cited existing P2 + P5 +
feedback_verify_thesis_claims as authority. Local invariant collected
here as a single review checkpoint.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
* docs: R1 Closure Manager — full lane brief queue (R1C-A + R1C-D meatier briefs)
Per user direction "lets keep going here until we have full dispatch/briefing
for both with thorough review please" — authored the two non-trivial R1
Closure Manager lane worker briefs deferred earlier per "do the trivial ones"
direction. R1 Closure Manager lane queue now fully authored.
## R1C-A — T-TestGen schema extensions (M-L; was M before audit)
Pre-author audit at main HEAD 407a8bc (per matrix verification invariant)
revealed three coupled sub-deliverables, sized M-L total:
- **Sub-deliverable A — M1(2.8) list-body lowering for `data` declarations.**
Compiler work in lower.rs:2446 (currently rejects `data: List<T> = [...]`
as ValueBody::Unparsed). Predecessor for MockBackedInvariant fixture
authoring + 6 PB-census predicate authoring. Substrate dependency: T-Substrate
ValueBody-list/sum (PR #790; R2 sub-lane) — verify substrate state at brief-
dispatch time per feedback_thesis_gate_state_drift.
- **Sub-deliverable B — Predicate-shape scoping for 6 PB-census gates.**
No `.dag` predicate shape exists for any of the 6 census gates today; ROADMAP
line 65 names T-TestGen as scoping authority. R1C-A authors them from scratch.
Proposed shapes: CensusBoundCheck / CensusSubsetCount / FixedPointConverges /
RatchetZero / GeneratedFromDag (per gate). Audit-first: grep dsl/std/
test_infrastructure.dag for existing predicate-variant pattern; mirror
schema discipline.
- **Sub-deliverable C — MockBackedInvariant minimal-demo fixture.**
Closes testgen_mock_backed_integration_safe gate. Depends on Sub-deliverable
A (fixture body uses list literal). 5-10 lines `.dag`.
Slice: A → B → C, sequential. STOP-AND-ESCALATE if substrate variant absent,
predicate shapes need substrate work, or DB-8 drifts.
## R1C-D — T-PB census-as-`.dag` (M-L)
Pre-author audit established census authority at sg0_census_test.rs:166-297
(EXPECTED_HAND_AUTHORED_NON_TEST 41 entries; EXPECTED_HAND_AUTHORED_TEST 77
entries; EXPECTED_HAND_AUTHORED_FRAGMENTS 1 entry). Drift test sg0_v3_hand
_authored_census at :387-451 panics with narrative on mismatch.
6 fixtures, one per census gate, each consuming an R1C-A Sub-deliverable B
predicate shape:
- D.1 pb_hand_rust_at_shim_floor (CensusBoundCheck on NON_TEST list)
- D.2 lens_producer_files_remaining (CensusSubsetCount on lens-producer pattern)
- D.3 pb_self_compile_fixed_point (FixedPointConverges on bootstrap snapshot)
- D.4 pb_compiler_std_ratchet_zero (RatchetZero on consolidation ratchet)
- D.5 pb_test_file_generated_from_dag (GeneratedFromDag on test partition)
- D.6 pb_rust_tests_outside_residual_zero (CensusBoundCheck on TEST list)
Dispatch gated on R1C-A Sub-deliverable B landing. STOP-AND-ESCALATE if
predicate shapes don't capture gate semantics (back-pressure to R1C-A);
or if cascade-promotion 0-floor work hasn't reduced census to 0 by R1 close
declaration time (gates D.1/D.2/D.6 stay RED; Director arbitration).
## R1 Closure Manager status sync
Updated r1-closure-manager.md deliverables table + Sub-briefs section to
reflect all 6 lane worker briefs as AUTHORED (per matrix's status-consistency
rule — table cannot say NOT YET AUTHORED while worker briefs are landed).
R1C-A row sized up from M to M-L per audit revealing Sub-deliverable A is
compiler work.
## Matrix invariants applied
Both new briefs follow the matrix's local checklist:
- Categorization: Category 1 (worker brief) — explicit in Cross-refs
- Owner / artifact type / status — consistent across deliverables, slice,
acceptance, STOP-AND-ESCALATE sections
- Pre-author verification — explicit audit receipt section at top of each
brief with file:line citations to runner / lowering / schema / census
- Discipline anchors named (feedback_construction_over_ratchets,
feedback_audit_adjacent_authority_first, feedback_thesis_gate_state_drift,
feedback_verify_thesis_claims, feedback_compiler_is_dag_processor,
feedback_foundation_over_speed)
## What this PR (#847) now contains (final state expected)
- R1 Closure Manager brief + ROADMAP registration + 6 lane worker briefs
(R1C-A through R1C-F) — full R1 closure dispatch surface
- §6a follow-through worker brief
- B5 / B6 / B7 (worker briefs + signal doc)
- Escalation-paths union map (45 clauses)
- Thesis-claim coverage map (74 claims, 0 GAPs)
- Authority matrix (5 categories + per-manager inventory + status-consistency
+ pre-author verification invariants)
- ROADMAP + r2-structure.md + design-substrate-carrier-port-program.md edits
R2 spin-up brief queue: complete. R1 closure brief queue: complete. PM inbox
#828 fully delivered.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
* fix(briefs): correct R1C-A citations from self-review pass
Self-review pass against the matrix's pre-author verification invariant
caught two factual citation misses in r1c-a-t-testgen-schema-extensions-worker.md:
## BLOCKING — wrong file path for TestClaim schema (4 occurrences)
Brief cited `dsl/std/test_infrastructure.dag` and `src/v3/std/test_infrastructure.dag`
in 4 places (audit receipt at :17 + Sub-deliverable B framing at :61, :66 +
Slice PR-B at :87 + Cross-refs Schema authority at :119). That file does NOT
exist on main HEAD 407a8bc.
The actual TestClaim schema authority lives at:
- DSL-side: `dsl/std/verification.dag` (TestClaim at :36; full schema)
- v3-mirror: `src/v3/std/verification.dag` (TestClaim.requires at :187)
All 4 occurrences corrected to point at the real file. Schema authority
line in Cross-refs now also explicitly cites `dsl/std/verification.dag:36`
(DSL-side type declaration) for completeness.
## MINOR — predicate dispatch line range was off
Brief cited "Predicate dispatch inventory at test_runner.rs:1423-1431 has
all 10 predicates wired" — but lines 1423-1431 only contain 9 predicates
(Compiles through ExecuteCommand); MockBackedInvariant arm starts at
line 1432 and runs through 1448.
Corrected to: "in the match block at test_runner.rs:1424-1448 has all 10
predicates wired (Compiles / FailsWithDiagnostic / OutputEquals / PortHasState
/ CostBounded / LensOutputEquals / DifferentialEquals / AlgebraicLaw /
ExecuteCommand wired across :1424-1431; MockBackedInvariant arm at :1432-1448)."
## MINOR — ResourceReference line range corrected
Brief cited `src/v3/std/resources.dag:25-27` — actual range is :25-26 (the
type spans 2 lines, not 3). Corrected.
## Discipline note
Both misses were exactly the failure mode `feedback_verify_thesis_claims`
names: state cited from memory rather than grepped at brief-authoring time.
The pre-author audit was largely accurate (runner :1432-1448 quote was
exact; lower.rs:2446 diagnostic was exact; census line ranges all correct),
but two slips made it through. The matrix's pre-author verification invariant
worked at the self-review pass level — caught before automated reviewers.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
---------
Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
1 participant
Opened from session-dashboard for session
merry-ant-120.