Skip to content

test umbrella dissolution: corpus sweep B (src/v2 + orphan wire) - #7274

Merged
briansrls merged 8 commits into
session/proud-wren-892-sweep-afrom
session/proud-wren-892-sweep-b
Jul 26, 2026
Merged

test umbrella dissolution: corpus sweep B (src/v2 + orphan wire)#7274
briansrls merged 8 commits into
session/proud-wren-892-sweep-afrom
session/proud-wren-892-sweep-b

Conversation

@gunbai-bot

@gunbai-bot gunbai-bot Bot commented Jul 26, 2026

Copy link
Copy Markdown
Contributor

Summary

Second half of the umbrella corpus sweep. Bases on sweep A (#7273). Dissolves aggregators under src/v2/** and wires check_orphan_helpers_or_err into discover_floor_witness_roster (U2 live). Split so gh pr diff stays under GitHub's 300-file cap.

Stack

  1. test umbrella dissolution: mechanism (U1–U3) #7270 — mechanism
  2. test umbrella dissolution: corpus sweep A (dag/test) #7273 — dag/test sweep A
  3. this PR — src/v2 + orphan wire

Test plan

  • gh pr diff succeeds
  • orphan plant unit tests still green
  • floor discovery no longer refuses on dark helpers (orphan count 0)
  • CI floor green

Made with Cursor

@gunbai-bot
gunbai-bot Bot force-pushed the session/proud-wren-892-sweep-a branch from c7b6d59 to 8247804 Compare July 26, 2026 03:21
@gunbai-bot gunbai-bot Bot mentioned this pull request Jul 26, 2026
Merged
3 tasks
@gunbai-bot
gunbai-bot Bot force-pushed the session/proud-wren-892-sweep-b branch from 7766459 to b232c37 Compare July 26, 2026 03:25
@gunbai-bot

gunbai-bot Bot commented Jul 26, 2026

Copy link
Copy Markdown
Contributor Author

Rebased onto rebuilt session/proud-wren-892-sweep-a (8247804) — merge conflict cleared.

Also addressed review 43059 on this tip:

  • deleted orphan branch_if_then_else_emit_node_is_bare_atom
  • deleted unreachable pbf_tokenize→pbf_tree_contains_atom_identity chain in parse_binding_fidelity_test.dag
  • re-wired check_orphan_helpers_or_err onto the new base’s cli_run.rs

— sent from proud-wren-892

@gunbai-bot
gunbai-bot Bot force-pushed the session/proud-wren-892-sweep-b branch 2 times, most recently from 1551fc0 to 4aeac66 Compare July 26, 2026 03:36
@gunbai-bot gunbai-bot Bot mentioned this pull request Jul 26, 2026
Merged
2 of 4 tasks
@gunbai-bot
gunbai-bot Bot force-pushed the session/proud-wren-892-sweep-b branch 2 times, most recently from c6f91cd to a5235b5 Compare July 26, 2026 04:03
@gunbai-bot

gunbai-bot Bot commented Jul 26, 2026

Copy link
Copy Markdown
Contributor Author

Addressed review 43103 on tip:

  1. Stacked #[test] / disabled file_grain_enumerate — confirmed. Removed the WIP corpus_orphan_census_proud_wren insert (it had stolen the attribute) and restored #[test] on file_grain_enumerate_yields_two_test_fns.
  2. set_current_dir in a test — confirmed; deleted with the census. Also taught collect_orphan_helpers to accept absolute roots without requiring a process cwd change (relative roots still resolve against cwd for the floor path).
  3. Zero-test fn orphan skip — kept. Module-local U2 cannot see cross-module consumers of fixture libraries named *_test.dag (flagship: extdeps/languages/rust_test.dag). The carveout is a named §6 scaffold; dissolve-on remains rename off the _test.dag suffix or import-graph reachability.

Also restacked onto sweep-A tip (admission file-grain key expand).

— sent from proud-wren-892

@gunbai-bot
gunbai-bot Bot force-pushed the session/proud-wren-892-sweep-b branch 2 times, most recently from 793ce7c to b011f68 Compare July 26, 2026 04:46
@gunbai-bot
gunbai-bot Bot force-pushed the session/proud-wren-892-sweep-a branch from c5a86a3 to ef8a25b Compare July 26, 2026 04:47
@gunbai-bot
gunbai-bot Bot force-pushed the session/proud-wren-892-sweep-b branch 2 times, most recently from c84a649 to 999aefa Compare July 26, 2026 05:02
@gunbai-bot

gunbai-bot Bot commented Jul 26, 2026

Copy link
Copy Markdown
Contributor Author

Addressed review 43128 (all three confirmed):

  1. parse_binding helpers — restored into parse_binding_fidelity_support.dag (not *_test.dag, so U2 module-local orphan hygiene does not false-red cross-module exports). Long-lane + fn_body_seam_witness_helpers now import from the support module.
  2. floor_skip roster — retargeted floor_skip_discovery_witness.rs from deleted floor_runner_node_frontier_policy_holds to floor_test_untouched_skips_assumed_green_holds.
  3. bisect_normalize_terminates — restored as test fn beside the other bisect termination witnesses for interpreted_parse_termination_test.rs.

— sent from proud-wren-892

@gunbai-bot

gunbai-bot Bot commented Jul 26, 2026

Copy link
Copy Markdown
Contributor Author

Addressed review 43137: confirmed bisect_through_parse_production had zero callers after its termination wrappers were deleted. Removed the dead helper so U2 orphan hygiene stays green.

— sent from proud-wren-892

@gunbai-bot

gunbai-bot Bot commented Jul 26, 2026

Copy link
Copy Markdown
Contributor Author

Addressed review 43146: confirmed. Umbrella c_compilation_unit_witnesses is gone; Rust harness now runs leaf witness_r3_header_source_object_paths. Grepped other src/v1/** run_claim("…") string targets against deleted umbrella names — only this harness was stale (floor_skip_discovery_witness.rs already correct; coproduct_reflection_conformance_test.rs only mentions dissolved names in a residual comment).

Also restacked onto latest sweep A.

— sent from proud-wren-892

@gunbai-bot
gunbai-bot Bot force-pushed the session/proud-wren-892-sweep-b branch from 482477f to 59d19b9 Compare July 26, 2026 05:27
@gunbai-bot

gunbai-bot Bot commented Jul 26, 2026

Copy link
Copy Markdown
Contributor Author

Merge conflict already cleared: session/proud-wren-892-sweep-b was restacked onto session/proud-wren-892-sweep-a @ 6e4166793a. Tip is now 59d19b9165 (A is an ancestor); GitHub reports mergeable=MERGEABLE / CLEAN. The conflict notice still naming 482477f is the pre-restack tip.

— sent from proud-wren-892

@gunbai-bot
gunbai-bot Bot force-pushed the session/proud-wren-892-sweep-a branch 2 times, most recently from 325a23a to eef1048 Compare July 26, 2026 12:57
@gunbai-bot
gunbai-bot Bot force-pushed the session/proud-wren-892-sweep-b branch from 59d19b9 to d6546ba Compare July 26, 2026 13:02
@gunbai-bot

gunbai-bot Bot commented Jul 26, 2026

Copy link
Copy Markdown
Contributor Author

Rebased session/proud-wren-892-sweep-b onto current session/proud-wren-892-sweep-a (9ef6e31d92). Replayed only B-unique commits (onto the prior A tip) to avoid re-applying the dag/test sweep already on A. Resolved ci_floor_plan_witness_test.dag (kept A's synthetic source-ingest ordering + leaf test fn) and wrap_decision_predicate_test.dag (kept composite Instantiation-wire witnesses from main; dropped dissolved umbrella).

— sent from proud-wren-892

@gunbai-bot
gunbai-bot Bot force-pushed the session/proud-wren-892-sweep-a branch from 9ef6e31 to 848311b Compare July 26, 2026 13:11
@gunbai-bot
gunbai-bot Bot force-pushed the session/proud-wren-892-sweep-b branch from d6546ba to 001e902 Compare July 26, 2026 13:12
@gunbai-bot

gunbai-bot Bot commented Jul 26, 2026

Copy link
Copy Markdown
Contributor Author

Restacked onto rebased sweep-A (848311bac2) after #7273 rebased onto latest main.

— sent from proud-wren-892

Brian Searls and others added 3 commits July 26, 2026 13:41
Brian Searls and others added 5 commits July 26, 2026 13:41
Brian Searls
WIP: test umbrella dissolution
f862fe0
Brian Searls @cursoragent
Hygiene: drop stray blank line between unit tests.
7c081b1 
Co-authored-by: Cursor <cursoragent@cursor.com>
Brian Searls @cursoragent
Restore stale consumer edges broken by orphan/umbrella sweep.
49953db 
Review 43128: move parse-binding shared helpers into a non-*_test
support module and repoint long/body_lowering imports; retarget
floor_skip discovery roster onto a surviving floor_test_* leaf;
restore bisect_normalize_terminates as a test fn for the Rust
termination harness.

Co-authored-by: Cursor <cursoragent@cursor.com>
Brian Searls @cursoragent
Delete orphan bisect_through_parse_production helper.
beec58c 
U2 orphan hygiene is wired on this PR; the helper's only callers
(bisect_parse_production_terminates / single_module_parse_expr) were
already removed, so discovery would refuse the dark residue.

Co-authored-by: Cursor <cursoragent@cursor.com>
Brian Searls @cursoragent
Repoint c_compilation_unit Rust harness to a surviving leaf.
40b5c03 
Umbrella c_compilation_unit_witnesses was dissolved; the green-by-execution
harness still called the deleted name. Grep of other src/v1 run_claim
string targets found no further stale umbrella callers.

Co-authored-by: Cursor <cursoragent@cursor.com>
@gunbai-bot
gunbai-bot Bot force-pushed the session/proud-wren-892-sweep-b branch from 001e902 to 40b5c03 Compare July 26, 2026 13:41
@briansrls
briansrls merged commit 1084e8c into session/proud-wren-892-sweep-a Jul 26, 2026
@briansrls
briansrls deleted the session/proud-wren-892-sweep-b branch July 26, 2026 13:46
@gunbai-bot
gunbai-bot Bot restored the session/proud-wren-892-sweep-b branch July 26, 2026 13:51
@gunbai-bot gunbai-bot Bot mentioned this pull request Jul 26, 2026
Merged
3 tasks
briansrls added a commit that referenced this pull request Jul 26, 2026
@briansrls @cursoragent
Restore main cli_run scaffold receipt blocks dropped during rebase.
942a99b 
Re-add witness_admission_source_scan scaffold marker unit test, declaration-grain
Receipt comment pin, and #7274 orphan-sweep dissolve-on note — no PR-intended deletions.

Co-authored-by: Cursor <cursoragent@cursor.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@briansrls