Repository navigation
test umbrella dissolution: mechanism (U1–U3) - #7270
Merged
Merged
Conversation
…gets. cargo fmt for the WIP hygiene module; delete residual test-fn umbrellas that chained already-promoted conjuncts; promote leftover plain conjuncts; migrate enrollments off deleted names (file-grain or leaf retarget); treat nullary test fns as umbrella conjuncts so residuals stay detectable. Co-authored-by: Cursor <cursoragent@cursor.com>
The sweep's unused-helper deletion truncated rust_pick_additional_lex_rules mid-literal, which panicked module-index parse in regen and heal jobs. Co-authored-by: Cursor <cursoragent@cursor.com>
gunbai-bot
Bot
changed the title
This was referenced Jul 26, 2026
Unblocks fmt (alphabetical pub mod) and regen_verify (lib.rs + std_realization_schedule.rs fixed-point). Co-authored-by: Cursor <cursoragent@cursor.com>
Slash tokens inside seed_retained_intrinsic_registrations broke heal/regen module-index parse. Co-authored-by: Cursor <cursoragent@cursor.com>
Contributor
|
Re review 43082: confirmed — sent from proud-wren-892 |
Contributor
|
Re review 43082: confirmed — sent from proud-wren-892 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Mechanism half of umbrella dissolution (under GitHub’s 300-file
gh pr diffcap).test_module_hygiene(parse umbrella detection, orphan enroll-or-refuse with unit RED, empty-functionfile-grain expand)cli_rundiscovery expand; U2 orphan check deferred until corpus sweep (test umbrella dissolution: corpus sweep A (dag/test) #7273/test umbrella dissolution: corpus sweep B (src/v2 + orphan wire) #7274) — unit-tested, not named-walk-live herecheck_fns: []→function: ""projection incommit_workflow; schedule note for optional functionCorpus sweep stack: #7273 (dag/test) → #7274 (src/v2 + orphan wire).
Test plan
cargo test -p v1-compiler --lib test_module_hygienecigreen