Repository navigation
FieldOfFractions §7.2: ground the record model + witnesses - #7210
Merged
Merged
Conversation
…lapse witnesses Registers the two remaining model-scoped witnesses for the FieldOfFractions<R> grounding (dag/std/algebra.dag, num/denom body landed in the prior commit): - field_of_fractions_single_declaration_test: corpus-wide grep-shape witness asserting exactly one `type FieldOfFractions` declaration exists (guards against a future §3 fork; FieldOfFractions had no existing fork to delete, unlike GroupCompletion in #7197). - field_of_fractions_construction_test (retirement-tagged, Rust-retained): asserts eval_record_lit does NOT special-case FieldOfFractions into a native scalar collapse — the deliberate negative-space counterpart to GroupCompletion's collapse, since Rational has no lossless native checkpoint to collapse into. Scope: model only, per sharp-bee-290 sign-off. §7.3 realization (emitter Rust-struct emission + generic arithmetic trait derivation) is explicitly held pending separate sign-off and gated on Root-4. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
gunbai-bot
Bot
changed the title
Merged
2 tasks done
briansrls
added a commit
that referenced
this pull request
Jul 25, 2026
…ll note Re-adds the DESIGN.md open-threads bullet the ci-auto-heal bot deleted (f87d21b), fixing the orphan-doc finding, with the PR #7210 status corrected from an inaccurate "LANDED" to "content-reviewed clean and pending merge" to match the doc body's now-accurate wording. Also carries the doc's own tense/accuracy fixes (dangling links removed, present-tense claims about unmerged branches reworded to describe the actual pre-fix state of this branch's tree). Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
briansrls
added a commit
that referenced
this pull request
Jul 25, 2026
…int_scalar_phantom) (#7212) * Hollow-alias construction wall: design note (third specimen — checkpoint_scalar_phantom) Draft-only, no code lands: generalizes the GroupCompletion (#7197) and FieldOfFractions (#7210, landed) construction-side specimens into a named §5 unwritable-class candidate, and cites the emit-side companion (checkpoint_scalar_phantom / v1_compiler_emit_rust.rs:746 widen, vivid's E0107 bucket, loyal-raven's dotted-path E0308 finding) as a separately gated Root-4, not this note's scope. Links from DESIGN.md open threads per repo convention to avoid the orphan-doc floor check. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> * Fix dangling links: remove references to unmerged #7197-branch design doc groupcompletion-pair-construction-design.md exists only on the unmerged #7197 branch, not on main — linking to it from a main-branch doc trips the pre-push doc_graph_has_no_dangling_links witness. Replace the two markdown links with plain PR/section references. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> * chore: regenerate drifted generated artifacts (ci auto-heal) * WIP: GroupCompletion grounding lane — numeric tower next layer, design-note-f * Fix review 42607: re-add DESIGN.md link, correct tense/accuracy in wall note Re-adds the DESIGN.md open-threads bullet the ci-auto-heal bot deleted (f87d21b), fixing the orphan-doc finding, with the PR #7210 status corrected from an inaccurate "LANDED" to "content-reviewed clean and pending merge" to match the doc body's now-accurate wording. Also carries the doc's own tense/accuracy fixes (dangling links removed, present-tense claims about unmerged branches reworded to describe the actual pre-fix state of this branch's tree). Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> * chore: regenerate drifted generated artifacts (ci auto-heal) * Re-add DESIGN.md wall-note link deleted again by ci-auto-heal regen The gunbc-ci-auto-heal bot's regen commit (a481a93) deleted the same hollow-alias-construction-wall open-threads bullet a prior auto-heal commit had already deleted once (f87d21b), re-breaking the doc_graph_has_no_orphan_docs / doc_graph_is_clean CI gates the same way. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> * chore: regenerate drifted generated artifacts (ci auto-heal) * WIP: GroupCompletion grounding lane — numeric tower next layer, design-note-f * Regenerate DESIGN.md from design_document.dag (real fix for drift gate) The prior hand-edits to DESIGN.md kept getting reverted by gunbc-ci-auto-heal because DESIGN.md is a generated artifact projected from dag/gunbc/design_document.dag's expected_design_md(). The durable fix is the open_threads_blocks() edit in that file (already committed as the WIP commit above); this commit lands the regenerated DESIGN.md produced by main_wet so the drift gate is satisfied at the true source. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> --------- Co-authored-by: Brian Searls <briansrls@gunb.ai> Co-authored-by: Claude Sonnet 5 <noreply@anthropic.com> Co-authored-by: gunbc-ci-auto-heal <gunbc-ci-auto-heal@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
FieldOfFractions<R>at its single authority (dag/std/algebra.dag) from a bodyless declaration to a real 2-field record{ num: R, denom: R }, following the §0 completion-pattern convention already established forGroupCompletion<M>(GroupCompletion grounding lane — numeric tower next layer, design-note-first #7197) — same pattern, multiplicative strength instead of additive.std_algebra.rs) in lockstep so the model and its interpreter representation stay coherent.field_of_fractions_single_declaration_test— de-fork non-regression: corpus-wide shape scan asserting exactly onetype FieldOfFractionsdeclaration exists (there was no pre-existing fork to delete, unlike GroupCompletion; this guards against a future one).field_of_fractions_construction_test— negative-space no-collapse: asserts constructingFieldOfFractions{num, denom}through the interpreter produces a real boxedValue::Record, and deliberately does not collapse into a native scalar (Rational has no lossless native checkpoint, unlike GroupCompletion's collapse toValue::Int). Retirement-tagged (Rust-retained) since it inspects the interpreter's internalValuerepresentation, which has no.dag-level observable surface.Explicitly out of scope
GroupCompletion<M>is untouched here — that's GroupCompletion grounding lane — numeric tower next layer, design-note-first #7197, landing independently.FieldOfFractions) is held pending separate sign-off, gated on the Root-4 arithmetic-trait-derivation work. No emitter witness is included.See
docs/plans/groupcompletion-pair-construction-design.md§7.2 for the full design.Test plan
cargo test -p v1-compiler-tests field_of_fractions— 3 passedcargo build --workspace— clean (pre-existing warnings only, unrelated to this change)Co-Authored-By: Claude Sonnet 5 noreply@anthropic.com