Skip to content

Lane 1 - Homonym Renames - #7156

Merged
briansrls merged 3 commits into
mainfrom
session/keen-heron-268
Jul 24, 2026
Merged

briansrls merged 3 commits into
mainfrom
session/keen-heron-268

Conversation

@gunbai-bot

@gunbai-bot gunbai-bot Bot commented Jul 24, 2026 •

Copy link
Copy Markdown
Contributor

Lane 1 of the §13 namespace flip residue: rename homonym definitions so each contested bare name has exactly one definition, leaving the load-bearing/most-imported definition as the surviving bare name.

Renames

Name Renamed Survivor (unchanged)
render test.claim.cargo_target_path.render → render_file_path std.layout.render
Frame std.render.Frame → RenderFrame std.materialization_ladder.Frame
derivable test.claim.roadmap_status.derivable → derivable_item gunbc.roadmap_authority.derivable
Artifact gunbc.workflow.types.Artifact → RunArtifact; live_deploy DeploymentStep variant Artifact → ArtifactStep v2.std.artifact.Artifact

Consumer scoping (the load-bearing part)

dag/std/render.dag is load-bearing, so every Frame mention in the tree was classified per-file before editing. The brief flagged ~11 candidate consumers; 9 of them turned out to be std.materialization_ladder.Frame, not std.render.Frame, and were correctly left untouched (ci_materialization, execution_envelope, cli_run_repo_grant, artifact_store_scratch_grant, duplicate_computation, build_transport_admission, ci_deploy_access, and the three grant witness tests — each carries an explicit import std.materialization_ladder { Frame }).

The genuine std.render.Frame consumer set is 7 files: the definer, extdeps/render/{surface,terminal}, gunbc/ci_render, and 3 render witness tests. gunbc/ci_render.dag was not on the brief's list and was picked up by the sweep.

gunbc.workflow.types.Artifact has zero importers (the whole module does), so that rename is definition-only. ownership.dag's projection note, which names the Artifact/Dependency variants in prose, was updated with the variant.

Verification (by execution)

  • Whole-tree compile-clean gate: gunbc compile --target dag --dependency-pool-index primary-precedence — green.
  • Witnesses green (PASS, exit 0): cargo_target_path, roadmap_status, roadmap_gate, terminal_capability, render_surface, ci_render_histogram_width, live_deploy_emit_holds (the golden drift gate — no drift), effect_grant (7/7, confirming the untouched ladder-Frame consumers still resolve).
  • RED control: renaming the definer alone (type RenderFrame → RenderFrameBROKEN) while leaving consumers reds the suite — exit 1 with typed, located diagnostics at surface.dag:3:38 and terminal.dag:5:21. So the green above is discriminating, not vacuous.
  • Post-rename uniqueness re-checked: each of the four surviving bare names now has exactly one definition, and none of the five new names collides with an existing definition (no homonym was merely relocated).

Note for the lane owner

Artifact is not globally bare-unique after this change: src/v1/artifact.dag:14 also defines type Artifact (a build-artifact concept — ServiceBinary/Library/Frontend), distinct from v2.std.artifact.Artifact (a compiler source-artifact). This is the known v1-seed fork class that resolves by subtree and is out of this lane's scope — flagging rather than churning the seed, which shrinks toward zero per DESIGN §7.

briansrls and others added 2 commits July 24, 2026 03:00
gunbc.workflow.types.Artifact -> RunArtifact (zero importers, def-only).
live_deploy DeploymentStep variant Artifact -> ArtifactStep + consumers
(spec.dag, emit.dag, test/claim/live_deploy/emit_test.dag) and the
ownership.dag projection note that names the variant.

Leaves v2.std.artifact.Artifact as the bare Artifact.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@gunbai-bot
gunbai-bot Bot marked this pull request as ready for review July 24, 2026 03:25
@briansrls
briansrls merged commit 2d6fc6a into main Jul 24, 2026
4 of 5 checks passed
@briansrls
briansrls deleted the session/keen-heron-268 branch July 24, 2026 09:02
gunbai-bot Bot pushed a commit that referenced this pull request Jul 24, 2026
…5-pr4-b3

Bring branch current with main (#7156/#7157/#7160 landed).
gunbai-bot Bot pushed a commit that referenced this pull request Jul 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant