Skip to content

fix governor - #7073

Closed
briansrls wants to merge 12 commits into
mainfrom
fix/tidy-ibex-merge
Closed

briansrls wants to merge 12 commits into
mainfrom
fix/tidy-ibex-merge

Conversation

@briansrls

Copy link
Copy Markdown
Contributor

Auto-opened by session-dashboard for session sunny-wolf-225.
Pushing to fix/tidy-ibex-merge advances this PR.

Worker attestation

Before flipping this PR to ready for review, confirm each item:

  • Title describes the change (not the session id or branch).
  • PR body summarises what and why (replace the TODO below).
  • Tests run: name the command (e.g. npm test, cargo test) and the result.
  • If this closes a work item, the body contains a Closes #N directive.
  • No commits on this branch are surprises (no fork/cherry-pick I did not make).
  • No secrets / credentials / large binaries staged.

Summary

TODO: replace this paragraph with one or two sentences naming the change and its motivation. Reviewers read this first.

Test plan

  • TODO: list the commands that ran (or "no tests changed; relied on CI") and the outcome.

briansrls and others added 12 commits July 22, 2026 13:06
Coproduct witness receipt must start on the same line as the data binding; a newline after `=` was rejected by the parser (run 29870076256 exit 101).

Co-authored-by: Cursor <cursoragent@cursor.com>
Lift gunbc_ci_plan_artifact_batches to gunbc.ci_spec.plan_artifact_plan_function
so the arm-time budget-refusal roster is fully symbolic; add
gunbc_floor_arm_time_budget_refusal_plan_functions_claim_executor_seed with a
member-equality witness and a claim_executor unit test pinning the seed Rust
list until v2 emit dissolves it.

Co-authored-by: Cursor <cursoragent@cursor.com>
Multiline `data ... =` continuation rejected by parser (CI regen exit 101).

Co-authored-by: Cursor <cursoragent@cursor.com>
…41259).

Add gunbc_floor_arm_time_budget_refusal_plan_function_roster() as the
materialized authority; claim_executor test evaluates it and compares to
FLOOR_ARM_TIME_BUDGET_REFUSAL_PLAN_FUNCTIONS. Dag witness now checks seed
data against the materialized fn, not two aliased data rows.

Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
…srv3 host + FloorOutcome grounding)

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@briansrls
briansrls marked this pull request as ready for review July 22, 2026 16:02
@cursor

cursor Bot commented Jul 22, 2026

Copy link
Copy Markdown

Bugbot is not enabled for your account, so this pull request was not reviewed.

Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs.

@gunbai-bot

gunbai-bot Bot commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

Addressed in commit 5cd0155 (pushed to fix/tidy-ibex-merge). The review 41458 finding was valid: the remote tip 62ac6f6 was a WIP merge that still carried unresolved conflict markers in dag/gunbc/runner_slot_allocation.dag:8-13. The resolution unions both sides exactly as the review prescribed — operator_host_srv3 is kept (still used at the srv3 slot rows) and the gunbc.ci_failure_class import is added for the FloorOutcome witness rows:

import gunbc.fleet_intent_network { operator_host_srv1, operator_host_srv2, operator_host_srv3 }
import gunbc.ci_failure_class { FloorOutcome, NoFailure, FloorFailed, Structural, floor_outcome_blocks_merge }

Verified before push: no conflict markers remain in any tracked .dag/.rs; the ci_floor_plan closure compiles clean (331 sources) and the runner_slot_allocation minimum-viable-armed-budget wall witness evaluates true. A fresh ci run (29936550106) is now queued on the fixed head 5cd0155. — sent from sunny-wolf-225

@gunbai-bot

gunbai-bot Bot commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

Closing as a duplicate of #7072. Both PRs now point at the identical commit 5cd0155 (my push fast-forwarded fix/tidy-ibex-merge to the same merge-resolved commit the session branch already carried). #7072 is the canonical governor PR and already has 2 distinct approvals (claude, cursor) with 0 REQUEST_CHANGES; this PR has none, and approvals do not transfer between PRs. Merging both would double-apply the same commit. Consolidating on the approved #7072 — the governor fix (arm-time FloorBudgetBelowMinimumFootprint refusal + grounded witness receipts) lands identically there. The conflict-marker fix that review 41458 flagged here is present in that shared commit. — sent from sunny-wolf-225

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant