Repository navigation
Mark orchestration→effect_plan dissolution (A2 fast-follow #6903) - #6921
Conversation
The v1 module-path-index parser rejects data items before the first type declaration in orchestration.dag; move the dissolve-on markers to the end of the module to fix CI parse failure on claim_executor discovery. Co-authored-by: Cursor <cursoragent@cursor.com>
The v1 module-path-index parser rejects data strings containing patterns
like Do{run: Run} (unescaped braces with an interior colon). Reword the
orchestration/effect_plan dissolve-on markers to Do-run / Do-effect so
claim_executor discovery can parse orchestration.dag.
Co-authored-by: Cursor <cursoragent@cursor.com>
gunbai-bot
Bot
changed the title
CARGO_MANIFEST_DIR is src/v1/stage0, so the fixture lives at ../../../src/v2/std/orchestration.dag (not ../../src/v2/...). Co-authored-by: Cursor <cursoragent@cursor.com>
|
Verified both approval reviews against current review 40223 (claude-opus-4-7): Confirmed — the on-carrier markers name the authority ( review 40227 (composer-2.5): Confirmed — the dissolve-on split ( CI floor is re-running on the path-fix commit; will not merge until — sent from royal-lark-779 |
|
Verified both latest approvals on current HEAD review 40231 (composer-2.5): Confirmed. review 40232 (claude-opus-4-7): Confirmed. Markers are on-carrier per DESIGN §6; witnesses are appropriate string-presence receipts for a marker-landing PR; no new unit fields or forked authority. No further code changes for this item. Dashboard readiness on — sent from royal-lark-779 |
Main moved 4 commits (namespace wave 1 #6848, Rc-to-Arc share spike #6913, orchestration dissolution #6921, effect-grants slice A #6920), 978 files. 5 conflicts, all in files where main changed content and this branch changed the im token. Resolved by taking main's content wholesale and re-applying the token substitution, so main's semantics are preserved exactly and this branch's single axis is reapplied: bin/compile_clean_diagnostic_histogram.rs, bin/infer_semantics_witness.rs, cli_run.rs, global_bare_corpus_census_test.rs, type_env_scope_chain_test.rs Main also introduced 3 files carrying im_rc that this branch had never seen (global_bare_census_coverage_test.rs, global_bare_variant_locals_receipt_test.rs from the namespace wave, plus pipeline.rs via automerge). Swapped those too -- im-rc is no longer a declared dependency, so they would not have compiled. Merge commit rather than rebase per repo policy (avoids force-push; identical history under squash-merge). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
…th perf receipt (#6929) * WIP: im-rc to im swap: prerequisite for Arc share, with perf receipt * regen stage0 after im-rc -> im swap (rustfmt re-wrap) The shorter `im::` token lets rustfmt fit several previously-wrapped calls on one line. regen_stage0 --verify reported divergence_count=1 (compiler_tests.rs); running regen in write mode reconciles the emitted seed with the committed seed, and `cargo fmt --all` re-wraps four hand-maintained files for the same reason. All five diffs are formatting-only: the sole token change is trailing commas dropped when a multi-line call is joined onto one line. regen_stage0 --verify now reports regen_divergence_count=0 across 6 runs. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * docs: mark C1 collection-half blocker addressed by the im swap The C1 realization note (2026-07-14) asserted two blockers for SharedTypecheckCaches: (a) use std::collections::HashMap shells, not im_rc::HashMap, and (b) Arc not Rc for every payload. This PR's im-rc -> im swap addresses (a): im is the Arc-backed sibling of im-rc (same crate source; build.rs sets cfg(threadsafe) on package name, flipping the crate-internal Ref<A> from Rc to Arc), so im::HashMap / im::Vector are Send/Sync whenever their contents are and the collection carrier is no longer the obstacle. (b) STANDS: the payloads are still Rc-backed and therefore still !Send, so Increment C host wiring remains blocked on the store-path Rc->Arc migration scoped in section 4.2. This PR changed no Rc. Added as a dated addendum rather than a rewrite, so the 2026-07-14 note stays intact as a record of what was true then. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * Merge origin/main into session/cool-wren-467 (im-rc -> im swap) Main moved 4 commits (namespace wave 1 #6848, Rc-to-Arc share spike #6913, orchestration dissolution #6921, effect-grants slice A #6920), 978 files. 5 conflicts, all in files where main changed content and this branch changed the im token. Resolved by taking main's content wholesale and re-applying the token substitution, so main's semantics are preserved exactly and this branch's single axis is reapplied: bin/compile_clean_diagnostic_histogram.rs, bin/infer_semantics_witness.rs, cli_run.rs, global_bare_corpus_census_test.rs, type_env_scope_chain_test.rs Main also introduced 3 files carrying im_rc that this branch had never seen (global_bare_census_coverage_test.rs, global_bare_variant_locals_receipt_test.rs from the namespace wave, plus pipeline.rs via automerge). Swapped those too -- im-rc is no longer a declared dependency, so they would not have compiled. Merge commit rather than rebase per repo policy (avoids force-push; identical history under squash-merge). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * WIP: im-rc to im swap: prerequisite for Arc share, with perf receipt --------- Co-authored-by: Brian Searls <briansearls1@gmail.com> Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
1 participant
Summary
Close the keystone debt from #6903: #6903 minted
v2.std.effect_planalone without marking the planned rename/dissolution ofv2.std.orchestrationperhost-effect-orchestration.md§1b Phase B.orchestration_to_effect_plan_dissolve_on+ scaffold note onv2.std.orchestration(bash-emitPipeline/Do-runscaffold; composition authority iseffect_plan)effect_plan_orchestration_succession_dissolve_ononv2.std.effect_plan(parallel neighbor-vocab scaffold until Phase B rename)host_effect_plan_witness_test.dagwith discriminating receipts that both dissolve-on markers are present and namedTest plan
gunbc run --source-root dag --source-root src/v2 --entry dag/test/claim/host_effect_plan_witness_test.dag --function host_effect_plan_witness_holds→trueclaim_executoron PR)