Repository navigation
Wave A2 — finish the host_effect_apply spine: typed effects + Do{effect} target band (the keystone that unblocks the bulk). Per docs/plans/host-effect-orchestration.md (the std.effect_plan band; 'leaves = Do{effect} — never a command string') + docs/plans/shell-intent-emit-realization-design.md ('ca - #6903
Conversation
… spine.
Add generic EffectPlan<E> with Do{effect} leaves (never command strings),
product-layer host_effect_plan_apply routing EffectPlan<HostEffect> through
host_effect_apply, and a discriminating witness (Do converges, control-flow
refuses fail-closed). Fixes parse/import errors from the initial WIP commit.
Co-authored-by: Cursor <cursoragent@cursor.com>
|
Review 40023 — placeholder Verified: the finding is correct. Why not fixed in this keystone: — sent from vivid-dove-796 |
Local verification on 63ab31c: cargo build (release), gunbc compile (--source-root src/v2 --source-root dag --target dag), and host_effect_plan_witness_holds (--claim-run) all green. Prior CI failures were cancelled superseded runs / self-hosted runner queue, not code regressions. Co-authored-by: Cursor <cursoragent@cursor.com>
The witness drives real shell.Exec.Run (true/exit-1) through host_effect_plan_apply; Hermetic discovery cannot discriminate exit codes under mock_response, so CI returned Bool(false) in 1.5ms. Exclude from discovery and add bin_witness_wet_entries row, matching host_build_cache_provision_real_execution_witness_test.dag. Co-authored-by: Cursor <cursoragent@cursor.com>
|
Review 40128 — two non-blocking follow-ups Both findings verified against current
No code change in this PR; both tracked as follow-up on the reconcile-carrier + control-flow lanes. — sent from vivid-dove-796 |
) * WIP: A2 fast-follow — close the effect_plan keystone debt from #6903 (merged * WIP: A2 fast-follow — close the effect_plan keystone debt from #6903 (merged * fix: place orchestration dissolve-on data after type declarations The v1 module-path-index parser rejects data items before the first type declaration in orchestration.dag; move the dissolve-on markers to the end of the module to fix CI parse failure on claim_executor discovery. Co-authored-by: Cursor <cursoragent@cursor.com> * WIP: A2 fast-follow — close the effect_plan keystone debt from #6903 (merged * fix: avoid colon-in-brace literals in dissolve-on data strings The v1 module-path-index parser rejects data strings containing patterns like Do{run: Run} (unescaped braces with an interior colon). Reword the orchestration/effect_plan dissolve-on markers to Do-run / Do-effect so claim_executor discovery can parse orchestration.dag. Co-authored-by: Cursor <cursoragent@cursor.com> * fix: correct orchestration parse regression test path CARGO_MANIFEST_DIR is src/v1/stage0, so the fixture lives at ../../../src/v2/std/orchestration.dag (not ../../src/v2/...). Co-authored-by: Cursor <cursoragent@cursor.com> --------- Co-authored-by: Brian Searls <briansearls1@gmail.com> Co-authored-by: Cursor <cursoragent@cursor.com>
Auto-opened by session-dashboard for session
vivid-dove-796.Pushing to
session/vivid-dove-796advances this PR.Worker attestation
gunbc compile(clean) +host_effect_plan_witness_holds(green).Closes #Ndirective.Summary
Mint the generic
std.effect_planband (EffectPlan<E>withDo { effect: E }leaves — never command strings) and the product-layerhost_effect_plan_applyinterpreter that routesEffectPlan<HostEffect>through the existinghost_effect_applyspine. Control-flow steps (If,For,While, etc.) refuse fail-closed until predicate interpretation lands. This is Wave A2 perdocs/plans/host-effect-orchestration.md§1b and unblocks the shell→intent migration bulk.Test plan
gunbc compile --source-root src/v2 --source-root dag --target dag— clean on63ab31chost_effect_plan_witness_holds—true(Do converges, failure fails closed, sequential Do converges, If refuses)claim_executoron PR) — queued; prior failures were self-hosted runner acquisition, not code