Repository navigation
deploy_dashboard_srv1 E2BIG on every main push: emitted deploy fold spawns sh with whole script as one argv (grew past MAX_ARG_STRLEN with roadmap content); root fix = reference checked-out artifacts instead of embedding (dag/gunbc/live_deploy/emit.dag; first failure run 29468603049) - #6733
Merged
Merged
Conversation
The negative-check witness embedded a literal "{script}" substring in
its needle string, which the compiler's string-literal interpolation
picked up as a reference to an out-of-scope `script` variable
(undefined variable 'script'). Drop that witness; the remaining two
(stdin transport present, script exceeds the local argv-embed budget)
already prove the fix.
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Both witness tests independently hardcoded a byte_size(65536) budget under two different local names — a §3 nickname fork of the same kernel fact. Ground it once in dag/extdeps/shell/shell.dag as shell_argv_max_arg_strlen, citing the Linux kernel's MAX_ARG_STRLEN (include/uapi/linux/binfmts.h, 32 pages = 131072 bytes), and have both witnesses derive their budget from that authority instead of re-declaring it. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
added 2 commits
July 16, 2026 05:50
# Conflicts: # dag/test/claim/shell_exec_run_argv_embed_witness_test.dag
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
The stdin transport (PR #6711/#6733) writes the full script to the child's stdin synchronously, before draining stdout/stderr. A script that both consumes a large stdin payload and produces substantial stdout can deadlock on full OS pipe buffers; when the child exits early the write then fails with EPIPE ("Broken pipe (os error 32)"), which is exactly what deploy_dashboard_srv1 hit on main after #6711 merged (the apply script is 246KB in, ~150KB out). Move the stdin write to a spawned thread running concurrently with wait_with_output() (which drains stdout/stderr). A stdin-write error is only treated as fatal if the child itself exited non-zero, since a script that exits 0 before consuming all of stdin is a legitimate early-exit pattern (ordinary SIGPIPE/broken-pipe semantics). Verified locally: a real shell.Exec.Run invocation with a 163,907-byte stdin script that echoes 148,890 bytes of stdout completed cleanly (exit=0) with the fix; reproduces the deadlock/broken-pipe without it. Drops two scratch files (_deadlock_big_script.sh, _deadlock_repro_test.dag) that an automated WIP commit picked up from local verification scratch space — not intended as tracked test fixtures. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Contributor
|
Investigated the CI failure on This is unrelated to this PR's diff — it's a v2 migration-debt ratchet that counts un-migrated Ran it locally against the exact same commit ( Clean pass. This looks like the known shared-runner infra flake pattern (adaptive-width concurrent jobs on the same host transiently observing a sibling job's mid-write filesystem state), not a real regression. Re-running the CI job should clear it — no code fix needed here. — sent from warm-bee-432 |
briansrls
added a commit
that referenced
this pull request
Jul 16, 2026
The E2BIG deploy witness needs live_deploy + shell_argv_max_arg_strlen authorities; strip-empty replay would not resolve. Co-authored-by: Cursor <cursoragent@cursor.com>
briansrls
added a commit
that referenced
this pull request
Jul 16, 2026
The E2BIG deploy witness needs live_deploy + shell_argv_max_arg_strlen authorities; strip-empty replay would not resolve. Co-authored-by: Cursor <cursoragent@cursor.com>
briansrls
added a commit
that referenced
this pull request
Jul 16, 2026
The E2BIG deploy witness needs live_deploy + shell_argv_max_arg_strlen authorities; strip-empty replay would not resolve. Co-authored-by: Cursor <cursoragent@cursor.com>
gunbai-bot Bot
pushed a commit
that referenced
this pull request
Jul 16, 2026
#6733's stdin-transport fix to dag/gunbc/live_deploy/emit.dag changed the emitted apply script but never regenerated the committed golden, tripping GeneratedArtifactDriftGate on every main push since. Regenerated via `gunbc run ... dag/tools/generated_artifact_gate.dag --function main_wet`; re-ran the drift gate locally against the result — ExitSuccess. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
briansrls
added a commit
that referenced
this pull request
Jul 16, 2026
#6745) #6733's stdin-transport fix to dag/gunbc/live_deploy/emit.dag changed the emitted apply script but never regenerated the committed golden, tripping GeneratedArtifactDriftGate on every main push since. Regenerated via `gunbc run ... dag/tools/generated_artifact_gate.dag --function main_wet`; re-ran the drift gate locally against the result — ExitSuccess. Co-authored-by: Brian Searls <briansearls1@gmail.com> Co-authored-by: Claude Sonnet 5 <noreply@anthropic.com>
This was referenced Jul 16, 2026
briansrls
added a commit
that referenced
this pull request
Jul 16, 2026
The E2BIG deploy witness needs live_deploy + shell_argv_max_arg_strlen authorities; strip-empty replay would not resolve. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Auto-opened by session-dashboard for session
warm-bee-432.Pushing to
session/warm-bee-432advances this PR.Worker attestation
Before flipping this PR to ready for review, confirm each item:
npm test,cargo test) and the result.Closes #Ndirective.Summary
TODO: replace this paragraph with one or two sentences naming the change and its motivation. Reviewers read this first.
Test plan