Repository navigation
W0.1: unify algebraic-composition classifier quartet - #6667
Merged
Merged
Conversation
gunbai-bot
Bot
changed the title
|
Bugbot is not enabled for your account, so this pull request was not reviewed. Enable Bugbot in the Cursor dashboard to get automatic reviews on future PRs. |
The variant moved to algebraic_composition.dag with the classifier rows; idempotency.dag still pattern-matches it in witness/equality helpers. Co-authored-by: Cursor <cursoragent@cursor.com>
Restore the vacuity sibling-family blockquote from main; the prior regenerated-artifact drift fix was an unrelated lane change that would orphan vacuity-lens-design.md from the doc graph. Co-authored-by: Cursor <cursoragent@cursor.com>
1 task done
Note restoration is owned by #6671; revert dag and md to origin/main so this PR stays the pure 5-file classifier de-fork and drift-green. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Wave-0 lens de-fork (lens-consolidation-design.md W0.1): collapse the four forked
DependencyKindClassifiertables for effect, idempotency, ownership, and parallelism into one shared authority.v2.lens.common.algebraic_compositionwith the quartet's verdict types and classifier rows (effect_classifier,idempotency_classifier,ownership_classifier,parallelism_classifier).fn …_dependency_kind_classifier()engine.effectwith the sameclassify_dependency_viewpath (uniformEffectClassification {}row per kind).Verdict types and witness logic stay per-lens; only the duplicated classifier machinery is unified.
Test plan
claim_batch --source-root src/v2 --source-root dag --entry src/v2/workflow/lens_effect_family_eval_test.dag --function witness_lens_effect_family_gate_closed --claim-run— PASSclaim_batch --source-root src/v2 --source-root dag --entry src/v2/workflow/lens_idempotency_family_eval_test.dag --function witness_lens_idempotency_family_gate_closed --claim-run— PASSclaim_batch --source-root src/v2 --source-root dag --entry src/v2/workflow/lens_ownership_family_eval_test.dag --function witness_lens_ownership_family_gate_closed --claim-run— PASSclaim_batch --source-root src/v2 --source-root dag --entry src/v2/workflow/lens_parallelism_family_eval_test.dag --function witness_lens_parallelism_family_gate_closed --claim-run— PASS