Repository navigation
W0.3: delete fact_cardinality variant_mismatch nickname - #6666
Merged
Merged
Conversation
…ality alias Collapse DuplicateComputationViolation onto AuthoredDuplication via std.materialization_ladder, delete the bare-alias variant_mismatch nickname in fact_cardinality, and enroll the AuthoredDuplication shape witness on CI. Co-authored-by: Cursor <cursoragent@cursor.com>
The plan .dag authority no longer carries the vacuity sibling-family blockquote; sync the committed projection so generated_artifact_drift_gate passes on CI. Co-authored-by: Cursor <cursoragent@cursor.com>
Revert duplicate_computation→LadderVerdict routing, placement-grain witness enrollment, and inert-layer-lens regen — those belong to W1.2 (load-bearing std/materialization_ladder) per operator re-scope. Co-authored-by: Cursor <cursoragent@cursor.com>
…ct (duplicate_co" This reverts commit 7b2d509.
Contributor
Author
|
CI failure is Pre-existing latent drift from #6638: hand-edited generated Holding per operator re-scope: will not add a drift fix on this PR (avoids 3-way conflict with #6667). Once #6667 merges to Approvals (claude + cursor) and mergeable=CLEAN already hold; only CI floor is blocked on the external #6667 merge. — sent from silent-heron-226 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Wave-0 §3 de-fork (re-scoped): delete the bare-alias
fact_cardinality_cross_tree_variant_mismatchinsrc/v2/lens/fact_cardinality.dag— it was a plain forwarding alias offact_cardinality_cross_tree_diverged_fork. The sole consumer (synthetic_unified_green_test.dag) now calls the canonical name.Out of scope (reverted from earlier drafts): routing
duplicate_computationontoLadderVerdict.AuthoredDuplication— that touches load-bearingdag/std/materialization_ladder.dagand is W1.2, not W0.Test plan
claim_batch—synthetic_unified_green_holds,synthetic_fork_red_holds(both PASS)W1.2 investigation (not implemented)
Goal: collapse duplication verdict forks onto
LadderVerdictper lens-consolidation-design §6.B — distinct from provenance verdicts (vacuity keepsVacuityEvidence; Share remedy must not be applied to vacuous tests).duplicate_computation.DuplicateComputationViolation→LadderVerdictDuplicateComputationViolation=DuplicateComputationDemand { computation_key, unguarded_count, sites }; emitted byduplicate_computation_violations/duplicate_computation_violation_count.AuthoredDuplication { identity, lca, site_count }fromstd.materialization_ladder— remedySharevialadder_verdict_prescribes.computation_key→identity;unguarded_count→site_count;lcaneeds frame projection (today empty — placement/argv grain has noFramepath yet).sites: List<String>on the verdict carrier (diagnostics move to projection layer or a located refusal type); all witnesses importing violation count APIs need enrollment review;materialize.dag/ CI materialization gates are separate grain — must not conflate without frame+nature.materialization_ladder.dag; needs discriminating witness onAuthoredDuplicationshape at placement grain.std.lens_verdict.LensVerdictsplitHolds | Violation | NotApplicable | UnrealizedwithLensVerdictDiagnostic— used by schedule, cache key completeness, table_decision_tree, host_language_transport_script, etc.LensVerdictis cross-invariant plumbing; only duplication-specific per-lens enums are the fork (per §3 rubric Q3).LadderVerdict, notLensVerdict.Violation, for authored-duplication findings; keepLensVerdictfor lenses whose invariant is genuinely envelope-shaped (schedule ordering, unrealized scaffolds). Registry/contracts must declare which verdict authority each lens uses.LensVerdict.Violationexpecting duplication semantics; Rust seedstd_lens_verdict.rsmust stay in sync withdag/std/lens_verdict.dag; no merge of vacuity/oracle verdicts intoLadderVerdict(review ruling: remedies differ).