Repository navigation
Dedup ecmascript/python/typescript catalog fn families (per-file parameterized cores) - #6318
Merged
Merged
Conversation
…root_ingest fix)
Contributor
CI investigation (
|
| Job | Result | Notes |
|---|---|---|
rust_tests |
pass (42m31s) | v1 rust gate green |
ci |
fail | gunbc ci (.dag witnesses + gates) timed out after 135 minutes |
Failure line: The action 'gunbc ci (.dag witnesses + gates)' has timed out after 135 minutes.
Last gantt marks before timeout show full-corpus compile still in progress (compile.reconcile.done at ~52 min wall; job killed at 135m cap). No witness/gate failure attributable to this PR's three-file dedup diff — the floor never finished compiling.
Matches systemic compile-wall called out by manager (same timeout on main/#6311/#6313). No push planned — another push would reset reviews and start another doomed 135m run.
PR substance unchanged: green base (#6311 merge), −290 lines, claude+cursor APPROVE on HEAD.
— sent from valiant-ant-848
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Mechanical per-file dedup of stamped catalog/primitive-fn families in the three cited upstream language models. Each file gains parameterized cores; every importer-visible name stays as a thin wrapper. No cross-language shared module (per operator lane brief).
Size accounting (
wc -l, main → branch)ecmascript.dagpython.dagtypescript.dagRaw diff: 467 insertions / 757 deletions across the three files.
Family → per-file core
ecmascript.dagecmascript_primitive_facts_node← 5×ecmascript_*_facts_nodeecmascript_primitive_spec_facts← 5×ecmascript_*_spec_factsecmascript_primitive_algebra_witness_node← 3×ecmascript_*_algebra_witness_nodeecmascript_catalog_surface_symbol_in_rows← 6× per-catalog*_catalog_surface_symbol(+ dissolved*_catalog_surface_step,*_catalog_surface_spelling_eq,*_catalog_surface_fold_false)ecmascript_primitive_fact_bundles_from_catalog_rows← 6×ecmascript_primitive_bundles_from_*_catalogpython.dagpython_primitive_facts_node← 5×python_*_facts_nodepython_primitive_algebra_witness_node← 3×python_*_algebra_witness_nodepython_g1_2_pair_axis_fact_bundle_entries← 5×python_g1_2_*_fact_bundle_entriespython_catalog_surface_symbol_in_rows← 5× per-catalog*_catalog_surface_symbol(+ dissolved step/spelling_eq/fold_false helpers)python_per_language_fact_bundle_entries_from_catalog_rows← 5×python_g1_2_*_catalog_entriestypescript.dagts_primitive_algebra_witness_node← 4×ts_*_algebra_witness_node(number/bigint/bool/string)ts_catalog_surface_symbol← inlined fold (dissolvedts_catalog_surface_symbol_step)ts_numeric_primitive_fact_bundles← inlined fold (dissolvedts_primitive_bundles_from_catalog_step)Dropped names are internal step/spelling helpers only; all importer-facing
fnnames grep-clean.Test plan
Executed locally (
CTRL_BUILD_BYPASS_SHIMS=1, release build):All three language modules resolve clean in witness closures touching
ecmascript.dag,python.dag, andtypescript.dag. Zero.rschanges.