Skip to content

Delete flaky test disposition_kernel_aligns_on_discriminator_fixture (hits #6239 wall, no value) - #6324

Merged
briansrls merged 1 commit into
mainfrom
flaky-test-delete
Jul 6, 2026
Merged

briansrls merged 1 commit into
mainfrom
flaky-test-delete

Conversation

@gunbai-bot

@gunbai-bot gunbai-bot Bot commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

What

Deletes the sole test in mod floor_disposition_kernel_alignment (src/v1/stage0/src/cli_run.rs) — a self-contained #[cfg(test)] leaf mod, 298 lines, zero external references.

Why

This one test was the culprit behind the "flaky infra" cargo test --workspace stalls. It runs the floor-disposition analysis, which typechecks the gunbc module closure live — dragging the #6239 compile-wall into the default test run. Per-module typecheck attribution caught it:

gunbc.fleet_intent           5.6s
gunbc.runner_spec_from_offer  36s
gunbc.ci_deploy_target_host   88s
gunbc.ci_deploy_access       416s   ← 7 minutes for one module

The test spent >9 min and never finished — deterministic (single-threaded reproducible), not infra flakiness. Its std::env::set_current_dir also raced under parallel execution (#5971 class), adding the non-deterministic ENOENT layer.

Operator directive (2026-07-06): no value, slated for deletion. Floor-disposition coverage is exercised in the floor; the real fix is the compile-wall itself (owned elsewhere).

🤖 Generated with Claude Code

This sole test in mod floor_disposition_kernel_alignment (cli_run.rs) ran the
floor-disposition analysis, which typechecks the gunbc module closure live — and
that hits the #6239 compile-wall: per-module typecheck attribution measured
gunbc.ci_deploy_access at 416s (7 min) for a single module, with the test spending
>9 min and never finishing. It was the sole reason `cargo test --workspace` appeared
to hang (deterministic, single-threaded reproducible), compounded by its
std::env::set_current_dir cwd-mutation racing under parallel execution (#5971 class).

No value and slated for deletion (operator, 2026-07-06). Floor-disposition coverage
is exercised in the floor; the real fix is the compile-wall itself (owned elsewhere).

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@gunbai-bot

gunbai-bot Bot commented Jul 6, 2026

Copy link
Copy Markdown
Contributor Author

Re: "CI FAILING (1 failing)" — the failing check is rust_tests → the v1 rust gate (fmt + clippy + nextest) step, and it's a 30-min step TIMEOUT (ran 16:03:23→16:33:36 = 30m13s, killed at the budget), not a clippy/fmt/nextest error. It is not caused by this deletion:

  • This is a deletion-only PR (removes 298 lines of a #[cfg(test)] mod); compile-verify was clean with zero warnings, so it can only make clippy marginally faster, never slower.
  • On main, this same gate runs 13–22 min (last 5 runs: 21m08s, 21m05s, 21m56s, 14m18s, 12m56s — all green under the 30m budget). This new-branch run hit 30m+ on a cold sccache + fleet contention (four of my PRs plus others building concurrently) — variance around a known-marginal interim budget, not a regression here.

I've re-run the failed job; the sccache is now primed by this run's compilation, so clippy should finish back under 30m. No code fix applies to this PR — the deletion is exactly what was asked. If the gate keeps grazing 30m under cold-cache storms tree-wide, that's a separate rust-gate-budget concern (same class as the floor budget), independent of this change.

— sent from lively-raven-355

@briansrls
briansrls merged commit cc31f3e into main Jul 6, 2026
0 of 2 checks passed
@briansrls
briansrls deleted the flaky-test-delete branch July 6, 2026 17:40
briansrls added a commit that referenced this pull request Jul 6, 2026
…6324)

This sole test in mod floor_disposition_kernel_alignment (cli_run.rs) ran the
floor-disposition analysis, which typechecks the gunbc module closure live — and
that hits the #6239 compile-wall: per-module typecheck attribution measured
gunbc.ci_deploy_access at 416s (7 min) for a single module, with the test spending
>9 min and never finishing. It was the sole reason `cargo test --workspace` appeared
to hang (deterministic, single-threaded reproducible), compounded by its
std::env::set_current_dir cwd-mutation racing under parallel execution (#5971 class).

No value and slated for deletion (operator, 2026-07-06). Floor-disposition coverage
is exercised in the floor; the real fix is the compile-wall itself (owned elsewhere).

Co-authored-by: Brian Searls <briansrls@gunb.ai>
Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
briansrls pushed a commit that referenced this pull request Jul 6, 2026
briansrls added a commit that referenced this pull request Jul 6, 2026
* WIP: dedup dag.dag mvp1 fn families into parameterized cores

* WIP: dedup dag.dag mvp1 fn families into parameterized cores

* Dedup dag.dag mvp1 fn families into parameterized cores.

Collapse five repeated stamping clusters (arrow-with-body nodes, target-model bundles, grammar token sequences, grammar-relation rows, statement prefix tokens) into shared parameterized cores with thin per-family wrappers, preserving explicit control-fixture operands at instance sites.

Co-authored-by: Cursor <cursoragent@cursor.com>

* Demand-driven realize: typecheck as memoized recursion over import edges (byte-identical, width=1) (#6306)

* WIP: ci timeout investigation

* trace_mark: stage-boundary gantt marks through the v1 compile pipeline

One new registry intrinsic trace_mark(label) -> Unit (the
record_source_chars_index_lookup precedent: registry row in 04_method.dag,
realization in runtime_rust.dag -> v1_rt, interpreter arm for totality).
Nine marks at the known segment boundaries of the compile pipeline
(frontend/normalize/reconcile/analyses/emit begin+done, dag collect/serialize),
so every run log carries a natural Gantt:

  [gantt] compile.reconcile.done t_ms=... rss_mib=...

Consecutive marks define the segments; rss_mib rides along for the memory
curve. Motivation: the whole-tree compile runs >60 min single-threaded with
zero output after "resolved N sources" — CI runs die inside it blind
(operator request 2026-07-05: checkpoints + a general logging system).

Marked bridge, interim by design: dissolves into the v2 per-RealizedStep
CostAccount (std.realization_measurement) when the realization-measurement
carrier is inhabited. Authority edits (.dag) land with hand-synced generated
seed (.rs) per the #5867 precedent — regen is currently blocked on main
(#6291); re-verify at the next regen window.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

* WIP: ci timeout investigation

* WIP: ci timeout investigation

* WIP: ci timeout investigation

* WIP: ci timeout investigation

* WIP: ci timeout investigation

* WIP: ci timeout investigation

---------

Co-authored-by: Brian Searls <briansrls@gunb.ai>
Co-authored-by: Claude Fable 5 <noreply@anthropic.com>

* Delete flaky test disposition_kernel_aligns_on_discriminator_fixture (#6324)

This sole test in mod floor_disposition_kernel_alignment (cli_run.rs) ran the
floor-disposition analysis, which typechecks the gunbc module closure live — and
that hits the #6239 compile-wall: per-module typecheck attribution measured
gunbc.ci_deploy_access at 416s (7 min) for a single module, with the test spending
>9 min and never finishing. It was the sole reason `cargo test --workspace` appeared
to hang (deterministic, single-threaded reproducible), compounded by its
std::env::set_current_dir cwd-mutation racing under parallel execution (#5971 class).

No value and slated for deletion (operator, 2026-07-06). Floor-disposition coverage
is exercised in the floor; the real fix is the compile-wall itself (owned elsewhere).

Co-authored-by: Brian Searls <briansrls@gunb.ai>
Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

---------

Co-authored-by: Brian Searls <briansrls@gunb.ai>
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: gunbai-bot[bot] <289086189+gunbai-bot[bot]@users.noreply.github.com>
Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant