Skip to content

Delete-sweep batch: module_path_index after census cluster retires - #5993

Merged
briansrls merged 2 commits into
mainfrom
session/proud-cat-249
Jun 30, 2026
Merged

briansrls merged 2 commits into
mainfrom
session/proud-cat-249

Conversation

@gunbai-bot

@gunbai-bot gunbai-bot Bot commented Jun 30, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Delete-sweep the hand-maintained module_path_index.rs seed module by folding its witness-layer-root authority, module-path index wrappers, and discriminating tests into cli_run.rs (where build_module_path_index and workspace_root already live). Removes the redundant HAND_MAINTAINED file from regen registry, lib.rs, emit templates, and bootstrap copy lists; repoints all census consumers to cli_run.

Part of the seed-shrink delete-sweep sequence after census-cluster consolidation (A1/A2 sibling batches).

Test plan

  • CTRL_BUILD_MODE=local RUSTC_WRAPPER= cargo check -p v1-compiler — green
  • CTRL_BUILD_MODE=local RUSTC_WRAPPER= cargo test -p v1-compiler --lib module_path_index — 6/6 passed (witness-layer-roots authority + module-path resolution tests)
  • CI floor (claim_executor) — pending on push

@gunbai-bot
gunbai-bot Bot marked this pull request as ready for review June 30, 2026 00:29
@gunbai-bot

gunbai-bot Bot commented Jun 30, 2026

Copy link
Copy Markdown
Contributor Author

Verified the APPROVE review against HEAD 814de5638e:

  • module_path_index.rs deleted; witness-layer-root reader, module-path index wrappers, and 6 discriminating tests live in cli_run.rs next to existing build_module_path_index.
  • No remaining crate::module_path_index::* call sites; regen HAND[], lib.rs, bootstrap copy/exclude lists, and emit hand-maintained mod string updated.
  • Authority still reads dsl/gunbc/ci_layer_roots.dag via tokenize+parse with fail-closed empty-root panics; synthetic non-default roots test preserved.

No code changes required for this review. Holding merge per manager lane until #5978 lands; awaiting second dashboard approval + CI green.

— sent from proud-cat-249

gunbai-bot Bot pushed a commit that referenced this pull request Jun 30, 2026
Keep model-only slice: floor_diff_observe.dag + floor witness on host_effect_apply.
The cli_run.rs eval bridge reverts to main; lands in a follow-on PR after #5993.

Co-authored-by: Cursor <cursoragent@cursor.com>
@gunbai-bot

gunbai-bot Bot commented Jun 30, 2026

Copy link
Copy Markdown
Contributor Author

Verified claude/claude-opus-4-7 APPROVE (review 33457) against HEAD 814de5638e:

  • module_path_index.rs deleted; witness-layer-root + module-path index logic folded into cli_run.rs; all call sites repointed to crate::cli_run::*.
  • regen_stage0 HAND[] and bootstrap copy/exclude lists drop module_path_index.rs; lib.rs mod removed; emit hand-maintained mod string updated.
  • seed burn-down base: dedup HAND[] roster + dissolve patch_cargo_toml #5978-base carryover confirmed: patch_cargo_toml_for_generated_crate gone from regen; 05_emit_rust.dag emits im-rc/unicode-ident/unicode-properties/ureq directly; duplicate corpus_lex.rs/inert_carrier_project.rs HAND[] entries cleaned.

No code changes required. Awaiting CI green; merge held for #5978 per manager lane.

— sent from proud-cat-249

@gunbai-bot

gunbai-bot Bot commented Jun 30, 2026

Copy link
Copy Markdown
Contributor Author

Verified cursor/composer-2.5 APPROVE review 33459 on HEAD 814de5638e — Findings: none confirmed:

  • Zero module_path_index:: references remain (grep clean); file deleted, behavior in cli_run.rs.
  • Witness-layer-roots reader still tokenize+parse of dsl/gunbc/ci_layer_roots.dag with fail-closed panics; synthetic/live tests in cli_run::module_path_index_tests.
  • HAND[] shrink receipted: module_path_index.rs out of regen/lib/emit/bootstrap; seed burn-down base: dedup HAND[] roster + dissolve patch_cargo_toml #5978-base duplicate corpus_lex/inert_carrier entries cleaned; patch_cargo_toml_for_generated_crate dissolved via direct emit_cargo_toml deps.

No code changes required. CI still pending; merge held for #5978 per manager lane.

— sent from proud-cat-249

@gunbai-bot

gunbai-bot Bot commented Jun 30, 2026

Copy link
Copy Markdown
Contributor Author

CI investigation for rust_tests failure (run 28412067914 @ 814de5638e):

Root cause: transient fleet infra, not a code defect. The rust gate failed during cargo clippy --all-targets inside rust_gates_ci.dag with repeated sccache: caused by: cannot find binary path while compiling v1-compiler bins — exit before nextest completed.

Local verification on same HEAD: cargo fmt --check, cargo clippy --all-targets -D warnings, and cargo nextest run --build-jobs 1 -p v1-compiler-tests all green (838/838 passed).

Pushed empty retrigger commit. No code changes required for module_path_index delete-sweep.

— sent from proud-cat-249

@gunbai-bot

gunbai-bot Bot commented Jun 30, 2026

Copy link
Copy Markdown
Contributor Author

Verified cursor/composer-2.5 APPROVE review 33511 on HEAD db22621a40 — Findings: none confirmed:

  • module_path_index.rs deleted; HAND[] 24→23; witness-layer-root reader + index helpers folded into cli_run.rs; all call sites repointed.
  • Authority derivation from dsl/gunbc/ci_layer_roots.dag preserved (tokenize+parse, fail-closed panics, synthetic/live tests in cli_run::module_path_index_tests).
  • seed burn-down base: dedup HAND[] roster + dissolve patch_cargo_toml #5978-base carryover: four Cargo deps in emit_cargo_toml, patch_cargo_toml_for_generated_crate removed.

No code changes required for this review.

CI note: retrigger run 28414417901 rust_tests failed again — nextest compile of v1-compiler (lib) via sccache exit 254 on fleet runner (infra), not a rustc diagnostic in our diff. Local fmt/clippy/nextest green with RUSTFLAGS=-D warnings.

— sent from proud-cat-249

briansrls added a commit that referenced this pull request Jun 30, 2026
…_apply (#5983)

* WIP: HAND workflow F: cli_run.rs dissolve to workflow host-effect apply()

* WIP: HAND workflow F: cli_run.rs dissolve to workflow host-effect apply()

* WIP: HAND workflow F: cli_run.rs dissolve to workflow host-effect apply()

* WIP: HAND workflow F: cli_run.rs dissolve to workflow host-effect apply()

* Defer cli_run bridge until #5993 lands (parent hold).

Keep model-only slice: floor_diff_observe.dag + floor witness on host_effect_apply.
The cli_run.rs eval bridge reverts to main; lands in a follow-on PR after #5993.

Co-authored-by: Cursor <cursoragent@cursor.com>

* Route floor git-diff shell through serialize_bash with on-carrier scaffold.

Addresses HAND-SHELL GATE: replace concat-built script literals with
ShellProgram emission (peer transport pattern), add cli_run bridge
Disposition marker, and extend witness to assert structured serialization.

Co-authored-by: Cursor <cursoragent@cursor.com>

* Roster floor_diff_observe on realization-vocabulary exception list.

Workflow transport imports bash.program via serialize_bash like peer
ingest transports; unrostered import tripped realization_vocab_clean_tree_holds in CI.

Co-authored-by: Cursor <cursoragent@cursor.com>

* Express floor diff bash tests and range via grammar, not Raw/RawLine.

Replace floor_test_string_eq RawLine concat and merge-base Raw word with
Command/Concat ShellWord rows so serialize_bash owns quoting rules.

Co-authored-by: Cursor <cursoragent@cursor.com>

---------

Co-authored-by: Brian Searls <briansearls1@gmail.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
@gunbai-bot

gunbai-bot Bot commented Jun 30, 2026

Copy link
Copy Markdown
Contributor Author

Verified claude/claude-opus-4-7 APPROVE review 33530 on HEAD 9232a69810 — Findings: none confirmed:

  • module_path_index.rs deleted; functions + 6 discriminating tests live in cli_run.rs; census_corpus_roots_follow_layer_authority dispatch still routes through crate::cli_run::* in v1_interpreter.rs.
  • Call sites consistently retargeted (extdeps_shape_transport_policy_project, corpus_lex, doc_reachability_project, fact_cardinality_census, etc.); zero crate::module_path_index::* or pub mod module_path_index remain (only a docs inventory row).
  • Rosters in lockstep: HAND_MAINTAINED_STAGE0_FILES (23 files, no module_path_index.rs), hand_maintained_mods in 05_emit_rust.dag / v1_compiler_emit_rust.rs, bootstrap copy/exclude lists, and lib.rs mod decls all omit the retired file.
  • No .dag substrate or unit-modeling surface touched by this delete-sweep.

No code changes required for this review. Post-merge sync with origin/main (#5978 burn-down base + #5980 lens coverage) already on branch; rust_tests green on run 28415418414, ci floor job still running.

— sent from proud-cat-249

@gunbai-bot

gunbai-bot Bot commented Jun 30, 2026

Copy link
Copy Markdown
Contributor Author

Verified cursor/composer-2.5 APPROVE review 33601 on HEAD 064d6f54aa — Findings: none confirmed:

  • module_path_index.rs deleted; logic folded into cli_run.rs (witness_layer_roots_from_source, build_module_path_index_from_witness_roots, source_path_for_module_path, qualified_name_value_to_module_path, census_corpus_roots_follow_layer_authority); 6 discriminating tests in cli_run::module_path_index_tests.
  • HAND_MAINTAINED roster + emit hand_maintained_mods + bootstrap lists + lib.rs all omit module_path_index.rs; post-rebase roster includes main's v1_compiler_dag_collect/_support mod decls without reintroducing the retired file.
  • All call sites use crate::cli_run::*; zero crate::module_path_index references (only a docs inventory row in seed-shrink-census.md).
  • Net −39 LOC (225 insertions, 264 deletions); fail-closed parse-based authority + synthetic/live witnesses preserved.

No code changes required for this review. CI retrigger run 28439564084 pending on 064d6f54aa.

— sent from proud-cat-249

@gunbai-bot

gunbai-bot Bot commented Jun 30, 2026

Copy link
Copy Markdown
Contributor Author

Verified claude/claude-opus-4-7 APPROVE review 33603 on HEAD 064d6f54aa — Findings: none confirmed:

  • module_path_index.rs dissolved into cli_run.rs beside existing workspace_root/build_module_path_index; ExprData/LiteralValue in scope (imports at lines 9, 27).
  • 20+ call sites mechanically retargeted to crate::cli_run::*; zero crate::module_path_index references (only docs inventory row).
  • Emit hand_maintained_mods, regen_stage0 HAND[], and bootstrap exclusion lists updated in lockstep (no module_path_index.rs; includes main's v1_compiler_dag_collect/_support post-rebase).
  • Tests preserved verbatim in cli_run::module_path_index_tests (witness-layer-root parse, synthetic authority, live authority, index lookup).

No code changes required for this review. CI run 28439564084 still pending on 064d6f54aa.

— sent from proud-cat-249

@gunbai-bot

gunbai-bot Bot commented Jun 30, 2026

Copy link
Copy Markdown
Contributor Author

Verified cursor/composer-2.5 APPROVE review 33627 on HEAD a8632e04a4 — Findings: none confirmed:

  • module_path_index.rs deleted from HAND_MAINTAINED roster; logic consolidated into cli_run.rs beside existing build_module_path_index/workspace_root; all call sites retargeted to crate::cli_run::*.
  • Discriminating witnesses preserved: witness_layer_roots_from_source (parse-based, fail-closed), census_corpus_roots_follow_layer_authority dispatch, 6 tests in cli_run::module_path_index_tests.
  • Net −39 LOC (225 insertions, 264 deletions); zero crate::module_path_index references (only docs inventory row).
  • Post-rebase emit roster includes main's v1_compiler_dag_collect/_support without reintroducing the retired file.

No code changes required for this review. rust_tests green on run 28441847282; ci floor job pending on a8632e04a4.

— sent from proud-cat-249

@gunbai-bot

gunbai-bot Bot commented Jun 30, 2026

Copy link
Copy Markdown
Contributor Author

Verified claude/claude-opus-4-7 APPROVE review 33628 on HEAD a8632e04a4 — Findings: none confirmed:

  • module_path_index.rs consolidated into cli_run.rs beside existing build_module_path_index/workspace_root; call sites updated (corpus_lex, doc_reachability_project, extdeps_shape_transport_policy_project, lib.rs, regen_stage0.rs, 05_emit_rust.dag).
  • witness_layer_roots_from_source reads single authority dsl/gunbc/ci_layer_roots.dag via real front-end parse with fail-closed panics; discriminating tests preserved in cli_run::module_path_index_tests.
  • Zero crate::module_path_index references (only docs inventory row); no substrate or unit-modeling surface touched.

No code changes required for this review. rust_tests green on run 28441847282; ci floor job pending on a8632e04a4.

— sent from proud-cat-249

@gunbai-bot

gunbai-bot Bot commented Jun 30, 2026

Copy link
Copy Markdown
Contributor Author

Verified cursor/composer-2.5 APPROVE review 33683 on HEAD 810fb64ac6 — Findings: none confirmed:

  • module_path_index.rs deleted; logic folded into cli_run.rs (including post-merge port of qualified_name_value_from_dotted_string from Whole-tree EXTRACT for model-grounding lens: concept_decl_facts(roots), name index, layer exclusion, worklist schema #5966); all call sites use crate::cli_run::*.
  • Registry/emit/bootstrap lists updated; no pub mod module_path_index remains (only docs inventory row).
  • witness_layer_roots_from_source still reads dsl/gunbc/ci_layer_roots.dag with fail-closed parse; census_corpus_roots_follow_layer_authority + 6 tests preserved in cli_run::module_path_index_tests.
  • Net −40 LOC vs current main (255 insertions, 295 deletions); no new .dag/shell/unit-modeling surface in this delete-sweep.

No code changes required for this review. CI run 28465463538 pending on 810fb64ac6.

— sent from proud-cat-249

@gunbai-bot

gunbai-bot Bot commented Jun 30, 2026

Copy link
Copy Markdown
Contributor Author

Verified claude/claude-opus-4-7 APPROVE review 33684 on HEAD 810fb64ac6 — Findings: none confirmed:

  • module_path_index.rs dissolved into cli_run.rs (authority reader, default_source_roots, build_module_path_index_from_witness_roots, source_path_for_module_path, qualified_name_value_from_dotted_string, tests); callers repointed across corpus_lex, doc_reachability_project, extdeps_shape_transport_policy_project, fact_cardinality_census, v1_interpreter, coproduct_reflection.
  • Module dropped from lib.rs, emit hand_maintained_mods literals, regen_stage0 HAND[] roster, and bootstrap copy/exclude lists — all clean (no module_path_index references).
  • ExprData/LiteralValue in scope (lines 9, 27); fail-closed parse + synthetic discrimination witness preserved in cli_run::module_path_index_tests.

No code changes required for this review. CI run 28465463538 pending on 810fb64ac6.

— sent from proud-cat-249

@gunbai-bot

gunbai-bot Bot commented Jun 30, 2026

Copy link
Copy Markdown
Contributor Author

Verified claude/claude-opus-4-7 APPROVE review 33689 on HEAD 5cf8857332 — Findings: none confirmed:

No further code changes required for this review. CI run 28466270055 pending on 5cf8857332.

— sent from proud-cat-249

@gunbai-bot

gunbai-bot Bot commented Jun 30, 2026

Copy link
Copy Markdown
Contributor Author

Verified cursor/composer-2.5 APPROVE review 33690 on HEAD 5cf8857332 — Findings: none confirmed:

  • module_path_index.rs removed from HAND[] roster, lib.rs, emit hand_maintained_mods, and bootstrap lists; logic consolidated into cli_run.rs.
  • witness_layer_roots_from_source still projects from dsl/gunbc/ci_layer_roots.dag via tokenize+parse with fail-closed panics; 6 discriminating tests intact in cli_run::module_path_index_tests (lines ~5165–5224).
  • All callers retargeted to crate::cli_run::*; zero module_path_index:: references (only docs inventory row). Net −38 LOC vs current main (257 insertions, 295 deletions).
  • Post-review fmt fix already on HEAD: 5cf8857332 (coproduct_reflection line wrap).

No code changes required for this review. CI run 28466270055 pending on 5cf8857332.

— sent from proud-cat-249

@gunbai-bot

gunbai-bot Bot commented Jun 30, 2026

Copy link
Copy Markdown
Contributor Author

Verified cursor/composer-2.5 APPROVE review 33697 on HEAD 5cf8857332 — Findings: none confirmed:

  • module_path_index.rs deleted; logic + 6 tests in cli_run.rs; all crate::module_path_index::* call sites retargeted; HAND[]/bootstrap/emit lists updated consistently.
  • Single-authority witness_layer_roots_from_source projection from dsl/gunbc/ci_layer_roots.dag preserved with fail-closed panics; census_corpus_roots_follow_layer_authority still wired via interpreter builtin.
  • Net −38 LOC (257 insertions, 295 deletions); zero stale module references (only docs inventory row).

No code changes required for this review. rust_tests green on run 28466270055; ci floor job pending on 5cf8857332.

— sent from proud-cat-249

@gunbai-bot

gunbai-bot Bot commented Jun 30, 2026

Copy link
Copy Markdown
Contributor Author

Verified claude/claude-opus-4-7 APPROVE review 33698 on HEAD 5cf8857332 — Findings: none confirmed:

  • module_path_index.rs re-homed into cli_run.rs; HAND[]/emit roster trimmed; net −38 LOC (257 insertions, 295 deletions).
  • Callers updated: coproduct_reflection, corpus_lex, doc_reachability_project, extdeps_shape_transport_policy_project, import_resolution_project (all crate::cli_run::*).
  • Single-authority witness_layer_roots_from_source reader preserved with fail-closed panics + synthetic-roots discriminator in cli_run::module_path_index_tests; zero stale module_path_index references.

No code changes required for this review. rust_tests green on run 28466270055; ci floor job pending on 5cf8857332.

— sent from proud-cat-249

Retire module_path_index.rs by moving witness-layer authority reading,
corpus lex helpers, and module-path index call sites into cli_run.rs
alongside the #5979 layering/import facts. Update stage0 rosters and
retarget census consumers to crate::cli_run.

Co-authored-by: Cursor <cursoragent@cursor.com>
@briansrls
briansrls force-pushed the session/proud-cat-249 branch from 1f99709 to 3341515 Compare June 30, 2026 19:26
Restore super:: imports for default_source_roots and
witness_discovery_scan_dirs after module_path_index fold broke test compilation.

Co-authored-by: Cursor <cursoragent@cursor.com>
@gunbai-bot

gunbai-bot Bot commented Jun 30, 2026

Copy link
Copy Markdown
Contributor Author

Verified cursor/composer-2.5 APPROVE review 33733 on HEAD fc0cea935f — Findings: none confirmed:

  • module_path_index.rs deleted; witness authority + corpus lex + module-path helpers consolidated into cli_run.rs beside existing build_module_path_index(source_roots).
  • Single-authority string_list_data_from_ci_layer_roots_source / witness_layer_roots_from_source / witness_discovery_scan_dirs projection from dsl/gunbc/ci_layer_roots.dag preserved with fail-closed panics; 11 discriminating tests in cli_run::module_path_index_tests.
  • All callers retargeted to crate::cli_run::*; zero crate::module_path_index:: references in src/ (only docs inventory row). HAND[] / lib.rs / emit roster / bootstrap excludes updated consistently.
  • Post-squash fix fc0cea935f: restored default_source_roots + witness_discovery_scan_dirs imports in inert_lens_hygiene_tests (test compile regression from the fold).

No code changes required for this review. rust_tests green on run 28470826507 @ fc0cea935f; ci floor job in progress.

— sent from proud-cat-249

@gunbai-bot

gunbai-bot Bot commented Jun 30, 2026

Copy link
Copy Markdown
Contributor Author

Verified claude/claude-opus-4-7 APPROVE review 33735 on HEAD fc0cea935f — Findings: none confirmed:

  • Mechanical delete-sweep: module_path_index.rs removed; contents folded into cli_run.rs; lib.rs, regen_stage0.rs, 05_emit_rust.dag hand-maintained string, and bootstrap copy/exclude lists updated.
  • Previous no-arg build_module_path_index() renamed to build_module_path_index_from_witness_roots(); all five call sites in extdeps_shape_transport_policy_project.rs updated; parameterized build_module_path_index(&roots) retained for layering/import facts.
  • crate::module_path_index::* refs repointed to crate::cli_run::* in coproduct_reflection, doc_reachability_project, extdeps_shape_transport_policy_project, fact_cardinality_census, inert_carrier_project, non_fold_residue_project, and v1_interpreter builtins — no behavior change observed.

No code changes required for this review. rust_tests green on run 28470826507 @ fc0cea935f; ci floor job in progress.

— sent from proud-cat-249

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant