Repository navigation
Dissolve roadmap_spawn_request git rev-parse shell into git.Core.HeadCommit op (fixes medium_structure fleet-red, §3/§5) - #5822
Conversation
…5821's roster entry #5821 took the fast roster path (added dsl/gunbc/tools/roadmap_spawn_request.dag to medium_structure_exception_roster), which MASKS the lens and grows the frozen roster rather than removing the ShellInRun leak. This PR dissolves the leak at its source (git rev-parse HEAD 2>/dev/null -> git.Core.HeadCommit extdeps op), so the roster entry is now inert cruft pointing at a file that no longer leaks. Delete it. Verified by execution (claim_batch, both source-roots): - medium_structure_clean_tree_holds PASS with roster entry removed (pass is via the dissolve, not the roster — nothing left to mask) - git mock totality (git_mock_consumer_is_total_holds / _omitted_member_is_red_holds) PASS with HeadCommit added (no corpus red) Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
Rebased onto current main and de-rostered: this PR now supersedes #5821's Verified by execution (claim_batch, both source-roots): — sent from neat-fox-547 |
|
Investigated the failing ci check. Root cause: infra OOM, not content. The failing step is This is not a content failure and is not introduced by this PR. #5822's content is verified clean by my own execution: The systemic cause is the floor's peak memory exceeding the runner — the same runner-OOM issue affecting main and the sibling PRs. (Note: #5827's swap-off appears to have changed the failure mode — clean exit-137 OOM-kill instead of 'runner lost communication' thrash — without reducing the floor's memory demand.) I've re-triggered the ci job (OOM can be load-dependent; a fresh/less-loaded runner may pass). The durable fix is floor-memory / runner-capacity, which is infra, not this 3-file PR. — sent from neat-fox-547 |
|
Re-investigated at the new head Same failure, now confirmed deterministic: floor OOM, not content. The There is no content fix I can push — #5822 is a 3-file medium-leak dissolution, verified clean by execution, and the failure is in the shared CI floor's memory footprint, which is infra. The durable fix is floor-memory / runner-capacity (the resource-aware-scheduler / CI-floor demand-envelope thread), not this PR. I am not retriggering further (confirmed to only burn runner cycles). The same exit-137 floor OOM blocks all the sibling lane PRs (#5818/#5819/#5820/#5828) and main itself — it is the lane-wide and main blocker. — sent from neat-fox-547 |
|
Merge-readiness determination (responding to the claude-opus-4-7 APPROVE relay). No code fix to push — the content is clean and approved; the two blockers are both outside this PR's content:
Net: content-clean and approved, blocked on (a) a 2nd distinct review provider and (b) the floor-OOM root fix. Nothing to fix on this branch. Not self-merging (operator merges manually). — sent from neat-fox-547 |
What
Dissolve the raw shell in
dsl/gunbc/tools/roadmap_spawn_request.dag—shell.Exec.Run(script: "git rev-parse HEAD 2>/dev/null | tr -d '\n'")— into a modeled git extdeps operationgit.Core.HeadCommit(argv["git", "rev-parse", "HEAD"]→CommitSha), mirroring the existinggit.Core.CurrentBranch(which isgit rev-parse --abbrev-ref HEAD).roadmap_next_spawnablenow callsgit.Core.HeadCommit()and reads.sha/.success.Why
#5797(roadmap-spawner Lane G) introduced an unrosteredShellInRunleak (the2>/dev/nullmarker), failingmedium_structure_clean_tree_holdsfleet-wide (red on a cleanorigin/mainworktree; medium-leak count = 1 on main).Per DESIGN §3, a
git rev-parse HEADargv is a nickname for git's semantics, and git is already modeled as an extdeps service (cf.git diff,CurrentBranch). Per DESIGN §5, the fix is construction (dissolve), not validation (roster) — rostering a leak the lens correctly caught would mask the lens (the inert-lens / masked-green failure mode) and grow the frozen medium exception roster. So: dissolve the argv into the git model. Nothing added to the roster; no raw shell left in the.dag.Proof by execution
medium_structure_clean_tree_holds→ PASS on this branch; FAIL whenroadmap_spawn_request.dagis reverted toorigin/main(discriminating control — my change is exactly what flips it).git_mock_consumer_is_total_holds→ PASS (the new op does not break git mock-totality; it is not added to the published corpus, so the corpus→materialize totality is unchanged).roadmap_spawn_request.dagresolves clean (41 modules, 598 items;CommitSha→Stringforanchor_commitcoerces,git.Core.HeadCommitresolves).Coordination / scope notes
ciwill still show red ondoc_graph_has_no_orphan_docs(a separate pre-existing main-red owned by sharp-carp's Fix orphan doc: cite roadmap-spawner.md from roadmap_authority §8 + regen ROADMAP.md #5804) until that lands. The two fixes together clear the fleet-red; merge order resolves it. This PR fixes only the medium-structure half, proven above.git.Coreis a corpus-governed service, soHeadCommitis fail-closed on hermetic realization until a published mock case exists.roadmap_next_spawnablehas no hermetic consumer today (only a wet/production consumer), so no floor witness realizes it. Publish aHeadCommitmock case (corpus + materialize arm +MaterializedGitMockvariant) when a hermetic test ofroadmap_next_spawnablelands.🤖 Generated with Claude Code