Repository navigation
compute-fabric refine: reconcile DESIGN §2 storage-anemia clause with the grounded NVMe PcieLink axis - #5779
Merged
Merged
Conversation
gunbai-bot
Bot
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DESIGN.md §2 (Deep decomposition) still claimed
product.compute_fabric'sStorageDeviceis "still-anemic today ... no PCIe-gen/lane-count axis". That was true when written but #5586 grounded it:extdeps/storage/types.dagdefinesPcieLink { generation: PcieGeneration, lane_count: Int }(cited to the PCI Express authority, per-lane bandwidth derived not stored),NvmeDeviceCatalogRowcarries it, andStorageDevice.catalogsurfaces it.This reconciles the authority (
dsl/gunbc/design_document.dag) to a done-decomposition example parallel to the LGA4926/DRAM rows, and regenerates DESIGN.md (carrier-is-authority, §6).Verification (green-by-execution, release
gunbc):storage_nvme_grounding_witness_test.dag→ all true (WD Gen4×4, Samsung Gen3×4, specs/form-factor/derive).generated_artifact_drift_witnesses→ true (committed DESIGN.md == regenerated).Whole-branch diff vs main: 2 files (DESIGN.md + design_document.dag), 1 clause each.
🤖 Generated with Claude Code