Repository navigation
ci(dissolution): collapse pure ci-claim-gate wrapper scripts into gate-3 - #5012
Merged
Merged
Conversation
…wrappers Both were pure thin wrappers that just exec'd ci-claim-gate with a fixed --gate-entry/--rows-fn. gate-3 already holds the ci-claim-gate binary, so inline the two calls directly (byte-identical invocation, --perturb-check preserved) and delete the wrapper scripts. Removes a redundant bash layer; no behavior change. scratch item 14 (CI gates are bash scripts). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
#5012 review (claude-opus-4-7, APPROVE) flagged comment/doc references to the now-deleted v4-lens-ci-gate.sh and v4-probe-selector-keystone-gate.sh (and the earlier node-frontier wrapper deleted in #5011). Their rows-fns are now invoked directly from gate-3 (scripts/v4-affected-tests-gate.sh); repoint all references there. Comment/doc-only, no behavior change. Touched: ROADMAP.md, docs/design-lens-subject-supply.md, tools/ci_claim_gate/src/main.rs, src/v2/stage0/src/bin/claim_batch.rs, .github/ci-floor/claim-witness-corpus-exclusions.md. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
3 tasks done
Closed
6 tasks
briansrls
added a commit
that referenced
this pull request
Jun 16, 2026
Rebase onto main (#5012 ci-claim-gate dissolution) dropped the v4-spice-ngspice-op-gate.sh hook from v4-affected-tests-gate.sh. Co-authored-by: Cursor <cursoragent@cursor.com>
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Second gate-dissolution slice (scratch item 14; follows #5011).
The probe-selector-keystone and lens-ci gate scripts were pure thin wrappers that just
exec'dci-claim-gatewith a fixed--gate-entry/--rows-fn. gate-3 (v4-affected-tests-gate.sh) already holds theci-claim-gatebinary, so this inlines the two calls directly (byte-identical invocation,--perturb-checkpreserved) and deletes both wrapper scripts. No behavior change — a redundant bash layer removed.After this, all the pure wrapper/scraper collapses are done (node-frontier in #5011, these two here). The remaining gate scripts (batch-executor, substrate-equivalence, corpus shards, layering, nat-semiring) each orchestrate real behavior in bash (batch run-loops, discovery-law equivalence, ExpectFail corpus sharding, import-edge layering) and need genuine
.dagmodeling rather than mechanical collapse — separate slices.🤖 Generated with Claude Code