Repository navigation
Delete hand-maintained filename/test-row list+count enumerations across the tree; replace with reflection-based discovery (corpus/affected/probe/lens gate runners, parse_allowlist, shell file-arrays). Reflection was supposed to handle this. - #5005
Merged
Merged
Conversation
This was referenced Jun 15, 2026
briansrls
added a commit
that referenced
this pull request
Jun 15, 2026
Co-authored-by: Cursor <cursoragent@cursor.com> # Conflicts: # src/v4/test/claim/workflow/claim_witness_corpus_ci_runner.dag
briansrls
added a commit
that referenced
this pull request
Jun 15, 2026
Drop hand-maintained master list + row_count datums (reflection gate per Co-authored-by: Cursor <cursoragent@cursor.com> #5005); retain M1a program_runs row on shard b only.
This was referenced Jun 15, 2026
SP-M1: composed RC circuit -> ngspice netlist that simulates (emit + fixture + ngspice oracle)
#4989
Merged
briansrls
added a commit
that referenced
this pull request
Jun 15, 2026
Rebase onto #5005 left conflict markers in shard_b enrollment; remove them and keep reflection-based discovery (row defs + shard_b only). Co-authored-by: Cursor <cursoragent@cursor.com>
briansrls
added a commit
that referenced
this pull request
Jun 15, 2026
Resolve claim_witness_corpus_ci_runner.dag under #5005: keep SP-M2 dual-emission + wave-1 row defs and shard_b enrollment; drop retired monolithic list and hand-maintained row-count strings. Co-authored-by: Cursor <cursoragent@cursor.com>
This was referenced Jun 15, 2026
briansrls
added a commit
that referenced
this pull request
Jun 15, 2026
Keep #5005 shard_b-only enrollment: union main self_host_stage_emission_equality rows with SP-M1 spice witness rows; no master-list/_row_count ledger. Co-authored-by: Cursor <cursoragent@cursor.com>
briansrls
added a commit
that referenced
this pull request
Jun 15, 2026
#5005 shard_b-only: union main self_host rows with corpus_ci_gate_row_spice_resistor_round_trip enrollment. Co-authored-by: Cursor <cursoragent@cursor.com>
briansrls
added a commit
that referenced
this pull request
Jun 16, 2026
Rebase onto #5005 left conflict markers in shard_b enrollment; remove them and keep reflection-based discovery (row defs + shard_b only). Co-authored-by: Cursor <cursoragent@cursor.com>
briansrls
added a commit
that referenced
this pull request
Jun 16, 2026
Rebase onto #5005 left conflict markers in shard_b enrollment; remove them and keep reflection-based discovery (row defs + shard_b only). Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this does (reflection / single-authority cleanup — item-8 of the modeling-smell audit)
Dissolves the hand-maintained list+count parallel ledgers in the CI gate runners. These are
.dag-native deletions only — no shell, no new capability.Deleted (zero readers, verified):
claim_witness_corpus_claim_run_row_count/shard_a_row_count/shard_b_row_count(corpus runner)ci_runner_node_frontier_claim_run_row_count(affected_set runner)affected_testgen_claim_run_row_count(affected_testgen runner)claim_witness_corpus_claim_run_rows— the unconsumed, stale-by-one "all 54" aggregate (the gate reads the shard lists, never this; chore(ci): retire redundant *_row_count cross-checks (merge-skew liability) #4959 retired its cross-check). Real count was 55; the datum still said "54".These are the
*_row_countdatums #4959's commit message described removing but whose diff only touched the shell scripts — they were left dangling and unconsumed. The gates fold the typed shardListdirectly, so a dropped row simply isn't enrolled; a parallel count datum can't detect that and only drifts under concurrent merges. Teeth retained: per-row pass + perturb-RED + ExpectFail-drift + empty-roster fail-closed guards are untouched.Also (unblock):
dsl/std/compute_fabric.dag:541declareddata operator_fleet_runner_slot_total: Int =with the RHS on the next line; the parser rejects=-then-newline, failing closed on every gate that resolves adsl/closure (corpus/lens gates) on all PRs. Single-lined it. (Parent's #4960 deletes this dead datum + moves the file todsl/product/compute_fabric.dag; whichever lands first heals main, delete wins on the trivial conflict.)Verification
gunbc compile --source-root src/v4 --target dag→ exit 0 (whole-tree v4 parse)..dag/.sh/.rs/.yml.scripts/v4-claim-witness-corpus-gate.sh --shard blocally →GATE EXIT 0, 35 rows matched (34 ExpectPass, 1 ExpectFail).Deliberately NOT in this PR (scoped follow-on)
The operator asked to also delete the individual
corpus_ci_gate_row_*enrollment rows and let reflection discover them. Ground-truthdiscover_owned_datacoverage proof: 34/54 are discoverable, 20 are NOT (9dsl/test/claim/*rows are outside the discoverer'ssrc/v4/test/claimscan-dir; 11src/v4rows — 7 timeseries, mvp1-emit-matches-serialize, sg2-fold-row-delimiter, ts_effect_io_emit, spice — are registered in theTestClaim = BoolWitnessClaim { witness: BoolWitness { holds: fn() } }shape the discoverer's transport projection doesn't capture). Deleting those 20 would silently drop coverage (fabricated-green), which the fail-closed bar forbids. Safely deleting the rows requires: extend discovery scan todsl/, make the 11src/v4witnesses discoverable, handle the 1 ExpectFail residual (#4801), and rewire the gate's enrollment to the discovery manifest. Tracked as the discovery-rewire follow-on.