Skip to content

v2 bootstrap: fold_list generic callback instantiation (R2 §4a) - #4735

Merged
briansrls merged 5 commits into
mainfrom
session/swift-deer-774
Jun 12, 2026
Merged

briansrls merged 5 commits into
mainfrom
session/swift-deer-774

Conversation

@briansrls

@briansrls briansrls commented Jun 12, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • Confirms v2 R2 minimal generic instantiation already binds T from xs: FreeMonoid<T> into fold_list/fold_list_right cons|snoc callback lambda params (field access and arithmetic type-check at the call site).
  • Adds execution-verified regression tests: inline v2 unit tests, a v4 manual claim cert (fold_list_generic_instantiation.dag), and a compile smoke for 03_name_resolve.dag.
  • Dissolves two of the three hand-rolled Empty/Cons fold bypasses in 03_name_resolve.dag (module_root_name_find_fold, admit_imports) onto canonical fold_list; the remaining node folds retain hand-rolled match due to early Rejected short-circuit semantics.

Test plan

  • cargo test -p v2-compiler-tests fold_list — 4 tests pass (inline + v4 cert + name_resolve compile)
  • cargo fmt --all --check — clean
  • CI (fmt + ci_floor + v4_lens_gate)

@briansrls briansrls changed the title v2 bootstrap: generic lambda-param instantiation from call-site type — dissolves the 3-instance fold-consumer gap class (design ruling tidy-stag-172, dep-graph-2026-06-12 §4a). Extend v2 R2 minimal generic instantiation so: (a) fold_list/fold_list_right cons|snoc callbacks bind T from xs: FreeMonoid v2 bootstrap: fold_list generic callback instantiation (R2 §4a) Jun 12, 2026
@briansrls
briansrls marked this pull request as ready for review June 12, 2026 07:07
Dashboard was pinned to failing SHA 29210c4 (fmt drift in fn_as_value_test.rs).
HEAD already green; empty commit re-triggers CI gate evaluation.

Co-authored-by: Cursor <cursoragent@cursor.com>
@briansrls

Copy link
Copy Markdown
Contributor Author

Reviewed both dashboard artifacts on HEAD 1ea05ca8d6:

  • cursor/composer-2.5 (28642): Findings none — APPROVE
  • claude/claude-opus-4-7 (28643): APPROVE (no blocking concerns)

No code changes required. The two dissolved fold_list sites and retained hand-rolled folds match the reviewer's reading; test coverage (inline v2 + v4 witness + 03_name_resolve compile receipt) is in place.

Merge readiness: 2/2 distinct approvals, 0 REQUEST_CHANGES, mergeable=CLEAN, CI green on 1ea05ca8d6. Handing off for operator merge.

— sent from swift-deer-774

@briansrls

Copy link
Copy Markdown
Contributor Author

claude/claude-opus-4-7 review #28643 — verified on HEAD 1ea05ca8d6, no code change needed.

The cited dissolution sites match current code:

  • module_root_name_find_fold → fold_list at 03_name_resolve.dag:176 (was hand-rolled Empty/Cons; 🟡 gate removed)
  • admit_imports → fold_list at 03_name_resolve.dag:433 (same)
  • Remaining hand-rolled node folds (module_root_validate_fold, module_root_for_name_fold) intentionally kept — early Rejected short-circuit is not expressible as naive fold_list.

Test receipts cited in the review are present and green:

  • fn_as_value_test.rs (inline compile+interpret)
  • fold_list_generic_instantiation_test.rs + fold_list_generic_instantiation.dag (v4 witness)
  • 03_name_resolve.dag compile smoke

Merge readiness unchanged: 2/2 approvals (claude + cursor), 0 REQUEST_CHANGES, mergeable=CLEAN, CI green.

— sent from swift-deer-774

@briansrls
briansrls merged commit af4530c into main Jun 12, 2026
12 checks passed
@briansrls
briansrls deleted the session/swift-deer-774 branch June 12, 2026 15:03
briansrls pushed a commit that referenced this pull request Jun 12, 2026
Record snappy-crab bisect (true at #4735, false at #4737) and manual-claim
CI gate meta-finding for ctrl graph amendment.

Co-authored-by: Cursor <cursoragent@cursor.com>
briansrls added a commit that referenced this pull request Jun 12, 2026
…t descriptor) (#4742)

* WIP: Mgr-§3 (composite): emit breadth DEEP lane per dep-graph §3 + operator f

* design: §3 emit breadth DEEP lane — execution census + breadth ladder

Revise PRE-ROUND-TRIP design per snappy-crab authoritative brief: claim-run
witness results, one-row-per-form invalidation, Rust-through-descriptor plan
(T-22 dissolve), and §5 migration-only census drain ordering.

Co-authored-by: Cursor <cursoragent@cursor.com>

* design: bake ctrl#1563 day-1 tripwires into §3 DEEP lane plan

Record sharp-fox ruling: §3-DEEP/§4-THIN standing decision, GO owned by
sharp-fox on fan-in (iii); §1-regression and #4623 hand-list tripwires.

Co-authored-by: Cursor <cursoragent@cursor.com>

* design: classify L0 producer-rooted path as red-baseline per triage

Snappy-crab bisect: comprep_eval false pre-#4738; not eval-dispatch regression.

Co-authored-by: Cursor <cursoragent@cursor.com>

* design: revise eval keystone classification to today-wave regression

Snappy-crab final triage: comprep_eval green at f382a16, red from
bcff2ef; not known-false ledger. TS bodied-emit reds unchanged.

Co-authored-by: Cursor <cursoragent@cursor.com>

* WIP: Mgr-§3 (composite): emit breadth DEEP lane per dep-graph §3 + operator f

* design: bisect final — #4737 culprit for eval keystone witness red

Record snappy-crab bisect (true at #4735, false at #4737) and manual-claim
CI gate meta-finding for ctrl graph amendment.

Co-authored-by: Cursor <cursoragent@cursor.com>

* design: add emit CLI façade + plan_checks north-star to §3 scope

Operator pivot: ctrl TS build depends on gunbc emit; stable CLI contract
and plan_checks.dag breadth-driver slot (census pending).

Co-authored-by: Cursor <cursoragent@cursor.com>

* WIP: Mgr-§3 (composite): emit breadth DEEP lane per dep-graph §3 + operator f

---------

Co-authored-by: Brian Searls <briansearls1@gmail.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant