Repository navigation
Glob-discovery Phase 3-5: prove discovery==roster, repoint consumers, delete v4_roster_pilot - #4632
Conversation
- Pin independent Symbol transport authority for field-preservation laws (edit_locus_narrow_resolution_holds_symbol), not tautological self-compare. - Fix claims_root contract in v4-glob-discovery-project.sh (no source-root suffix) so impossible_bug perturb scans the correct tree. - Wire scripts/v4-glob-discovery-project.sh into testclaim corpus affected-set. Co-authored-by: Cursor <cursoragent@cursor.com>
59c1550 to
67242da
Compare
|
Rebased Conflict resolution: dropped replay of pre-merge history; branch is now Additional fix: Marked ready for review; CI re-running. — sent from bold-moth-447 |
composer-2.5 REQUEST_CHANGES — fixed in
|
|
Correction: marker regression fix is commit |
Review verification @
|
briansrls
left a comment
There was a problem hiding this comment.
Review metadata
- Provider / model:
codex/unknown - Commit:
2de2ee2a· Trigger:schedule - Thinking:
294s wall
BLOCKING (1)
Root Cause
scripts/v4-substrate-equivalence-gate.shprojection gate validates only row count plus one modeled sample → add a mechanical TSV set-equality receipt against the pre-delete roster rows or an immutable generated roster snapshot before treating glob discovery as the roster replacement.
| glob_discovered_smoke_marker_count, | ||
| glob_discovery_smoke_marker_count_is_positive | ||
| } | ||
| // Independent transport authority for the sample marker (not read back from extraction). |
There was a problem hiding this comment.
BLOCKING: This makes the equivalence proof a single sample-marker oracle, so it still cannot prove the discovered BoolWitness set equals the roster rows required by test-claim-consolidation design §6.2 C9 / INVARIANTS P2; a dropped row plus an added row can pass the count and sample checks.
Blocking review @ inline + codex — addressedFinding valid. The modeled witness alone (count pin + single sample marker) could not prove C9 set equivalence. Fix:
The +1 discovery-only row (
— sent from bold-moth-447 |
Auto-opened by session-dashboard for session
bold-moth-447.Pushing to
session/bold-moth-447advances this PR.Worker attestation
Before flipping this PR to ready for review, confirm each item:
npm test,cargo test) and the result.Closes #Ndirective.Summary
TODO: replace this paragraph with one or two sentences naming the change and its motivation. Reviewers read this first.
Test plan