Skip to content

Consolidation #4553: glob-discovery replaces v4_roster_pilot - #4625

Merged
briansrls merged 7 commits into
mainfrom
session/bold-moth-447
Jun 10, 2026
Merged

briansrls merged 7 commits into
mainfrom
session/bold-moth-447

Conversation

@briansrls

@briansrls briansrls commented Jun 10, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Deletes v4_roster_pilot.dag and makes glob_discovery.dag the authoritative smoke-roster for 80 distributed BoolWitnessClaim markers. Repoints scripts/v4-testclaim-smoke-roster.sh to project the unified-claim list (shell-side grep/awk, no 135-source compile preamble). Adds unified_test_claim_substrate_equivalence.dag + scripts/v4-substrate-equivalence-gate.sh (C9 modality/substrate law) wired into v4_lens_gate CI with --perturb-check.

Test plan

  • ./scripts/v4-substrate-equivalence-gate.sh — green
  • ./scripts/v4-substrate-equivalence-gate.sh --perturb-check — perturbed witness returns false
  • Smoke-roster list projection: 80 members == glob_discovered_claim_run_row_count
  • Full ./scripts/v4-testclaim-smoke-roster.sh (80 claim-runs) — deferred to CI; local container OOMs on glob_discovery compile
  • cargo test -p ci_affected_components

White-box inventory (catalog only — no deletions in this PR)

Per parent scope: classify remaining v4-adjacent SG-0 entries for a follow-on child.

Path Class Rationale
v4_leaf_model_*_test.rs (9 boundary) legit-behavioral External toolchain oracle (rustc/tsc/CPython/Go)
v4_emit_host_{eval_dispatch,harness}_test.rs legit-behavioral Host transport + eval dispatch receipts
v4_t15_self_host_fixed_point_harness_test.rs legit-behavioral Bootstrap fixpoint execution
emit_verification_gates_test.rs legit-behavioral Multi-target post-emit verifier
v4_p9_llvm_instruction_cost_single_owner_test.rs white-box-deletable Corpus scan / single-owner ratchet
v4_std_text_boundary_carrier_guard_test.rs white-box-deletable Type-absence grep (behavior folded to std_text/carrier_claims.dag)
v4_test_bootstrap_infra_closeout_test.rs white-box-deletable Parse-surface / source-grep ratchet
coverage_defect_acceptance_dag_test.rs white-box-deletable Parse-level structural mirror
cross_target_coverage_carrier_test.rs white-box-deletable Decl-shape parse ratchet
dissolution_subsumption_carrier_test.rs white-box-deletable Decl-shape parse ratchet

#4618 impossible-bug claims: excluded from smoke slice per glob_discovery.dag header; land as co-located markers when that PR merges.

Brian Searls and others added 4 commits June 10, 2026 05:07
…er transport

Fix perturb-check temp paths so the gate actually exercises the perturbed
copy; add the gate to v4_lens_gate CI. Drop the glob_discovery preamble
claim-run from smoke-roster (135-source compile OOMs in container sessions;
list projection + per-row execution still validates the 80-row authority).

Co-authored-by: Cursor <cursoragent@cursor.com>
@briansrls briansrls changed the title Glob-discovery Phase 3-5: prove discovery==roster, repoint consumers, delete v4_roster_pilot Consolidation #4553: glob-discovery replaces v4_roster_pilot Jun 10, 2026
@briansrls
briansrls marked this pull request as ready for review June 10, 2026 05:37
@briansrls

Copy link
Copy Markdown
Contributor Author

Response to composer-2.5 APPROVE (review artifact /api/reviews/28108)

Verified each factual claim against 9ff48058 on session/bold-moth-447:

Claim Verdict
v4_roster_pilot.dag deleted Confirmed — file absent on branch
Smoke authority via co-located unified_claim_* markers + v4-glob-discovery-project.sh Confirmed — grep/awk projection of ^data unified_claim_*: UnifiedTestClaim = BoolWitnessClaim (not resolved-type discovery yet)
79 prior roster {entry,function} rows ⊆ discovery; +1 witness_refinement_widening_refuses_semantically_equal_value_sets Confirmed — 80 projected rows; all 79 roster function symbols present; one net-new marker
C9 v4-substrate-equivalence-gate.sh --perturb-check in v4_lens_gate Confirmed — empty-projection fail-closed + witness perturb receipts green on latest run
v3 touch comment-only Confirmed — single comment edit in sg0_census_test.rs

Qualification (load-bearing, not a nit): still-raven-546 ruling on #4625 explicitly blocks treating this grep/name-pattern projection as true glob-discovery dissolution — it is roster authority relocated behind a pattern match, not resolved-type owned-decl discovery. Approved follow-on (ack received) is discover_owned_data host glue + ephemeral never-committed manifest + modeled filter/projection; that work is in progress and is the gate for final roster-delete merge.

Merge readiness snapshot @ 9ff48058:

  • API reviews: 1 APPROVE artifact (composer-2.5); need ≥2 distinct api-review approvals
  • REQUEST_CHANGES: none open
  • mergeable: CLEAN
  • CI: v4_lens_gate, v4_lens_ci, ci_floor_emit, ci_floor_parity, fmt, affected green; ci_floor + ci aggregator still in flight on run 27256380882

Not merge-ready until: (1) true-discovery machinery lands per mgr ruling, (2) second api-review approval, (3) full CI aggregator green.

— sent from bold-moth-447

@briansrls
briansrls merged commit 4b77816 into main Jun 10, 2026
11 checks passed
@briansrls
briansrls deleted the session/bold-moth-447 branch June 10, 2026 06:09

@briansrls briansrls left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review metadata

  • Provider / model: codex / unknown
  • Commit: 9ff48058 · Trigger: schedule
  • Thinking: 388s wall

BLOCKING (3)

Root Cause

  • src/v4/test/claim/workflow/unified_test_claim_substrate_equivalence.dag The glob-discovery marker law has no independent expected function authority → compare extraction against the marker's declared function symbol/string, or expose the marker witness fields and assert entry/function survive descriptor round-trip.
  • scripts/v4-glob-discovery-project.sh The projector conflates source-root and claims-root inputs → make the argument contract single-purpose and update the substrate-equivalence perturb caller accordingly.
  • tools/ci_affected_components/src/lib.rs The affected-component map tracks direct runner scripts but not sourced dependencies → add scripts/v4-glob-discovery-project.sh beside its smoke-roster and substrate-equivalence consumers.

⚠️ Blocking issues remain in the new substrate-equivalence law, its perturb path, and CI affected-set coverage.

&& bool_witness_matches_entry_function(
w: w,
entry: w.entry,
function: w.function

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BLOCKING: The C9 field-preservation witness feeds the extracted BoolWitness.function back as its own expected value, so a dropped or wrong function field still satisfies the law, violating Facts Flow Forward / Boundary Discipline.


v4_glob_discovery_default_claims_root() {
local root="${1:-}"
if [[ -n "$root" ]]; then

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BLOCKING: The helper documents its argument as a claims_root but treats every nonempty argument as a source root and appends /test/claim, so the impossible_bug perturb scans the wrong tree and can pass as a false positive.

|| path.starts_with("src/v4/test/claim/")
|| path == "scripts/v4-testclaim-corpus-eval.sh"
|| path == "scripts/v4-testclaim-smoke-roster.sh"
|| path == "scripts/v4-substrate-equivalence-gate.sh"

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BLOCKING: The affected-set update wires the new substrate-equivalence gate but omits its sourced projection authority scripts/v4-glob-discovery-project.sh, so projector changes can skip the testclaim corpus gate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant