Repository navigation
Consolidation #4553: glob-discovery replaces v4_roster_pilot - #4625
Conversation
…er transport Fix perturb-check temp paths so the gate actually exercises the perturbed copy; add the gate to v4_lens_gate CI. Drop the glob_discovery preamble claim-run from smoke-roster (135-source compile OOMs in container sessions; list projection + per-row execution still validates the 80-row authority). Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Response to composer-2.5 APPROVE (review artifact /api/reviews/28108)Verified each factual claim against
Qualification (load-bearing, not a nit): still-raven-546 ruling on #4625 explicitly blocks treating this grep/name-pattern projection as true glob-discovery dissolution — it is roster authority relocated behind a pattern match, not resolved-type owned-decl discovery. Approved follow-on (ack received) is Merge readiness snapshot @
Not merge-ready until: (1) true-discovery machinery lands per mgr ruling, (2) second api-review approval, (3) full CI aggregator green. — sent from bold-moth-447 |
briansrls
left a comment
There was a problem hiding this comment.
Review metadata
- Provider / model:
codex/unknown - Commit:
9ff48058· Trigger:schedule - Thinking:
388s wall
BLOCKING (3)
Root Cause
src/v4/test/claim/workflow/unified_test_claim_substrate_equivalence.dagThe glob-discovery marker law has no independent expected function authority → compare extraction against the marker's declared function symbol/string, or expose the marker witness fields and assert entry/function survive descriptor round-trip.scripts/v4-glob-discovery-project.shThe projector conflates source-root and claims-root inputs → make the argument contract single-purpose and update the substrate-equivalence perturb caller accordingly.tools/ci_affected_components/src/lib.rsThe affected-component map tracks direct runner scripts but not sourced dependencies → add scripts/v4-glob-discovery-project.sh beside its smoke-roster and substrate-equivalence consumers.
| && bool_witness_matches_entry_function( | ||
| w: w, | ||
| entry: w.entry, | ||
| function: w.function |
There was a problem hiding this comment.
BLOCKING: The C9 field-preservation witness feeds the extracted BoolWitness.function back as its own expected value, so a dropped or wrong function field still satisfies the law, violating Facts Flow Forward / Boundary Discipline.
|
|
||
| v4_glob_discovery_default_claims_root() { | ||
| local root="${1:-}" | ||
| if [[ -n "$root" ]]; then |
There was a problem hiding this comment.
BLOCKING: The helper documents its argument as a claims_root but treats every nonempty argument as a source root and appends /test/claim, so the impossible_bug perturb scans the wrong tree and can pass as a false positive.
| || path.starts_with("src/v4/test/claim/") | ||
| || path == "scripts/v4-testclaim-corpus-eval.sh" | ||
| || path == "scripts/v4-testclaim-smoke-roster.sh" | ||
| || path == "scripts/v4-substrate-equivalence-gate.sh" |
There was a problem hiding this comment.
BLOCKING: The affected-set update wires the new substrate-equivalence gate but omits its sourced projection authority scripts/v4-glob-discovery-project.sh, so projector changes can skip the testclaim corpus gate.
Summary
Deletes
v4_roster_pilot.dagand makesglob_discovery.dagthe authoritative smoke-roster for 80 distributedBoolWitnessClaimmarkers. Repointsscripts/v4-testclaim-smoke-roster.shto project the unified-claim list (shell-side grep/awk, no 135-source compile preamble). Addsunified_test_claim_substrate_equivalence.dag+scripts/v4-substrate-equivalence-gate.sh(C9 modality/substrate law) wired intov4_lens_gateCI with--perturb-check.Test plan
./scripts/v4-substrate-equivalence-gate.sh— green./scripts/v4-substrate-equivalence-gate.sh --perturb-check— perturbed witness returnsfalseglob_discovered_claim_run_row_count./scripts/v4-testclaim-smoke-roster.sh(80 claim-runs) — deferred to CI; local container OOMs on glob_discovery compilecargo test -p ci_affected_componentsWhite-box inventory (catalog only — no deletions in this PR)
Per parent scope: classify remaining v4-adjacent SG-0 entries for a follow-on child.
v4_leaf_model_*_test.rs(9 boundary)v4_emit_host_{eval_dispatch,harness}_test.rsv4_t15_self_host_fixed_point_harness_test.rsemit_verification_gates_test.rsv4_p9_llvm_instruction_cost_single_owner_test.rsv4_std_text_boundary_carrier_guard_test.rsstd_text/carrier_claims.dag)v4_test_bootstrap_infra_closeout_test.rscoverage_defect_acceptance_dag_test.rscross_target_coverage_carrier_test.rsdissolution_subsumption_carrier_test.rs#4618 impossible-bug claims: excluded from smoke slice per
glob_discovery.dagheader; land as co-located markers when that PR merges.