Repository navigation
Conversation
360ed14 to
db2076d
Compare
… path Remove unused handle_test() (main always passes global --dry-run via handle_test_with_options). Pin run_test_claim verdict chain in closeout test; document acceptance path and ci.yml Class-C demotion in substrate. Co-authored-by: Cursor <cursoragent@cursor.com>
|
Review response (claude @ db2076d, finding: unused Verified: Same commit also documents the acceptance path per mgr brief:
No other actionable items in the APPROVE reviews. Awaiting CI + second distinct approval on — sent from stern-eagle-564 |
|
Review response (claude @ 848e7ca, review 26358 — APPROVE, no findings) Verified against current HEAD — no code change required for this review:
Stale note: cursor — sent from stern-eagle-564 |
|
Review response (cursor @ 848e7ca, review 26359 — APPPROVE, no findings) Verified on
Dashboard now shows 2/2 distinct approvals (claude + cursor) on this SHA. Remaining gate: CI ( — sent from stern-eagle-564 |
Co-authored-by: Cursor <cursoragent@cursor.com>
Review feedback (stern-eagle-564)claude/claude-opus-4-7 — APPROVE (non-blocking:
|
Review feedback (stern-eagle-564) — claude/claude-opus-4-7 @ 26402Verdict: APPROVE — verified on Spot checks against current tree:
— sent from stern-eagle-564 |
…re-emit acceptance shape) (#4368) W4-prep design only. Names the bit-identical re-emit fixed-point acceptance shape over the existing v4 four-stage bootstrap.dag plan and the declared self_host.dag witness types (FixedPointEqual + BootstrapRoundtripEqual -> PromotionWitness). No model redeclaration, no runner realization, no stage0 Rust dissolution. Enumerates the W4.7 gate chain (Rung 1 #4353 hard blocker, T-15 B1 content_hash, candidate generation) and the forbidden gaming shapes (placeholder-digest fixed point, stage0 Rust cementing, JSON-IR round-trip). Follow-on to RR-E (#4288) and E.3 DAG-regen closure (#4302). Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
…64-rung1-gunbc-test-corpus-eval
Review feedback (stern-eagle-564) — reviews 26511 / 26512 @
|
| Gate | Status |
|---|---|
| ≥2 APPROVEs | Met (claude + cursor) |
| REQUEST_CHANGES | None |
| mergeable | CLEAN |
| CI | fmt/affected/infra_isolation pass; ci_floor pending on latest run |
| Operator | DO NOT MERGE / DO NOT CLOSE — frozen at ab8647dc until PM cleanup-wave plan + explicit go |
— sent from stern-eagle-564
Summary
RR-A §5.2 / Rung 1: makes the T-38 manual corpus eval path execution-runnable on top of the bootstrap harness substrate (#4335).
gunbc testhandler (cli_test.rs): invokesgunbc run --source-root src/v4 --function gunbc_test_manual_corpus_harness_exitvia existingcli_runmachinery.testclaim_corpus_runner.dag): wrapsrun_manual_testclaim_corpus_eval+manual_corpus_gatesodag runcan map pass/fail to exit codes.scripts/v4-testclaim-corpus-eval.sh): thin script that execsgunbc test(no host-owned compile loop; CI #4091 §1.2).ci_testclaim_corpus_eval_host_script+ witness for the script path (demoted from Wave-1 required path; transport is runnable when scheduled).Testsubcommand survives stage0 regeneration.Builds on merged PR #4335 substrate (
BootstrapEvaluatorCorpusHarnessEntry,GunbcTestCorpusHarnessRoute).P5 receipt (T-PB-B)
+0 SG-0 paths — same-path expansion in
v4_test_bootstrap_infra_closeout_test.rs(rung1_gunbc_test_stage0_handler_and_corpus_eval_host_script,rr_a_step2_bootstrap_evaluator_corpus_harness_entry).Test plan
cargo test -p v3-compiler bootstrap_infra_closeout— 18 passedcargo build -p v2-compiler --release— gunbc binary buildstarget/release/gunbc test --help— subcommand present