Repository navigation
Fix source atom string projection recursion for #4182 - #4242
Merged
Merged
Conversation
briansrls
changed the title
briansrls
marked this pull request as ready for review
June 1, 2026 17:49
briansrls
commented
Jun 1, 2026
briansrls
left a comment
briansrls
left a comment
Contributor
Author
There was a problem hiding this comment.
Review metadata
- Provider / model:
codex/unknown - Commit:
0c87aa60· Trigger:schedule - Thinking:
210s wall
BLOCKING (1)
Root Cause
src/v4/std/target_model.dagsource_atom_string_projection_from_node was refactored to fold_node by introducing an unclassified fold-state carrier → either dissolve the state into existing std structure or add the required coproduct disposition/gate on the type.
| // bounded to TS-ATOM-REALIZATION's String value-template bridge; forbidden: adding another | ||
| // FreeMonoid storage walker outside this receipt. | ||
| fn source_atom_string_projection_from_node(source: Node) -> Optional<SourceAtomValue> { | ||
| type SourceAtomStringProjectionFold |
Contributor
Author
There was a problem hiding this comment.
BLOCKING: New substrate .dag coproduct SourceAtomStringProjectionFold has six variants but no required 🟢/🟡/🔴 classification tag, violating modeling-discipline Practices 4/9 and INVARIANTS P5.
2 tasks done
briansrls
added a commit
that referenced
this pull request
Jun 1, 2026
briansrls
added a commit
that referenced
this pull request
Jun 1, 2026
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Caretakes #4182 by replacing the explicit recursive
source_atom_string_projection_from_nodewalker with the existingfold_nodetraversal pattern. The projection remains fail-closed for encodedFreeMonoid<Char>string nodes, but no longer trips the v4 bootstrap complexity check for same-argument recursion.This PR is intentionally scoped to the recursion RCA on top of the existing TestClaimRun E0107 implementation branch; it does not expand the generic-preservation work.
Test plan
ctrl-build -- /opt/cargo/bin/cargo build --release --bin gunbc— passed.ctrl-build -- bash scripts/v4-bootstrap-viability.sh— passed:compiled: 1 files emitted, 0 diagnostics.