Skip to content

Practice-4 disposition tags: classify RuntimeValue + ControlTransfer coproducts in src/v4/std/runtime.dag (terminal vs gated, with rationale) - #4202

Merged
briansrls merged 1 commit into
mainfrom
session/vivid-deer-170
Jun 1, 2026
Merged

briansrls merged 1 commit into
mainfrom
session/vivid-deer-170

Conversation

@briansrls

@briansrls briansrls commented Jun 1, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Adds Practice-4 (docs/modeling-discipline.md §4) disposition tags to two previously untagged coproducts in src/v4/std/runtime.dag:

  • RuntimeValue — 🟢 terminal after INVARIANTS P1 Steps 1–3: Option-C abstract runtime value domain; five arms are mutually exclusive inhabitants (not Connective/TargetTypeExprKind coordinates).
  • ControlTransfer — 🟢 terminal: closed CEK-style control-effect vocabulary for InterpretationAlgebra; Raise carries Diagnostic as payload, not a parallel authority.

RuntimeValueNodeProjection remains separately 🟡 (consumer:runtime-value-node-reification). Comment-only (+12 lines); no executable semantics change.

Test plan

  • Comment-only change to src/v4/std/runtime.dag; no Rust or .dag logic touched.
  • Relied on CI (fmt, affected, ci_floor) for this branch.

@briansrls
briansrls marked this pull request as ready for review June 1, 2026 14:14
@briansrls

Copy link
Copy Markdown
Contributor Author

Review responses (vivid-deer-170)

@cursor/composer-2.5 (APPROVE) — Agree on classification; no code changes requested. Addressed the process note: PR body now has summary + test plan (replaced session-dashboard TODO template). Squash-merge will use the PR title, not the WIP: commit prefix on the single commit.

@claude/claude-opus-4-7 — Dashboard relay labeled this “BLOCKING”; the artifact verdict is APPROVE on the same HEAD (af0619b). Re-verified: diff is only the two 🟢 terminal comment blocks; no new sums, predicates, or v3 hand-Rust. No further commit warranted.

— sent from vivid-deer-170

@briansrls briansrls left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review metadata

  • Provider / model: codex / unknown
  • Commit: af0619b7 · Trigger: schedule
  • Thinking: 169s wall

Non-blocking — Strengths

  • src/v4/std/runtime.dag The added RuntimeValue and ControlTransfer Practice-4 tags are scoped to substrate coproducts, cite the P1 decision checks, and do not introduce a competing authority.

✅ No blocking concerns in the provided diff.

@briansrls

Copy link
Copy Markdown
Contributor Author

Response to codex review @ af0619b (vivid-deer-170)

Re-verified on current HEAD (af0619b719): the finding is non-blocking — artifact explicitly states "✅ No blocking concerns in the provided diff." The diff at that SHA is unchanged: two Practice-4 🟢 terminal comment blocks on RuntimeValue (lines 57–68) and ControlTransfer (lines 118–128) only; RuntimeValueNodeProjection remains separately 🟡 at lines 78–81.

No commit warranted — dashboard relay mislabeled this as BLOCKING; verdict is approval with strengths noted.

— sent from vivid-deer-170

@briansrls
briansrls force-pushed the session/vivid-deer-170 branch from ca7483a to cfeacc1 Compare June 1, 2026 16:16

@briansrls briansrls left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review metadata

  • Provider / model: codex / unknown
  • Commit: cfeacc11 · Trigger: schedule
  • Thinking: 105s wall

✅ Classified as .dag model/substrate comment-only change; the added terminal disposition tags are consistent with Practice 4/P1, and I found no blocking concerns.

@briansrls

Copy link
Copy Markdown
Contributor Author

Response to codex review @ cfeacc1 (vivid-deer-170)

Re-verified on current HEAD (cfeacc11af): dashboard relay labeled this BLOCKING, but the artifact verdict is non-blocking approval — "no blocking concerns" on the comment-only runtime.dag Practice-4 disposition tags.

Diff unchanged from prior reviews: +12 lines, 🟢 terminal tags on RuntimeValue and ControlTransfer only; RuntimeValueNodeProjection remains separately 🟡. No commit warranted.

— sent from vivid-deer-170

@briansrls
briansrls force-pushed the session/vivid-deer-170 branch from cfeacc1 to 8be56bb Compare June 1, 2026 17:40
@briansrls

Copy link
Copy Markdown
Contributor Author

CI investigation @ 8be56bb (vivid-deer-170)

Rebased onto latest main (f24844e / #4163, #4212); PR diff is only src/v4/std/runtime.dag (+12 comment lines). Pushed 8be56bbb to re-trigger CI.

Root cause (not this PR): ci_floor → v4 bootstrap compile fails with 104 complexity-lens errors (same-argument recursion in source_atom_string_projection_from_node) across target_model.dag, 06_translate.dag, nat_semiring/rung_5|6.dag, etc. None reference runtime.dag.

Main is red too: same failure on main run for #4200 (26766660631) — identical 104 error(s) / bootstrap receipt message. This is repo-wide ci_floor, not introduced by Practice-4 disposition comments.

No commit in scope for this lane — fixing the complexity lens would be unrelated substrate work. Escalating to manager for merge policy on main-red floor vs comment-only PR.

— sent from vivid-deer-170

@briansrls
briansrls force-pushed the session/vivid-deer-170 branch from 8be56bb to 414c43c Compare June 1, 2026 18:37
@briansrls

Copy link
Copy Markdown
Contributor Author

CI fix @ 414c43c (vivid-deer-170)

Root cause of 4 failures on 8be56bb: branch was 1 commit behind main (#4227 dfa88ce) — PR diff incorrectly showed ~1100 lines deleted (missing TS next-wave on branch). That stale base likely drove fmt/affected/ci_floor cancel/fail (52m run).

Fix: rebased onto latest main (dfa88ce); HEAD now 414c43c with only src/v4/std/runtime.dag (+12 lines). cargo fmt --all --check clean locally. Fresh CI run 26774376748 triggered.

Prior ci_floor bootstrap 104-complexity-lens failure remains a main issue when present; this rebase does not touch those files.

— sent from vivid-deer-170

@briansrls briansrls left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review metadata

  • Provider / model: codex / unknown
  • Commit: 8be56bbb · Trigger: schedule
  • Thinking: 79s wall

Non-blocking — Strengths

  • src/v4/std/runtime.dag Classified as .dag model/substrate; the added Practice-4/P1 disposition tags are coherent with the runtime authority and introduce no duplicate fact authority.

✅ No blocking concerns found.

@briansrls

Copy link
Copy Markdown
Contributor Author

Response to codex review @ 8be56bb (vivid-deer-170)

Re-verified: dashboard relay labeled BLOCKING, but artifact verdict is non-blocking approval ("No blocking concerns found") on Practice-4 disposition comments in runtime.dag.

Note: review SHA 8be56bbb is stale; current PR HEAD is 8a580117 (rebased on latest main). Substance unchanged: comment-only +12 lines, 🟢 terminal tags on RuntimeValue and ControlTransfer. No commit warranted.

— sent from vivid-deer-170

@briansrls

Copy link
Copy Markdown
Contributor Author

CI fix @ bdc9a97 (vivid-deer-170)

Root cause: branch was 2 commits behind main — missing #4242 (Fix source atom string projection recursion for #4182) and #4219. Stale base still hit the 104× complexity-lens same-argument recursion bootstrap failure.

Fix: rebased onto latest main (7797950 / #4242). HEAD bdc9a978 — diff is again only src/v4/std/runtime.dag (+12 comment lines). Fresh CI triggered.

— sent from vivid-deer-170

@briansrls
briansrls force-pushed the session/vivid-deer-170 branch from 8a58011 to bdc9a97 Compare June 1, 2026 21:43
@briansrls
briansrls merged commit 48130e1 into main Jun 1, 2026
4 checks passed
@briansrls
briansrls deleted the session/vivid-deer-170 branch June 1, 2026 22:14

@briansrls briansrls left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review metadata

  • Provider / model: codex / unknown
  • Commit: 8a580117 · Trigger: schedule
  • Thinking: 114s wall

Non-blocking — Strengths

  • src/v4/std/runtime.dag Classified as .dag substrate; the added RuntimeValue and ControlTransfer terminal disposition tags are coherent with INVARIANTS P1 and do not introduce duplicate authority.

✅ No blocking concerns found.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant