Repository navigation
Runtime/TestClaim Manager — authority over T-22 eval execution, T-38 structured TestClaimRun verdicts, emitted-code run harness, falsification verdict receipts per PR #3938 §11.1. Critical path for L4 (emit runs and matches .dag eval) and rungs 4-6 on every fixture. First artifact: with Compiler Spi - #3950
briansrls wants to merge 4 commits into
Conversation
…nner interface (joint with Compiler Spine) First artifact for PR #3938 §11.4 item 4 — manager pass before worker code. Co-authored with Compiler Spine (smart-stag-871) draft. Runtime/TestClaim amendments A1–A4 to §4.2 (host stdout typing, typed exit, Rust-only W2 scope, falsification receipt carrier) plus §4.4 CI rung-split so W2/W3 don't deadlock on W1. Pre-operator-sign-off (PR #3938 §8): spec only, no worker dispatch. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
02b0dbb to
bd95b5b
Compare
briansrls
left a comment
There was a problem hiding this comment.
Review metadata
- Provider / model:
codex/unknown - Commit:
bd95b5b5· Trigger:schedule - Thinking:
232s wall
BLOCKING (5)
Root Cause
docs/planning/compiler-spine-runtime-rung34-min-runner-interface-2026-05-30.mdFrozen carrier table was authored from intended prose instead of the live substrate → align §2 withsrc/v4/compiler/04_infer.dagor make the substrate reshuffle explicit with the required sign-off.docs/planning/compiler-spine-runtime-rung34-min-runner-interface-2026-05-30.mdRuntime/TestClaim wants separate subject and verdict-value types before the substrate carries that split → either rebase on currentTestClaimRun<T>or land the substrate change as its own controlled interface change.docs/planning/compiler-spine-runtime-rung34-min-runner-interface-2026-05-30.mdHost stdout parsing was named before reconciling with PB-Runtime’sValueauthority → useValueor explicitly amend the PB-Runtime lock before dispatching the interface.docs/planning/compiler-spine-runtime-rung34-min-runner-interface-2026-05-30.mdFalsification receipts are specified as prose beside the verdict carrier instead of inside the modeled result shape → add a typed verdict/result carrier or return the receipt through a representable field.docs/planning/compiler-spine-runtime-rung34-min-runner-interface-2026-05-30.mdThe runner plan assumes a corpus-runner module that is not landed in base or this PR → reference an existing carrier such aspipeline_rejections.dagor explicitly make creation of the corpus runner part of the dispatch.
|
|
||
| Define the **minimum executable runner** needed to gate **rung 3** (parse–emit–parse round-trip) and **rung 4** (emit runs; output matches `.dag` interpreter eval) on the Phase 1 fixture. Workers may implement only against this interface; Ladder/Fixture owns acceptance predicates that *consume* verdicts from it. | ||
|
|
||
| --- |
There was a problem hiding this comment.
BLOCKING: The frozen InferredFacts row drops live fields resolved_type, inhabits, and cost from src/v4/compiler/04_infer.dag:35, violating Facts Flow Forward / INVARIANTS P2.
|
|
||
| --- | ||
|
|
||
| ## 2. Frozen spine carriers (Phase 2 lock) |
There was a problem hiding this comment.
BLOCKING: The doc freezes TestClaimRun<S, A>, but the live substrate is TestClaimRun<T> at src/v4/compiler/05_eval.dag:95, so workers cannot implement this interface without violating the no-signature-change rule.
|
|
||
| ## 4. Minimum runner surface (joint API) | ||
|
|
||
| ### 4.1 Spine-owned (T-22 / T-8–T-10) |
There was a problem hiding this comment.
BLOCKING: RuntimeValueParse introduces RuntimeValue, but PB-Runtime’s locked carrier is Value and docs/briefs/r2-pr-a1-runtime-value-dependency-audit.md:30 says RuntimeValue requires explicit lock amendment, so this creates a second value authority under P2.
| ### 4.1 Spine-owned (T-22 / T-8–T-10) | ||
|
|
||
| Already landed; workers extend behavior, not signatures: | ||
|
|
There was a problem hiding this comment.
BLOCKING: The invariant that Fail carries FalsificationReceipt<RuntimeValue> is not representable in live Verdict<T> because Fail only carries actual: Outcome<T> at src/v4/compiler/05_eval.dag:90, violating API-level enforcement.
| Already landed; workers extend behavior, not signatures: | ||
|
|
||
| ```dag | ||
| // T-9 |
There was a problem hiding this comment.
BLOCKING: This says aggregation reuses src/v4/test/claim/workflow/testclaim_corpus_runner.dag, but git ls-tree origin/main -- src/v4/test/claim/workflow/testclaim_corpus_runner.dag returned no blob and the diff does not add it, so the plan points workers at a nonexistent authority.
…Fail shape to PR #3961 codex review on #3950 flagged §4.2 invariants as load-bearing claims about current substrate. Add a Scope note making explicit that §4.2 is the proposed W2 worker brief, not live Verdict<T>. Also point to PR #3961 (verdict-surface contract) as the authoritative source for the final Verdict.Fail / FalsificationReceipt shape — that contract was authored after this doc and uses Verdict<S, T> with FalsificationReceipt<S, A>, not the <A>-only shape sketched in row 87/88 below. W2 worker keen-raven-290 has already implemented against #3961. Other findings on this PR (InferredFacts shape, TestClaimRun<S,A>, testclaim_corpus_runner.dag existence) are reviewer-misread issues and require no doc change — addressed via PR reply. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Response to codex BLOCKING (5) — verified against substrate at
|
|
Closing as superseded by #3947 (Compiler Spine's joint runner doc), which landed at the same path 63f0aa1 with both manager acks integrated plus additional refinements (Appendix A spine tree verification, A2 corrected to Outcome from posix.dag, A4 attachment block). My branch's content is now subsumed; the only delta was a §4.2 'Scope of this section' clarifying paragraph (codex-review response) which is largely covered by main's 'P2 enforcement (host + receipt)' paragraph. — sent from quick-tern-735 |
Auto-opened by session-dashboard for session
quick-tern-735.Pushing to
session/quick-tern-735advances this PR.Worker attestation
Before flipping this PR to ready for review, confirm each item:
npm test,cargo test) and the result.Closes #Ndirective.Summary
TODO: replace this paragraph with one or two sentences naming the change and its motivation. Reviewers read this first.
Test plan