Repository navigation
distinct-node zip-fold predicate algebra body fill for coercion_fold (MVP-1 critical-path closer) #3494
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
distinct-node zip-fold predicate algebra body fill for coercion_fold (MVP-1 critical-path closer) #3494
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
8f6c709
WIP: distinct-node zip-fold predicate algebra body fill for coercion_…
briansrls 1d5cb3c
WIP: distinct-node zip-fold predicate algebra body fill for coercion_…
briansrls 65631a8
WIP: distinct-node zip-fold predicate algebra body fill for coercion_…
briansrls b72b0f6
WIP: distinct-node zip-fold predicate algebra body fill for coercion_…
briansrls a7318f4
WIP: distinct-node zip-fold predicate algebra body fill for coercion_…
briansrls bcb71e7
WIP: distinct-node zip-fold predicate algebra body fill for coercion_…
briansrls d50401b
WIP: distinct-node zip-fold predicate algebra body fill for coercion_…
briansrls 7503d0f
WIP: distinct-node zip-fold predicate algebra body fill for coercion_…
briansrls e3e206b
WIP: distinct-node zip-fold predicate algebra body fill for coercion_…
briansrls 7f14e8f
WIP: distinct-node zip-fold predicate algebra body fill for coercion_…
briansrls File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
BLOCKING: The new exact structural equality zip-fold only compares the root kind and child count, so Conj field labels and all child facts can differ while find_witness still accepts, contradicting THESIS/INVARIANTS P1-P2 and the T-9 coercion-fold contract that the fold walks canonical Node groundings in parallel.