Repository navigation
distinct-node zip-fold predicate algebra body fill for coercion_fold (MVP-1 critical-path closer) - #3494
distinct-node zip-fold predicate algebra body fill for coercion_fold (MVP-1 critical-path closer)#3494briansrls wants to merge 10 commits into
Conversation
|
Bootstrap finding before ready-for-review:\n\nThe narrowed implementation still does not pass the v4 compile gate. Command:\n\n |
|
Closing as superseded by #3510. Replacement: #3510 — sunny-newt-545's fresh-on-main predicate broadening. +6 -2 in Why this PR is being closed rather than rebased: the branch had become stale relative to PR #3473's substrate-boundary realignment merge (declared-inhabitant flattening moved from translate into std/coercion as a concept-home boundary fix). Rebasing would have buried sunny-newt-545's minimal +6 -2 substantive change in conflict-resolution noise; PR #3510 keeps the change reviewable. Provenance trail:
This PR's investigation work was the trigger for finding the v2 dag-serializer regression — preserved as provenance via this closing comment. |
briansrls
left a comment
There was a problem hiding this comment.
Review metadata
- Provider / model:
codex/unknown - Commit:
7f14e8f3· Trigger:schedule - Thinking:
182s wall
BLOCKING (1)
Root Cause
src/v4/std/find_witness.dagfind_witness is accepting witnesses before a real recursive canonical Node comparator/content-hash fold is consumed → implement the zip-fold over children and edge labels, or keep this predicate rejected until that canonical equality surface lands.
| correction: Unavailable { reason: ExternalContractUnknown } | ||
| } | ||
| } | ||
| fn exact_structural_equality_zip_fold(source_facts: Node, candidate: Node) -> Bool { |
There was a problem hiding this comment.
BLOCKING: The new exact structural equality zip-fold only compares the root kind and child count, so Conj field labels and all child facts can differ while find_witness still accepts, contradicting THESIS/INVARIANTS P1-P2 and the T-9 coercion-fold contract that the fold walks canonical Node groundings in parallel.
Auto-opened by session-dashboard for session
vivid-deer-580.Pushing to
session/vivid-deer-580advances this PR.Worker attestation
Before flipping this PR to ready for review, confirm each item:
npm test,cargo test) and the result.Closes #Ndirective.Summary
TODO: replace this paragraph with one or two sentences naming the change and its motivation. Reviewers read this first.
Test plan