Skip to content

fix(v4): T-15 main.dag trampoline + B1 placeholders + parse smoke - #3388

Merged
briansrls merged 12 commits into
mainfrom
session/snappy-koi-363
May 19, 2026
Merged

fix(v4): T-15 main.dag trampoline + B1 placeholders + parse smoke#3388
briansrls merged 12 commits into
mainfrom
session/snappy-koi-363

Conversation

@briansrls

@briansrls briansrls commented May 19, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Auto-opened by session-dashboard for session snappy-koi-363.
Pushing to session/snappy-koi-363 advances this PR.

Worker attestation

Before flipping this PR to ready for review, confirm each item:

  • Title describes the change (not the session id or branch).
  • PR body summarises what and why (replace the TODO below).
  • Tests run: name the command (e.g. npm test, cargo test) and the result.
  • If this closes a work item, the body contains a Closes #N directive.
  • No commits on this branch are surprises (no fork/cherry-pick I did not make).
  • No secrets / credentials / large binaries staged.

Summary

Lands T-15 src/v4/bin/main.dag: a single String trampoline authority (main_rs_trampoline_authority → include!("v4_main_generated.rs");) plus two B1 digest placeholder Nodes (Conj vs Disj, empty children) with Status deferring Equals / TestClaim until B1 content_hash + T-22 (no vacuous witness). Adds .github/workflows/ci.yml affected timeout-minutes: 15 so full-repo checkout is not canceled at 5m. Adds v4_bin_main_dag_smoke_test (tokenize_for_test + parse_for_test) with INVARIANTS §P5(b) row + EXPECTED_HAND_AUTHORED_TEST census line; compile_to_dag(main.dag) is intentionally not claimed (single-file harness cannot link v4.std.node without bootstrap collision). SG-0: scripts/ci-merge/sg0-pr-body-append.3356.txt pairs the +1 hand-path delta. Operator grounded-indicator prose on carriers is HOLD pending hub canonical spec (see harness / INVARIANTS notes).

Test plan

  • cargo fmt --all --check — pass (local).
  • cargo test -p v3-compiler --test integration v4_bin_main_dag_tokenizes — pass (local).

briansrls and others added 11 commits May 19, 2026 19:05
@briansrls
WIP: {T-15} bin/main.dag scaffold + self-host fixed-point TestClaim w…
eb4378f 
…itness —
@briansrls @cursoragent
fix(v4): align main.dag TestClassification imports with manual-claim …
d7a8466 
…pattern

Import Tier2 and Integration constructors from verification.dag so
classification literals match sibling TestClaim modules (review #3356).

Co-authored-by: Cursor <cursoragent@cursor.com>
@briansrls @cursoragent
fix(v4): remove vacuous T-15 TestClaim from main.dag
7373d41 
Codex review: reflexive Equals on one stub reported success without
modeling stage1/stage2 digest operands. Withhold the TestClaim until
B1 hash carriers exist; keep two distinct well-formed Node placeholders
(Conj vs Disj) for the eventual witness operands.

Co-authored-by: Cursor <cursoragent@cursor.com>
@briansrls @cursoragent
fix(v4): keep main.dag as single trampoline authority (T-15)
4da9e02 
Codex/briansrls: digest-placeholder cleanup must not relocate the
1-line include! contract out of bin/main.dag. Add explicit
main_rs_trampoline_authority String carrier and correct Scope/Status
(STRUCTURE inv.2 + TASKS T-15); emit materializes, this module owns.

Co-authored-by: Cursor <cursoragent@cursor.com>
@briansrls @cursoragent
fix(v4): drop redundant std.text import for kernel-ambient String
0fad148 
STRUCTURE.md kernel-ambient rule: String literals do not require
text.dag in Consumes or a std.text import (codex review #3356).

Co-authored-by: Cursor <cursoragent@cursor.com>
@briansrls @cursoragent
fix(ci): give affected job time for full-repo checkout
cd4edc2 
The affected job uses fetch-depth: 0 plus origin/main fetch; on large
repos the checkout step can exceed the previous 5-minute job cap and get
cancelled mid-fetch (false CI red on PR #3356). Raise timeout to 15m.

Co-authored-by: Cursor <cursoragent@cursor.com>
@briansrls @cursoragent
fix(v4): domain-only digest placeholder names in bin/main.dag
794766c 
Operator no-program-markers override: remove task-id token from data
identifiers (stub_stage{1,2}_emitted_rust_digest_placeholder). Header
roadmap prose unchanged (rides #3358-A2 comment-layer ruling).

Co-authored-by: Cursor <cursoragent@cursor.com>
@briansrls
WIP: {T-15} bin/main.dag scaffold + self-host fixed-point TestClaim w…
2afdc79 
…itness —
@briansrls
WIP: {T-15} bin/main.dag scaffold + self-host fixed-point TestClaim w…
541830b 
…itness —
@briansrls @cursoragent
fix(test): make v4 bin main smoke hermetic (parse) + doc HOLD
75c47c7 
tokenize/parse main.dag instead of compile_to_dag (single-file path cannot
link v4.std.node; bundling with node.dag collides with bootstrap). Update
INVARIANTS + SG-0 census comments. Grounded-indicator lines already removed
from main.dag pending canonical spec.

Co-authored-by: Cursor <cursoragent@cursor.com>
@briansrls @cursoragent
chore(ci): SG-0 PR-body append for #3356 census +1
8bc808c 
Adds `scripts/ci-merge/sg0-pr-body-append.3356.txt` so CI prepends the required
`SG-0 hand-path delta: +1` and `(c)` pairing for `v4_bin_main_dag_smoke_test.rs`.

Co-authored-by: Cursor <cursoragent@cursor.com>
@briansrls briansrls changed the title {T-15} bin/main.dag scaffold + self-host fixed-point TestClaim witness — Equals on content_hash, closed AssertKind (no 5th kind); terminal refine Wave-6-gated NOT this lane fix(v4): T-15 main.dag trampoline + B1 placeholders + parse smoke May 19, 2026
@briansrls
briansrls marked this pull request as ready for review May 19, 2026 19:44
@briansrls

briansrls commented May 19, 2026

Copy link
Copy Markdown
Contributor Author

Verified cursor/composer-2.5 review 15004 (APPROVE) against the pre-sync branch: main.dag, v4_bin_main_dag_smoke_test.rs, sg0_census_test.rs:835–836, INVARIANTS.md:369, integration.rs:278–279, and ci.yml all matched the review’s description at 8bc808c45.

Exploratory merge-hygiene (addressed with a commit): session/snappy-koi-363 had diverged from origin/main after #3356 landed on main (077b04c4); the same T-15 + smoke + SG-0 bytes were already on main, while the branch was missing newer main work (e.g. v4_lens_testgen_dag_smoke_test / census rows). Merging origin/main → branch was required to avoid an accidental mass regression if this PR were merged from the stale tip.

Pushed: merge commit da687f92d — tree at HEAD is byte-identical to origin/main (PR file diff vs base is empty). Treat #3388 as history-only / superseded by main unless you intentionally want a no-op merge commit on main for bookkeeping; otherwise close the PR.

Merge readiness: gh pr merge not run (operator policy). With 0 files changed vs main, there is nothing substantive to merge; CI on the merge commit should mirror main once checks finish.

— sent from snappy-koi-363

@briansrls
briansrls merged commit f51131a into main May 19, 2026
7 checks passed
@briansrls
briansrls deleted the session/snappy-koi-363 branch June 1, 2026 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@briansrls