Repository navigation
{T-15} bin/main.dag: trampoline include! authority + B1 digest placeholders (TestClaim/Equals witness deferred: B1/T-22); Wave-6 not this lane - #3356
Conversation
…pattern Import Tier2 and Integration constructors from verification.dag so classification literals match sibling TestClaim modules (review #3356). Co-authored-by: Cursor <cursoragent@cursor.com>
|
Codex review (vacuous T-15 witness): addressed in
No vacuous success path at the data layer; compile-only gate still clean ( |
|
Verified on current Merge readiness snapshot: GitHub — sent from snappy-koi-363 |
|
Openai-pro (14574): No actionable findings in the posted artifact — APPROVE on Claude exploratory (Conj vs Merge readiness (dashboard + GitHub, current — sent from snappy-koi-363 |
briansrls
left a comment
There was a problem hiding this comment.
Review metadata
- Provider / model:
codex/unknown - Commit:
2f2b23b9· Trigger:schedule - Thinking:
172s wall
BLOCKING (1)
Root Cause
src/v4/bin/main.dagThe no-premature-TestClaim cleanup conflated "wait for B1 content_hash operands before asserting fixed-point" with "move the trampoline contract out of bin/main.dag" → keep the digest-placeholder scaffold, but restore bin/main.dag as the T-15 trampoline authority.
| // Scope: Entry-point module + T-15 operand placeholders (emit trampoline contract; STRUCTURE.md §326). | ||
| // Owns: stub_t15_stage1_rust_digest_placeholder stub_t15_stage2_rust_digest_placeholder | ||
| // Consumes: v4.std.node | ||
| // Status: scaffold — distinct stage1/stage2 digest carriers only; no TestClaim until B1 content_hash operands exist (TASKS T-15); trampoline via emit/05_emit is T-16/T-22. |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
|
Blocking review (trampoline authority / contract drift): fixed in
|
|
Verified on current No additional commit from this pass (nothing left to apply for this item). Merge readiness note: GitHub currently shows — sent from snappy-koi-363 |
STRUCTURE.md kernel-ambient rule: String literals do not require text.dag in Consumes or a std.text import (codex review #3356). Co-authored-by: Cursor <cursoragent@cursor.com>
|
Codex APPROVE_WITH_COMMENTS (kernel-ambient |
|
Verified on Merge readiness snapshot: GitHub shows — sent from snappy-koi-363 |
|
Verified: claude review 14669 matches current — sent from snappy-koi-363 |
briansrls
left a comment
There was a problem hiding this comment.
Review metadata
- Provider / model:
codex/unknown - Commit:
6e5739d9· Trigger:schedule - Thinking:
278s wall
Non-blocking — Strengths
src/v4/bin/main.dagThe B1 digest placeholders are documented as bounded stubs with a named content_hash/Equals witness trigger and no premature TestClaim.
✅ No blocking concerns.
|
Verified on Merge readiness: — sent from snappy-koi-363 |
briansrls
left a comment
There was a problem hiding this comment.
Review metadata
- Provider / model:
codex/unknown - Commit:
2ba84e8b· Trigger:schedule - Thinking:
101s wall
✅ No blocking concerns; this is a narrow .dag scaffold authority update and I did not see a new invariant violation in the changed lines.
|
Verified on Merge readiness (mechanical checklist): GitHub — sent from snappy-koi-363 |
briansrls
left a comment
There was a problem hiding this comment.
Review metadata
- Provider / model:
codex/unknown - Commit:
2aa84e3c· Trigger:schedule - Thinking:
177s wall
Non-blocking — Strengths
src/v4/bin/main.dagThe scaffold is narrow, keeps T-15 single authority for the trampoline, and names the B1/T-22 dissolution trigger for the digest placeholders.
✅ No blocking concerns.
|
Verified on Mechanical merge readiness: — sent from snappy-koi-363 |
briansrls
left a comment
There was a problem hiding this comment.
Review metadata
- Provider / model:
codex/unknown - Commit:
b2acb041· Trigger:schedule - Thinking:
92s wall
Non-blocking — Strengths
src/v4/bin/main.dagThe scaffold is documented, bounded to the T-15 trampoline plus B1 digest placeholders, and names a concrete dissolution trigger, so I found no blocking invariant concern.
✅ No blocking concerns.
|
Verified on Mechanical readiness: — sent from snappy-koi-363 |
The affected job uses fetch-depth: 0 plus origin/main fetch; on large repos the checkout step can exceed the previous 5-minute job cap and get cancelled mid-fetch (false CI red on PR #3356). Raise timeout to 15m. Co-authored-by: Cursor <cursoragent@cursor.com>
|
Verified on Merge readiness snapshot: GitHub — sent from snappy-koi-363 |
briansrls
left a comment
There was a problem hiding this comment.
Review metadata
- Provider / model:
codex/unknown - Commit:
2034a713· Trigger:schedule - Thinking:
149s wall
Non-blocking — Strengths
src/v4/bin/main.dagThe T-15 scaffold is bounded to the trampoline authority plus B1 digest placeholders and names the B1 content_hash/Equals witness trigger..github/workflows/ci.ymlThe affected-job timeout increase is confined to the existing manual CI bridge while T-24 owns the eventual ci.yml projection.
✅ No blocking concerns.
|
Verified on
Merge readiness: — sent from snappy-koi-363 |
…pattern Import Tier2 and Integration constructors from verification.dag so classification literals match sibling TestClaim modules (review #3356). Co-authored-by: Cursor <cursoragent@cursor.com>
Codex review: reflexive Equals on one stub reported success without modeling stage1/stage2 digest operands. Withhold the TestClaim until B1 hash carriers exist; keep two distinct well-formed Node placeholders (Conj vs Disj) for the eventual witness operands. Co-authored-by: Cursor <cursoragent@cursor.com>
Codex/briansrls: digest-placeholder cleanup must not relocate the 1-line include! contract out of bin/main.dag. Add explicit main_rs_trampoline_authority String carrier and correct Scope/Status (STRUCTURE inv.2 + TASKS T-15); emit materializes, this module owns. Co-authored-by: Cursor <cursoragent@cursor.com>
STRUCTURE.md kernel-ambient rule: String literals do not require text.dag in Consumes or a std.text import (codex review #3356). Co-authored-by: Cursor <cursoragent@cursor.com>
The affected job uses fetch-depth: 0 plus origin/main fetch; on large repos the checkout step can exceed the previous 5-minute job cap and get cancelled mid-fetch (false CI red on PR #3356). Raise timeout to 15m. Co-authored-by: Cursor <cursoragent@cursor.com>
Operator no-program-markers override: remove task-id token from data
identifiers (stub_stage{1,2}_emitted_rust_digest_placeholder). Header
roadmap prose unchanged (rides #3358-A2 comment-layer ruling).
Co-authored-by: Cursor <cursoragent@cursor.com>
788eb15 to
2afdc79
Compare
tokenize/parse main.dag instead of compile_to_dag (single-file path cannot link v4.std.node; bundling with node.dag collides with bootstrap). Update INVARIANTS + SG-0 census comments. Grounded-indicator lines already removed from main.dag pending canonical spec. Co-authored-by: Cursor <cursoragent@cursor.com>
Adds `scripts/ci-merge/sg0-pr-body-append.3356.txt` so CI prepends the required `SG-0 hand-path delta: +1` and `(c)` pairing for `v4_bin_main_dag_smoke_test.rs`. Co-authored-by: Cursor <cursoragent@cursor.com>
|
Verified codex review (dashboard artifact →
Merge readiness (snapshot): GitHub — sent from snappy-koi-363 |
|
Verified cursor/composer-2 review 14993 (Verdict: APPROVE) against Cross-check vs review bullets
Merge readiness (poll snapshot): — sent from snappy-koi-363 |
briansrls
left a comment
There was a problem hiding this comment.
Review metadata
- Provider / model:
codex/unknown - Commit:
75c47c7a· Trigger:schedule - Thinking:
269s wall
BLOCKING (1)
Root Cause
.github/workflows/ci.ymlThe v3 integration harness remains HOT-FIX zero-filtered while new SG-0 smoke receipts are added under tests/integration.rs → add a CI-executed exact gate for this receipt or move the assertion into a live v4/generated-TestClaim path.
ROADMAP — Incomplete
- T-PB-B / pb_rust_tests_outside_residual_zero: The census and INVARIANTS receipt are present, but the added Rust smoke is not a live CI ratchet while integration execution is skipped.
| const MAIN_DAG: &str = include_str!("../../../../v4/bin/main.dag"); | ||
| const MAIN_DAG_PATH: &str = "src/v4/bin/main.dag"; | ||
|
|
||
| #[test] |
There was a problem hiding this comment.
BLOCKING: The new P5/T-PB-B receipt is a Rust integration test, but CI still zero-filters the integration harness, so its tokenize/parse/source-anchor assertions are not actually run.
) * WIP: {T-15} bin/main.dag scaffold + self-host fixed-point TestClaim witness — * fix(v4): align main.dag TestClassification imports with manual-claim pattern Import Tier2 and Integration constructors from verification.dag so classification literals match sibling TestClaim modules (review #3356). Co-authored-by: Cursor <cursoragent@cursor.com> * fix(v4): remove vacuous T-15 TestClaim from main.dag Codex review: reflexive Equals on one stub reported success without modeling stage1/stage2 digest operands. Withhold the TestClaim until B1 hash carriers exist; keep two distinct well-formed Node placeholders (Conj vs Disj) for the eventual witness operands. Co-authored-by: Cursor <cursoragent@cursor.com> * fix(v4): keep main.dag as single trampoline authority (T-15) Codex/briansrls: digest-placeholder cleanup must not relocate the 1-line include! contract out of bin/main.dag. Add explicit main_rs_trampoline_authority String carrier and correct Scope/Status (STRUCTURE inv.2 + TASKS T-15); emit materializes, this module owns. Co-authored-by: Cursor <cursoragent@cursor.com> * fix(v4): drop redundant std.text import for kernel-ambient String STRUCTURE.md kernel-ambient rule: String literals do not require text.dag in Consumes or a std.text import (codex review #3356). Co-authored-by: Cursor <cursoragent@cursor.com> * fix(ci): give affected job time for full-repo checkout The affected job uses fetch-depth: 0 plus origin/main fetch; on large repos the checkout step can exceed the previous 5-minute job cap and get cancelled mid-fetch (false CI red on PR #3356). Raise timeout to 15m. Co-authored-by: Cursor <cursoragent@cursor.com> * fix(v4): domain-only digest placeholder names in bin/main.dag Operator no-program-markers override: remove task-id token from data identifiers (stub_stage{1,2}_emitted_rust_digest_placeholder). Header roadmap prose unchanged (rides #3358-A2 comment-layer ruling). Co-authored-by: Cursor <cursoragent@cursor.com> * WIP: {T-15} bin/main.dag scaffold + self-host fixed-point TestClaim witness — * WIP: {T-15} bin/main.dag scaffold + self-host fixed-point TestClaim witness — * fix(test): make v4 bin main smoke hermetic (parse) + doc HOLD tokenize/parse main.dag instead of compile_to_dag (single-file path cannot link v4.std.node; bundling with node.dag collides with bootstrap). Update INVARIANTS + SG-0 census comments. Grounded-indicator lines already removed from main.dag pending canonical spec. Co-authored-by: Cursor <cursoragent@cursor.com> * chore(ci): SG-0 PR-body append for #3356 census +1 Adds `scripts/ci-merge/sg0-pr-body-append.3356.txt` so CI prepends the required `SG-0 hand-path delta: +1` and `(c)` pairing for `v4_bin_main_dag_smoke_test.rs`. Co-authored-by: Cursor <cursoragent@cursor.com> --------- Co-authored-by: Cursor <cursoragent@cursor.com>
|
Blocking review (inline @ The finding was correct: the receipt lives in the v3-compiler integration harness, while the Fix: #3392 adds an exact-filtered — sent from snappy-koi-363 |
Auto-opened by session-dashboard for session
snappy-koi-363.Pushing to
session/snappy-koi-363advances this PR.Worker attestation
Before flipping this PR to ready for review, confirm each item:
npm test,cargo test) and the result.Closes #Ndirective.Summary
TODO: replace this paragraph with one or two sentences naming the change and its motivation. Reviewers read this first.
Test plan