Skip to content

v4 de-prose: src/v4/extdeps/languages/cpp.dag — 93.4%→<20% strict Practice-9 (modeling-discipline.md); FOLLOW-UP fresh PR on main-state (#3267 merged un-de-prosed, in-PR fix impossible); COMMENT-ONLY, carrier model byte-identical (v2 compile 0 diagnostics unchanged); cpp_abi.dag already compliant — - #3291

Closed
briansrls wants to merge 1 commit into
mainfrom
session/tidy-carp-737-cpp-tag-fix
Closed

v4 de-prose: src/v4/extdeps/languages/cpp.dag — 93.4%→<20% strict Practice-9 (modeling-discipline.md); FOLLOW-UP fresh PR on main-state (#3267 merged un-de-prosed, in-PR fix impossible); COMMENT-ONLY, carrier model byte-identical (v2 compile 0 diagnostics unchanged); cpp_abi.dag already compliant —#3291
briansrls wants to merge 1 commit into
mainfrom
session/tidy-carp-737-cpp-tag-fix

Conversation

@briansrls

@briansrls briansrls commented May 18, 2026

Copy link
Copy Markdown
Contributor

Auto-opened by session-dashboard for session tidy-carp-737.
Pushing to session/tidy-carp-737-cpp-tag-fix advances this PR.

Worker attestation

Before flipping this PR to ready for review, confirm each item:

  • Title describes the change (not the session id or branch).
  • PR body summarises what and why (replace the TODO below).
  • Tests run: name the command (e.g. npm test, cargo test) and the result.
  • If this closes a work item, the body contains a Closes #N directive.
  • No commits on this branch are surprises (no fork/cherry-pick I did not make).
  • No secrets / credentials / large binaries staged.

Summary

TODO: replace this paragraph with one or two sentences naming the change and its motivation. Reviewers read this first.

Test plan

  • TODO: list the commands that ran (or "no tests changed; relied on CI") and the outcome.

briansrls
briansrls commented May 18, 2026
View reviewed changes

@briansrls briansrls left a comment

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review metadata

  • Provider / model: codex / unknown
  • Commit: fd416bb5 · Trigger: schedule
  • Thinking: 124s wall

BLOCKING (1)

Root Cause

  • src/v4/DECISIONS.md Part 6 only recovers green ledgers for the listed bulk files, not C++ → add CppIntegerOverflowDisposition/cpp.dag to the Part 6 ledger or point the in-file tag at a ledger row that actually covers it.

⚠️ The carrier shape is unchanged, but the replacement ledger pointer is not currently backed by the cited authority.

Comment thread src/v4/extdeps/languages/cpp.dag
module v4.extdeps.languages.cpp

// 🟢 coproduct dissolution — DECISIONS.md T29-ABI + D2-REV.
// 🟢 coproduct dissolution — DECISIONS.md Part 6 · CP-3229-GREEN-TERMINAL.

@briansrls briansrls May 18, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BLOCKING: The new Practice-4 pointer names DECISIONS.md Part 6 · CP-3229-GREEN-TERMINAL, but that ledger’s bulk table omits cpp.dag/CppIntegerOverflowDisposition, so this substrate coproduct no longer has the required green receipt anchored (modeling-discipline.md Practice 4 / INVARIANTS P1).

@briansrls briansrls mentioned this pull request May 19, 2026
Merged
briansrls added a commit that referenced this pull request May 19, 2026
@briansrls @claude
v4 de-prose #3291 redo: conform cpp.dag coproduct tag to Part 6 · CP-…
04d548e 
…3229-* form (#3352)

The `CppIntegerOverflowDisposition` coproduct in `extdeps/languages/cpp.dag`
carried the non-conforming tag `// 🟢 coproduct dissolution — DECISIONS.md
T29-ABI + D2-REV.`, which predates and violates the in-file one-liners
directive (DECISIONS.md Part 6: every sum coproduct carries one
`// 🟢|🟡|🔴 coproduct dissolution — DECISIONS.md Part 6 · <CP-3229-*|SL-3229-*>`).

`cpp.dag` was created post-merge-base (PR #3199), so it cannot use the
merge-base-only `CP-3229-GREEN-TERMINAL` bulk slug. A dedicated Part-6 row
`CP-3229-CPP-INTEGER-OVERFLOW` is added — same shape as the post-merge-base
`CP-3229-NAT-LE-WITNESS` precedent — classifying the coproduct 🟢 GREEN
terminal with a five-pattern Practice-4 ledger, and the live tag points to it.

Comment + ledger only; carrier model byte-identical (parse-inert .dag `//`
line + markdown row), so the v2→v4 bootstrap-viability compile is unchanged.
Fresh from post-#3338 main; supersedes stale PR #3291 branch.

Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@briansrls

briansrls commented May 20, 2026

Copy link
Copy Markdown
Contributor Author

Closing as superseded/moot after merged #3289 (1f3a7150324a8775205c955526a4274bddba54db). I verified #3289 is merged and current origin/main passes the authoritative python3 scripts/strict_deprose_dag.py --check gate, including src/v4/extdeps/languages/cpp.dag; this draft follow-up remains DIRTY/stale. — sent from gentle-bee-208

@briansrls briansrls closed this May 20, 2026
@briansrls
briansrls deleted the session/tidy-carp-737-cpp-tag-fix branch June 1, 2026 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@briansrls