Repository navigation
modeling-discipline: reconcile scaffold exception with universal 🟡 plan-binding - #3260
Merged
briansrls merged 1 commit intoMay 18, 2026
Merged
Conversation
…🟡 plan-binding BLOCKING codex review (#3244, sha 15242ef + inline :257): #3244 made 🟡 plan-binding universal (every 🟡 binds a named primitive + owning substrate PR + dissolve-on-arrival follow-up), but Practice 4's scaffold exception still let the DECISIONS.md ledger defer wholesale and treated `feature:<sunset-milestone>` itself as the gate. A milestone-only gate leaves the dissolution path non-checkable, and a wholly-deferred ledger has nowhere to record the plan-binding. Fix: the scaffold exception now defers only the verbose patterns-tried analysis — NOT the 🟡's bound dissolution plan, which is the minimum that makes a 🟡 valid and is recorded even for a scaffold. The gate names the concrete missing primitive; a bare sunset-milestone is not a valid gate (the milestone records when revisited, not what is awaited). Audit also surfaced a minor gap: the Calibration section's general NON-BLOCKING tier did not cross-reference that dissolution findings are an always-BLOCKING class — added that line so a dissolution finding cannot be read as a NON-BLOCKING cleanup. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Forward-fix to merged #3244. A codex BLOCKING review (sha
15242efd+ inline at:257) found a real doc-level rule conflict: #3244 made the 🟡 plan-binding universal (every 🟡 binds a named missing primitive + owning substrate PR/task + dissolve-on-arrival follow-up), but Practice 4's scaffold exception was left as-is — it let theDECISIONS.mdclassification ledger defer wholesale and treatedfeature:<sunset-milestone>itself as the gate.Two consequences the review flagged:
feature:<sunset-milestone>) names no concrete missing primitive — it leaves the dissolution path non-checkable.The fix
DECISIONS.mdeven for a scaffold.// 🟡 feature:<missing-primitive> — DECISIONS.md <entry>); a bare<sunset-milestone>is not a valid gate — the milestone records when the scaffold is revisited, not what it waits on.Audit (operator-requested — "see if we missed anything else")
Audited the keystone end-to-end for other un-reconciled interactions from the recent amendment pile (#3241/#3242/#3244/#3258). Findings:
YELLOW/GREEN/named triggervocabulary remains (the modeling-discipline: unified dissolution-disposition vocabulary #3244 unification was clean);advisoryoccurs only in modeling-discipline: dissolution findings are blocking — remove the advisory tier #3258's negations. No other conflicts found.Changes
docs/modeling-discipline.md: scaffold exception rewrite (Practice 4) + Calibration always-BLOCKING cross-reference. +21 / -6, single file.Test plan
🤖 Generated with Claude Code