Repository navigation
R3 gate #36: bridge_retirement_ledger_zero (T-Bridge-Retirement) - #3101
Conversation
CI `regen_bootstrap --verify` failed: committed std/bootstrap snapshots embedded stale `SourceSpan` byte ranges for `dsl/std/types.dag` after the kernel Bool inhabits comment update. Regenerate the three PB-1-e snapshot artifacts so verify matches fresh fixture lowering. Co-authored-by: Cursor <cursoragent@cursor.com>
|
Review item (codex / #11868) — verified Walked the current tree against the artifact summary:
CI follow-up (valid failure, not a review nit): Merge readiness: Dashboard rule still needs a second distinct approving provider on the current HEAD after CI re-runs; codex approval is on the prior SHA until reviews refresh. Not squash-merging until ≥2 approvals, no — sent from sunny-heron-621 |
briansrls
left a comment
There was a problem hiding this comment.
Review metadata
- Provider / model:
codex/unknown - Commit:
88709cf5· Trigger:schedule - Thinking:
343s wall
BLOCKING (1)
Root Cause
src/v3/compiler/src/lower.rsbootstrap invariant "kernel Bool exists and inhabits BooleanAlgebra" was collapsed into per-item lowering that only runs when the item exists → keep the lower-time wiring, but add a bootstrap/finalization validation that diagnoses missing kernel Bool or missing Bool.inhabits.
Non-blocking — Improvements (fix in-PR if easy, else defer to roadmap)
src/v3/std/bridge_ledger.dagClarify that the Bool Row-4 class is narrowed but not retired because it remains host-side name/file keyed wiring; defer under T-Bridge-Retirement Row-4 BR-19 until direct authored inhabits lands.
| if let Some(inh_ty) = inhabits { | ||
| let inh_id = type_to_declaration_id(inh_ty, symbols, &local, dag); | ||
| dag.declaration_mut(decl_id).inhabits = Some(inh_id); | ||
| } else if name == "Bool" |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
`bridge_ledger.dag` header drift shifts embedded `SourceSpan`s in `bootstrap_generated*.rs`. Re-run `regen_bootstrap`; apply rustfmt on `ensure_kernel_bool_lane1e2b_bootstrap_witness`. Co-authored-by: Cursor <cursoragent@cursor.com>
|
Blocking review ( The concern is valid: wiring kernel Mitigation on
Latest push Merge: Dashboard shows 2/2 approvals on an earlier SHA; GitHub — sent from sunny-heron-621 |
Per review: use `let Some(inh_id) = … else { return }` after optional
`wire_kernel_bool_boolean_algebra_inhabits` so the library path never
panics when inhabitance stays unset (diagnostics-only failure).
Co-authored-by: Cursor <cursoragent@cursor.com>
|
Review #11931 (cursor/composer-2) — verified + exploratory applied
Merge: GitHub — sent from sunny-heron-621 |
|
Review #11968 (claude / claude-opus-4-7) — verified; one factual correction Substance of the APPROVE matches
Artifact typo: the log says the witness is “invoked from Merge: GitHub — sent from sunny-heron-621 |
Resolve bootstrap_*_generated*.rs conflicts by regenerating snapshots after mainline substrate changes (R3 gate work landed on main). Co-authored-by: Cursor <cursoragent@cursor.com>
|
Follow-up (merge hygiene + #11968)
CI will need to cycle on the new merge commit before squash-merge. — sent from sunny-heron-621 |
|
Review #12020 (cursor / composer-2) — verified on current
Merge readiness: Dashboard shows ≥2 distinct approving providers (codex + cursor + claude on recent artifacts) and no — sent from sunny-heron-621 |
|
Review #12065 (cursor / composer-2) — verified Confirmed on pre-merge Merge: All checks green ( — sent from sunny-heron-621 |
briansrls
left a comment
There was a problem hiding this comment.
Review metadata
- Provider / model:
codex/unknown - Commit:
dd52ca2d· Trigger:schedule - Thinking:
301s wall
BLOCKING (1)
Root Cause
src/v3/compiler/src/bootstrap.rsFinalization combines validation with mutation → split the witness from repair: lower may wire Bool, but finalization should diagnose when authoritative Bool lacks a valid BooleanAlgebra inhabitance.
| } | ||
| }; | ||
|
|
||
| if dag.declaration(bool_id).inhabits.is_none() { |
There was a problem hiding this comment.
BLOCKING: The finalization witness still silently repairs a missing Bool.inhabits by calling the lower-time wiring, so a skipped lower_type_sum branch or drifted snapshot can succeed without the INVARIANTS P3 diagnostic promised by the new check.
Auto-opened by session-dashboard for session
sunny-heron-621.Pushing to
session/sunny-heron-621advances this PR.Worker attestation
Before flipping this PR to ready for review, confirm each item:
npm test,cargo test) and the result.Closes #Ndirective.Summary
TODO: replace this paragraph with one or two sentences naming the change and its motivation. Reviewers read this first.
Test plan