Repository navigation
R3 gate #21: int refinement overflow proven parametric - #2674
Merged
Merged
Conversation
briansrls
marked this pull request as ready for review
May 11, 2026 04:47
Contributor
Author
|
Addressed the P5 receipt finding by replacing the dashboard-template PR body with a concrete hand-Rust deferral receipt: T-PB-B / T-Tests-As-Data-Completeness, ROADMAP.md Hand-Rust census row, plus SG-0 hand-path delta: 0. No code change was needed for this review item. — sent from witty-dove-427 |
briansrls
commented
May 11, 2026
briansrls
left a comment
Contributor
Author
There was a problem hiding this comment.
Review metadata
- Provider / model:
codex/unknown - Commit:
433fa712· Trigger:schedule - Thinking:
141s wall
✅ The test-only expansion looks scoped and clean; it exercises the shared MagnitudeOutOfRange path for Int64, Int128, and UInt64 upper-bound overflow without adding substrate state.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Strengthens the R3 gate #21 receipt for
int_refinement_overflow_proven_parametricby extending the integration coverage for fixed-width integer overflow through the sharedMagnitudeOutOfRangepath. The receipt now covers additional signed/unsigned width refinements, includingInt64, representableInt128::MAX + 1, upperUInt64, and the existingUInt128lower-bound case.This is a test-harness receipt change only; no substrate or compiler runtime behavior is changed.
P5 Receipt
P5 explicit deferral receipt: this PR expands an existing hand-authored v3 Rust integration test under
src/v3/compiler/tests/integration/int_literal_cardinality_test.rswithout adding a new SG-0 path. Lane = T-PB-B / T-Tests-As-Data-Completeness. Concrete ROADMAP row =ROADMAP.md§"Release R1 Program" / "Hand-Rust census" row, which states that the test subset of the SG-0 census migrates to.dagTestClaimdeclarations and trends to zero Rust-authored tests. This PR keeps the receipt in the existing hand-Rust harness because gate #21 needs executable coverage before the Cluster M / gate #84 bulk migration lands.SG-0 hand-path delta: 0 (no edits to
src/v3/compiler/tests/integration/sg0_census_test.rs; no new hand-authored test path added).Test plan
cargo fmt -p v3-compiler— passedcargo test -p v3-compiler --test integration int_refinement_overflow_is_proven_parametric_for_representable_widths -- --nocapture— passed on BuildBuddy