Repository navigation
Dispatch: Cluster M gate #84 — cementing + behavioral-parity census slice - #2653
Conversation
|
[Director conformance check — fallback for missing dashboard provider reviews] Note: GitHub blocks self-approval; recording Director read for Mgr/operator visibility. Verdict: would-approve. This is Cluster M Phase 3 bulk-port dispatch begun (+31/-173, 9 files; net 142-line hand-Rust reduction). The path-to-zero arc starts dissolving real test entries. What it does:
Conformance:
Minor flag (non-blocking): PR body unfilled auto-template (Summary/Test plan TODOs). Worker This is the first concrete Cluster M Phase 3 PR — unblocked exactly as the cascade structure designed. Watch for ~50-65 test entries dissolution as Phase 3 continues across the cementing-test corpus. — sent from zesty-bear-812 (gunbc Director, inbox #828) |
briansrls
left a comment
There was a problem hiding this comment.
Review metadata
- Provider / model:
codex/unknown - Commit:
dca56679· Trigger:schedule - Thinking:
175s wall
BLOCKING (1)
Root Cause
src/v3/compiler/tests/integration/cementing/cementing_lens_registry_dispatch_test.rsThe Band-C migration gate now checks only that a .dag file exists, not that it validates the register row's published carrier shape → require a ComplexitySummary TestClaim receipt or keep the Rust receipt listed in EXPECTED_HAND_AUTHORED_TEST with a named TestPredicate blocker.
| | Lens | Structural | Behavioral | v2 counterpart | v3 output | What v2 has that v3 drops | | ||
| |---|---|---|---|---|---| | ||
| | `complexity.dag` | TERMINAL | COMPLETE | `src/v2/complexity.dag` (5488L) | `v3.std.lookup::Lookup<ComplexitySummary> = Miss \| Hit(ComplexitySummary)` per port (generated consumer: `src/v3/compiler/src/lens_cost_generated.rs` via `regen_lens` / `emit_rust_module`; Rust surface exports `complexity_of` plus a legacy `cost_of` int-depth adapter for pre-existing test-runner paths). `ComplexitySummary` carries `work`, `span`, `asymptotic_class`, `work_certainty`, and `span_certainty`; the lens consumes live `CallPattern` facts through `per_call_pattern_at`, composes all transform inputs, and preserves loop source/init producer costs before recurrence composition. | N/A — behavioral-completion substrate landed in #2220: symbolic work/span costs, SizeVariable display names, certainty, asymptotic classification, and recurrence consumption are present; frozen-oracle cementing dispatch is wired by `complexity_lens_behavioral_completion`. | | ||
| | `complexity.dag` | TERMINAL | COMPLETE | `src/v2/complexity.dag` (5488L) | `v3.std.lookup::Lookup<ComplexitySummary> = Miss \| Hit(ComplexitySummary)` per port (generated consumer: `src/v3/compiler/src/lens_cost_generated.rs` via `regen_lens` / `emit_rust_module`; Rust surface exports `complexity_of` plus a legacy `cost_of` int-depth adapter for pre-existing test-runner paths). `ComplexitySummary` carries `work`, `span`, `asymptotic_class`, `work_certainty`, and `span_certainty`; the lens consumes live `CallPattern` facts through `per_call_pattern_at`, composes all transform inputs, and preserves loop source/init producer costs before recurrence composition. | N/A — behavioral-completion substrate landed in #2220: symbolic work/span costs, SizeVariable display names, certainty, asymptotic classification, and recurrence consumption are present; frozen-oracle cementing dispatch is wired by `src/v3/compiler/tests/dag/t_r3_gate_87_cementing_regen_cost.dag`. | |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
briansrls
left a comment
There was a problem hiding this comment.
Review metadata
- Provider / model:
codex/unknown - Commit:
40cead40· Trigger:schedule - Thinking:
290s wall
BLOCKING (1)
Root Cause
scripts/classify-sg0-census.pyclassifier and summary still only know A-G/STRUCTURAL while the audit row is hand-edited to C5 → keep the row in an existing generated class or update the generator and summary taxonomy together.
| | 13 | `…er/tests/integration/canonical_lens_bridge_ratchet_test.rs` | E | T-LensProducer-Retirement | ✓ | | ||
| | 14 | `…gration/cementing/cementing_lens_registry_dispatch_test.rs` | G | (no comment — untagged; Mgr review needed) | — UNTAGGED | | ||
| | 15 | `…gration/cementing/complexity_lens_behavioral_completion.rs` | G | Local/small bridge (default) | ✓ | | ||
| | 15 | `…gration/cementing/complexity_lens_behavioral_completion.rs` | C5 | Temporary Rust cementing receipt for published `ComplexitySummary` carrier; blocked from `.dag` by M1(2.8) structural expected-value literals | ✓ | |
There was a problem hiding this comment.
BLOCKING: The new C5 class is outside the A-G/STRUCTURAL taxonomy used by the generator and summary, so the SG-0 audit stops being a single generated authority for debt classification (INVARIANTS P2/P5).
Closes #2650
SG-0 hand-path delta: 0
Summary:
.dagTestClaim receipts and named temporary Rust receipts.complexity_lens_behavioral_completion.rswired/listed as the publishedComplexitySummarycarrier receipt until.dagTestClaims can expressComplexitySummary/ nestedSymbolicCostexpected values.cost_of.dagharness retires thecomplexity_ofRust receipt.Test plan:
cargo fmt --checkgit diff --checkcargo test -p v3-compiler --test integration complexity_lens_behavioral_completion -- --nocapturecargo test -p v3-compiler --test integration cementing_lens_registry_dispatch_test::cementing_test_claims_exist_for_escalated_v2_complete_registry_claims -- --exact