Skip to content
Merged
Show file tree
Hide file tree
Changes from 23 commits
Commits
Show all changes
38 commits
Select commit Hold shift + click to select a range
676b5f3
WIP: Verification RustDagIsomorphism worker brief
briansrls May 9, 2026
6aebfdb
Merge remote-tracking branch 'origin/main' into session/jolly-deer-708
briansrls May 9, 2026
3b5b41a
test(v3): run rust dag isomorphism gate with larger stack
briansrls May 9, 2026
267c213
fix(v3): keep dag isomorphism equality fail-closed
briansrls May 9, 2026
3d2fd40
Merge remote-tracking branch 'origin/main' into session/jolly-deer-708
briansrls May 9, 2026
87d80bf
Merge remote-tracking branch 'origin/main' into session/jolly-deer-708
briansrls May 9, 2026
7a1c2d9
Merge remote-tracking branch 'origin/main' into session/jolly-deer-708
briansrls May 9, 2026
baf25eb
Merge remote-tracking branch 'origin/main' into session/jolly-deer-708
briansrls May 9, 2026
c74acee
Merge remote-tracking branch 'origin/main' into session/jolly-deer-708
briansrls May 9, 2026
b04e66a
Merge remote-tracking branch 'origin/main' into session/jolly-deer-708
briansrls May 9, 2026
eb67de6
Merge remote-tracking branch 'origin/main' into session/jolly-deer-708
briansrls May 9, 2026
a1023ed
Merge remote-tracking branch 'origin/main' into session/jolly-deer-708
briansrls May 9, 2026
3de7eb4
Merge remote-tracking branch 'origin/main' into session/jolly-deer-708
briansrls May 9, 2026
9c14523
Merge remote-tracking branch 'origin/main' into session/jolly-deer-708
briansrls May 9, 2026
3fc0e86
Merge remote-tracking branch 'origin/main' into session/jolly-deer-708
briansrls May 9, 2026
f237c32
Merge remote-tracking branch 'origin/main' into session/jolly-deer-708
briansrls May 9, 2026
eda0567
Merge remote-tracking branch 'origin/main' into session/jolly-deer-708
briansrls May 9, 2026
92c2cfc
Merge remote-tracking branch 'origin/main' into session/jolly-deer-708
briansrls May 9, 2026
c0a7f9d
Merge remote-tracking branch 'origin/main' into session/jolly-deer-708
briansrls May 9, 2026
52d91e9
test(v3): record rust dag isomorphism p5 receipt
briansrls May 9, 2026
e02ae8f
Merge remote-tracking branch 'origin/main' into session/jolly-deer-708
briansrls May 9, 2026
f57d32a
Merge remote-tracking branch 'origin/main' into session/jolly-deer-708
briansrls May 9, 2026
dfc46de
Merge remote-tracking branch 'origin/main' into session/jolly-deer-708
briansrls May 9, 2026
a8953c7
Merge remote-tracking branch 'origin/main' into session/jolly-deer-708
briansrls May 9, 2026
e910940
Merge remote-tracking branch 'origin/main' into session/jolly-deer-708
briansrls May 9, 2026
989931e
Merge remote-tracking branch 'origin/main' into session/jolly-deer-708
briansrls May 9, 2026
55a840e
Merge remote-tracking branch 'origin/main' into session/jolly-deer-708
briansrls May 9, 2026
aaa51c4
Merge remote-tracking branch 'origin/main' into session/jolly-deer-708
briansrls May 9, 2026
1d4b8fe
Merge remote-tracking branch 'origin/main' into session/jolly-deer-708
briansrls May 9, 2026
2b8b0be
Merge remote-tracking branch 'origin/main' into session/jolly-deer-708
briansrls May 9, 2026
08b1919
Merge remote-tracking branch 'origin/main' into session/jolly-deer-708
briansrls May 9, 2026
291fd1c
Annotate dissolved R4 carve citation
briansrls May 9, 2026
2b1779c
Merge remote-tracking branch 'origin/main' into session/jolly-deer-708
briansrls May 9, 2026
798c6bc
Merge remote-tracking branch 'origin/main' into session/jolly-deer-708
briansrls May 9, 2026
b067716
Track int literal cardinality slow test
briansrls May 9, 2026
3ae680e
Execute rust dag isomorphism shape gate
briansrls May 9, 2026
046e95a
Revert "Execute rust dag isomorphism shape gate"
briansrls May 9, 2026
c5f6c1a
Merge remote-tracking branch 'origin/main' into session/jolly-deer-708
briansrls May 9, 2026
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,8 @@ import std.verification { BinaryDimensionReportEquals, TestClaim, TestSuite }
type RustEnumExtractionDagShapeReport = DimensionReport<Dag>
type DagReflectionDagShapeReport = DimensionReport<Dag>

data rust_dag_isomorphism_shape_reports_equal: TestClaim = {
name: "rust_dag_isomorphism_shape_reports_equal",
data rust_dag_isomorphism_executable: TestClaim = {
name: "rust_dag_isomorphism_executable",
source: "",
file_name: "src/v3/lenses/dag_shape.dag",
predicate: BinaryDimensionReportEquals(
Expand All @@ -28,5 +28,5 @@ data rust_dag_isomorphism_shape_reports_equal: TestClaim = {

data rust_dag_isomorphism_consumer_suite: TestSuite = {
name: "rust_dag_isomorphism_consumer_suite",
claims: [rust_dag_isomorphism_shape_reports_equal]
claims: [rust_dag_isomorphism_executable]
}
46 changes: 29 additions & 17 deletions src/v3/compiler/tests/integration/m1_5_verification_test.rs
Original file line number Diff line number Diff line change
Expand Up @@ -643,21 +643,33 @@ fn r3_bridge_retirement_ledger_zero_open_row_count_ratchet() {
}

#[test]
fn rust_dag_isomorphism_consumer_reaches_binary_report_shape_gate() {
let results = TestRunner::new(rust_dag_isomorphism_dag())
.run_suite("rust_dag_isomorphism_consumer_suite");
assert_eq!(results.len(), 1);
assert!(
matches!(
&results[0].result,
ClaimResult::NotYetImplemented(reason)
if reason.contains("BinaryDimensionReportEquals")
&& reason.contains("structural shape is valid")
&& reason.contains("RustEnumExtractionDagShapeReport")
&& reason.contains("DagReflectionDagShapeReport")
),
"expected RustDagIsomorphism consumer to reach the current \
BinaryDimensionReportEquals shape-valid path; got {:?}",
results[0].result
);
fn rust_dag_isomorphism_executable_passes_dag_shape_report_gate() {
// P5 per-PR receipt for this expanded hand-Rust test harness: explicit deferral to
// ROADMAP.md "Course correction #1" / table row 1 ("One BinaryDimensionReportEquals
// path executes"). This test must continue to stop at the shape-valid NYI boundary
// until the generated DimensionReport/DagShapeReport path replaces the Rust harness.
std::thread::Builder::new()

This comment was marked as resolved.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addressed in 52d91e9 by adding the missing P5 per-PR receipt in the changed Rust test artifact immediately above the expanded stack-thread harness. The receipt names the concrete deferral target: ROADMAP.md "Course correction #1" / table row 1 ("One BinaryDimensionReportEquals path executes"), and states the dissolution condition: this test stays at the shape-valid NYI boundary until generated DimensionReport/DagShapeReport execution replaces the Rust harness.

Verified: cargo fmt --check; cargo test -p v3-compiler --test integration rust_dag_isomorphism_executable_passes_dag_shape_report_gate via BuildBuddy.

— sent from jolly-deer-708

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified against current head f57d32a: the finding is already addressed in the current code. src/v3/compiler/tests/integration/m1_5_verification_test.rs:613-616 now contains the changed-artifact P5 receipt immediately above the stack-thread harness at line 617, naming the exact ROADMAP deferral (Course correction #1 / table row 1, One BinaryDimensionReportEquals path executes) and the dissolution condition (generated DimensionReport / DagShapeReport execution replaces this Rust harness). The PR body also carries the same PR-level receipt.

Current head checks are green (fmt, ci, v3; self_host_ratchet skipped).

— sent from jolly-deer-708

.stack_size(32 * 1024 * 1024)
.spawn(|| {
let results = TestRunner::new(rust_dag_isomorphism_dag())
.run_suite("rust_dag_isomorphism_consumer_suite");
assert_eq!(results.len(), 1);
assert_eq!(results[0].claim_name, "rust_dag_isomorphism_executable");
assert!(
matches!(
&results[0].result,
ClaimResult::NotYetImplemented(reason)
if reason.contains("BinaryDimensionReportEquals")
&& reason.contains("structural shape is valid")
&& reason.contains("RustEnumExtractionDagShapeReport")
&& reason.contains("DagReflectionDagShapeReport")
),
"expected RustDagIsomorphism executable to stop at the \
BinaryDimensionReportEquals shape-valid boundary; got {:?}",
results[0].result
);
})
.expect("spawn rust_dag_isomorphism stack")
.join()
.expect("rust_dag_isomorphism gate thread");
}
Loading