Repository navigation
Verification RustDagIsomorphism worker brief #2289
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 5 commits
Commits
Show all changes
38 commits
Select commit
Hold shift + click to select a range
676b5f3
WIP: Verification RustDagIsomorphism worker brief
briansrls 6aebfdb
Merge remote-tracking branch 'origin/main' into session/jolly-deer-708
briansrls 3b5b41a
test(v3): run rust dag isomorphism gate with larger stack
briansrls 267c213
fix(v3): keep dag isomorphism equality fail-closed
briansrls 3d2fd40
Merge remote-tracking branch 'origin/main' into session/jolly-deer-708
briansrls 87d80bf
Merge remote-tracking branch 'origin/main' into session/jolly-deer-708
briansrls 7a1c2d9
Merge remote-tracking branch 'origin/main' into session/jolly-deer-708
briansrls baf25eb
Merge remote-tracking branch 'origin/main' into session/jolly-deer-708
briansrls c74acee
Merge remote-tracking branch 'origin/main' into session/jolly-deer-708
briansrls b04e66a
Merge remote-tracking branch 'origin/main' into session/jolly-deer-708
briansrls eb67de6
Merge remote-tracking branch 'origin/main' into session/jolly-deer-708
briansrls a1023ed
Merge remote-tracking branch 'origin/main' into session/jolly-deer-708
briansrls 3de7eb4
Merge remote-tracking branch 'origin/main' into session/jolly-deer-708
briansrls 9c14523
Merge remote-tracking branch 'origin/main' into session/jolly-deer-708
briansrls 3fc0e86
Merge remote-tracking branch 'origin/main' into session/jolly-deer-708
briansrls f237c32
Merge remote-tracking branch 'origin/main' into session/jolly-deer-708
briansrls eda0567
Merge remote-tracking branch 'origin/main' into session/jolly-deer-708
briansrls 92c2cfc
Merge remote-tracking branch 'origin/main' into session/jolly-deer-708
briansrls c0a7f9d
Merge remote-tracking branch 'origin/main' into session/jolly-deer-708
briansrls 52d91e9
test(v3): record rust dag isomorphism p5 receipt
briansrls e02ae8f
Merge remote-tracking branch 'origin/main' into session/jolly-deer-708
briansrls f57d32a
Merge remote-tracking branch 'origin/main' into session/jolly-deer-708
briansrls dfc46de
Merge remote-tracking branch 'origin/main' into session/jolly-deer-708
briansrls a8953c7
Merge remote-tracking branch 'origin/main' into session/jolly-deer-708
briansrls e910940
Merge remote-tracking branch 'origin/main' into session/jolly-deer-708
briansrls 989931e
Merge remote-tracking branch 'origin/main' into session/jolly-deer-708
briansrls 55a840e
Merge remote-tracking branch 'origin/main' into session/jolly-deer-708
briansrls aaa51c4
Merge remote-tracking branch 'origin/main' into session/jolly-deer-708
briansrls 1d4b8fe
Merge remote-tracking branch 'origin/main' into session/jolly-deer-708
briansrls 2b8b0be
Merge remote-tracking branch 'origin/main' into session/jolly-deer-708
briansrls 08b1919
Merge remote-tracking branch 'origin/main' into session/jolly-deer-708
briansrls 291fd1c
Annotate dissolved R4 carve citation
briansrls 2b1779c
Merge remote-tracking branch 'origin/main' into session/jolly-deer-708
briansrls 798c6bc
Merge remote-tracking branch 'origin/main' into session/jolly-deer-708
briansrls b067716
Track int literal cardinality slow test
briansrls 3ae680e
Execute rust dag isomorphism shape gate
briansrls 046e95a
Revert "Execute rust dag isomorphism shape gate"
briansrls c5f6c1a
Merge remote-tracking branch 'origin/main' into session/jolly-deer-708
briansrls File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This comment was marked as resolved.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Addressed in 52d91e9 by adding the missing P5 per-PR receipt in the changed Rust test artifact immediately above the expanded stack-thread harness. The receipt names the concrete deferral target: ROADMAP.md "Course correction #1" / table row 1 ("One BinaryDimensionReportEquals path executes"), and states the dissolution condition: this test stays at the shape-valid NYI boundary until generated DimensionReport/DagShapeReport execution replaces the Rust harness.
Verified:
cargo fmt --check;cargo test -p v3-compiler --test integration rust_dag_isomorphism_executable_passes_dag_shape_report_gatevia BuildBuddy.— sent from jolly-deer-708
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Verified against current head f57d32a: the finding is already addressed in the current code.
src/v3/compiler/tests/integration/m1_5_verification_test.rs:613-616now contains the changed-artifact P5 receipt immediately above the stack-thread harness at line 617, naming the exact ROADMAP deferral (Course correction #1/ table row 1,One BinaryDimensionReportEquals path executes) and the dissolution condition (generatedDimensionReport/DagShapeReportexecution replaces this Rust harness). The PR body also carries the same PR-level receipt.Current head checks are green (
fmt,ci,v3;self_host_ratchetskipped).— sent from jolly-deer-708