Repository navigation
valiant-carp-10 - #1901
Closed
briansrls wants to merge 23 commits into
Closed
valiant-carp-10#1901briansrls wants to merge 23 commits into
briansrls wants to merge 23 commits into
Conversation
Remove the integration_test_support shim from the compiler crate; the harness uses a neutral Behavior.Value id placeholder instead. Keep acceptance within evaluable constructors: avoid runtime std cons on the Inhabits path, document deferred Violates/list-monoid work, and seed List<τ>.Empty rows in the fixture so the test can reuse lowering-emitted Instantiation tags via find_list_empty_constructor_tag (no Dag mutation). Targeted integration test passes. Co-authored-by: Cursor <cursoragent@cursor.com>
Brian's review: DimensionOk.witnesses must carry the same Inhabits(c) as composed per #1844/#1853. Build the witness list with List variant Cons { head: Inhabits(c), tail: Empty } instead of std cons/singleton (Unparsed arrows) or an unrelated empty list. Reinstate witnesses_inhabits(c) on DimensionOk/DimensionFail and assert the witness Value still contains literal 1. Co-authored-by: Cursor <cursoragent@cursor.com>
Bind the integration test to on-tree worker brief + feasibility probe via include_str! so cargo fails if paths are missing (P1/P5 checkable receipt independent of PR diff file list). Co-authored-by: Cursor <cursoragent@cursor.com>
Move TransformTarget::Callable assertions for mini_read / mini_validate into e6_g1a_option3_fixture_lowers_mini_read_and_mini_validate_as_callable_transforms so mini_report_executes_without_reflection_imports stays behavior-only. Co-authored-by: Cursor <cursoragent@cursor.com>
Add EXPECTED_HAND_AUTHORED_TEST lines for list_variant_tags.rs and e6_g1a_option3_static_lens_test.rs (E6-G1.a / #1853 brief + receipts). Co-authored-by: Cursor <cursoragent@cursor.com>
e6_g1a_option3_static_lens_test.rs must precede e_i_lane_* (6 < _). Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Contributor
Author
|
Closing as duplicate/stale branch state. This branch is the already-delivered No new review vehicle is needed for this branch. Active E6-G1.a work remains closed via #1857 / #1868. — sent from merry-gull-128 |
This was referenced May 6, 2026
Contributor
Author
|
Verified: — sent from valiant-carp-10 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Opened from session-dashboard for session
valiant-carp-10.