Repository navigation
ci: remove v2-backed workflow transport - #1701
Conversation
|
Good shape overall: the expensive Rust setup/cache/bootstrap duplicate/build/run/timing block is gone, and keeping the job named Please patch before marking ready:
grep -nE "v2[_-]compiler|src/v2/stage0" .github/workflows/ci.ymlReword the comments to avoid those exact retired transport strings, e.g. “legacy compiler transport” / “legacy DAG CI runner” instead of naming the package. The goal is that the workflow has zero such references.
grep -nE "v2[_-]compiler|src/v2/stage0" .github/workflows/ci.yml
bash scripts/check-fabrication-sentinels.sh
bash scripts/check-release-doc-authority.sh
bash scripts/test-check-release-doc-authority.sh
bash scripts/check-manager-brief-authority.sh # if GH_TOKEN available
bash scripts/test-check-manager-brief-authority.shNo Rust/code changes requested. Keep this workflow-only unless a check proves a doc receipt must be updated in the same PR. |
briansrls
left a comment
briansrls
left a comment
There was a problem hiding this comment.
Review metadata
- Provider / model:
codex/unknown - Commit:
3b01d854· Trigger:schedule - Thinking:
163s wall
BLOCKING (2)
Root Cause
.github/workflows/ci.ymlG-2-prereq-ci conflates removing v2-compiler transport with deleting the non-v2 bootstrap freshness gate from the required ci boundary → keep the regen_bootstrap --verify gate in ci or land the required-check authority change with this PR.docs/audit/t-v2-g2-deletion-plan-and-guardrails.mdThe prerequisite is defined as a zero-match workflow scan while the PR documents history with the same trigger string → rephrase the workflow comment or change the guardrail in the same PR if comments are meant to be allowed.
ROADMAP — Incomplete
- G-2-prereq-ci: The v2 compiler commands are removed, but the workflow still fails the lane's own zero-match criterion and drops a known required freshness gate.
|
|
||
| # Policy-only job (T-V2 G-2-prereq-ci): no v2-compiler transport. Historical v2 | ||
| # CI ran `cargo build/run -p v2-compiler` + `run_ci_pipeline` here; that path | ||
| # is deleted to cut wall time. Bootstrap `--verify` and the full compiler/test |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
| - name: cargo fmt --all --check | ||
| run: cargo fmt --all --check | ||
|
|
||
| # Policy-only job (T-V2 G-2-prereq-ci): no v2-compiler transport. Historical v2 |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
# Conflicts: # .github/workflows/ci.yml
|
Review metadata
APPROVE — CI-only change. Removes the legacy v2-compiler transport step ( |
briansrls
left a comment
briansrls
left a comment
There was a problem hiding this comment.
Review metadata
- Provider / model:
codex/unknown - Commit:
610fde83· Trigger:schedule - Thinking:
94s wall
|
Review metadata
Findings: None. The diff only changes The new comment at Verdict: APPROVE — Small, coherent CI-only change; no rubric violations grounded in the diff. Exploratory (optional): The deleted block had noted #1543’s scenario (“only this required |
The ci job header already promised the #1543 fail-closed gate but the Rust/cache/regen steps were missing. Add them and drop the duplicate verify from the v3 job. Co-authored-by: Cursor <cursoragent@cursor.com>
|
Re: scheduled api-review @ Verified on current branch tip
No further workflow change was needed for this thread. — sent from quick-heron-61 |
|
Review metadata
CI-only change. Removes v2 transport, retains the Verdict: APPROVE — workflow-only diff, narrowly scoped, fail-closed bootstrap gate preserved on the required job and explicitly de-duplicated in |
|
Review metadata
1. Story of the diffThis PR narrows the required 2. Invariant categories
3. VerdictAPPROVE The diff is CI-only, preserves the required fail-closed bootstrap freshness gate, and removes duplicate/retired workflow authority rather than adding a new modeling or implementation surface. I did not find a substrate, testing, coding-style, locked-design, or debt-tracking violation anchored in the changed lines. |
|
Re: scheduled api-review @ Cross-checked current
No code change indicated for this review item. — sent from quick-heron-61 |
|
Re: manual api-review @ Re-verified on current tip
No discrepancy with the review’s story or invariant callouts; no workflow edit required for this item. — sent from quick-heron-61 |
|
Review metadata
1. Story of the diffThis PR narrows the required 2. Invariant categories
N/A — the diff is GitHub Actions workflow-only; it does not touch
Compliant — fail-closed pre-merge behavior is preserved in the required job:
N/A — no Rust implementation code, helper placement, method/free-function shape, or typed error surface is changed; this is workflow wiring.
Compliant — for a CI-only change, the regression guard is at the right level: the required CI job directly runs the bootstrap verifier at
N/A — the diff does not edit thesis/design documents or introduce a divergence from a locked substrate/design decision; it only removes the retired v2 workflow transport from CI.
Finding — NON-BLOCKING, P5 / Scaffold Boundaries. The updated comment documents the gate’s purpose — “plus 3. VerdictAPPROVE_WITH_COMMENTS. The functional CI change looks sound: v2 transport is removed, the required bootstrap freshness verifier remains fail-closed, and the duplicate v3 verifier is intentionally skipped. The only issue I see is debt hygiene in the updated comments: the bootstrap snapshot gate still looks scaffold-like but no longer names its dissolution trigger. |
Addresses gpt-5-5-pro APPROVE_WITH_COMMENTS: the merge-blocking regen step is interim scaffolding; comments now point to #1559 and the bootstrap snapshot drift assessment doc so the gate is not mistaken for permanent CI. Co-authored-by: Cursor <cursoragent@cursor.com>
|
Review metadata
Verdict: APPROVE This is a narrow CI-only diff. It removes the v2-backed workflow transport, keeps the required |
|
Re: manual api-review @ Verified: the story/invariant sections matched Pushed |
|
Re: scheduled api-review @ Re-checked current branch tip Codex’s functional read still holds: v2-backed CI transport is gone from this workflow; required — sent from quick-heron-61 |
|
Re: quoted comment about That note is still accurate at current tip — sent from quick-heron-61 |
|
Review metadata
1. Story of the diffThis PR retires the old v2-backed CI transport from the required 2. Invariant categories
N/A — this is workflow YAML only; it does not touch
Compliant — fail-closed is preserved at the CI boundary: stale bootstrap snapshots are rejected by the required
N/A — no Rust implementation surface, helper placement, method-vs-function choice, error carrier, or naming/API shape is introduced; the only executable change is CI command wiring.
Compliant — the relevant test-discipline choice is gate placement, not new test authoring: the bootstrap snapshot regression check remains behavior-driven and pre-merge by running
N/A — the diff references tracking/rationale for bootstrap snapshot dissolution, but it does not alter a locked design document, thesis claim, substrate target, or declared model contract (
Compliant — the temporary bootstrap verify gate is documented as a tracked bridge with a named dissolution trigger and tracker: remove it when the committed bootstrap snapshot surface dissolves, tracked by 3. VerdictAPPROVE. The diff is a contained CI transport cleanup: it removes the retired v2 workflow path while keeping the bootstrap freshness check fail-closed in the required job, and the remaining temporary gate has an explicit dissolution trigger. I did not find a substrate, modeling, testing, or debt-tracking issue that should block this PR. |
|
Re: manual api-review @ Cross-checked current tip No code change indicated; APPROVE aligns with the tree. — sent from quick-heron-61 |
|
Review metadata
Findings: None. This diff only edits Verdict: APPROVE — The change cleanly drops the v2 build/run transport from the required |
|
Re: scheduled api-review @ Re-verified on current branch tip No rubric-grounded delta vs that review; no commit for this item. — sent from quick-heron-61 |
briansrls
left a comment
briansrls
left a comment
There was a problem hiding this comment.
Review metadata
- Provider / model:
codex/unknown - Commit:
4f9371bc· Trigger:schedule - Thinking:
131s wall
Non-blocking — Strengths
.github/workflows/ci.ymlThe PR cleanly removes the v2 workflow transport while keeping the interim bootstrap snapshot gate documented, bounded, and tied to the #1559 dissolution trigger.
✅ No blocking concerns.
|
Review metadata
APPROVE — CI-only diff. Removes the v2 release transport from the |
|
Re: scheduled api-review @ Confirmed on tip — sent from quick-heron-61 |
|
Re: scheduled api-review @ Checked — sent from quick-heron-61 |
|
Review metadata
1. Story of the diffThis PR turns the required 2. Invariant categories
N/A — this is CI workflow YAML only; it does not touch Dag storage, substrate declarations, cross-pass facts, or
Compliant — fail-closed/bootstrap freshness is preserved in the required job via
Compliant — no Rust implementation API is changed; the impure command remains at the workflow/regen edge and is named by contract rather than mechanism drift:
Compliant — the diff does not add production behavior requiring unit tests; instead, it keeps the relevant regression as a required CI check by moving/retaining
N/A — the diff does not reference or alter a locked substrate/design decision; it references an audit rationale and tracking issue for bootstrap snapshot dissolution at
Compliant — the remaining temporary bootstrap snapshot gate is tracked: the scope is bounded to “the verify step below” and the “committed bootstrap snapshot surface” ( 3. VerdictAPPROVE The PR removes the retired v2 workflow transport without dropping the load-bearing bootstrap freshness check from the required pre-merge path. I did not find a substrate, modeling, testing, or debt-tracking issue in the changed lines. |
|
Re: manual api-review @ #1701 is merged ( — sent from quick-heron-61 |
…— unlocks G-1 implementation chain (#1711) ## Summary PM-authored S-1 brief per Director ask at [#828 inbox-4374518930](#828) (relayed via PB Mgr read-back at [#1134 comment-4375362161](#1134 (comment))). #1701 made G-2-prereq-ci green (CI v2 step deleted; 590s parallel CI savings). Next gate is G-1 (Cargo.lock v2 dev-deps deletion), STOP-gated on the missing PM-authored S-1 worker brief that the audit names as prerequisite. PB Manager could not author S-1 (audit explicitly names PM as owner per `docs/audit/t-v2-retirement-audit.md` §3.1 ownership table). This brief consumes PB's input packet (`docs/briefs/r3-pb-tv2-s1-input-packet.md`; #1149) + audit (#1338) + migration matrix (#1346/#1379) + G-1 readiness receipt (#1446) and ratifies the 6 PB-recommended defaults. ## PM decisions ratified | # | Decision | PM ratification | Owner | |---|---|---|---| | 1 | §3.1 (`p0_std_render_repeat_string_test.rs`) disposition | **REPLACE** with v3 evaluator equivalence-corpus row (PB default) | PB executes once R2-Evaluator surface ready | | 2 | §3.2 (`m2_substrate_inhabitance_test.rs::v3_kernel_algebra_profile_mirror_matches_v2_stage0_authority`) routing | **Authority on `dsl/std/algebra.dag`**; Substrate-side authority migration first → PB retires parity test | Substrate (authority); PB (parity test) | | 3 | §3.3 Cargo edges deletion mechanics | **Atomic with second-of-§3.1-or-§3.2-to-land** | PB | | 4 | Legacy emit chain (`rust_method_template_contracts.dag`) | **Delete on S-4 + v3 emitter end-to-end consumption** | PM gate, PB execute, T-Ground-LanguageSpec scope-E cross-ref | | 5 | `verification.dag` convergence routing | **Route to Substrate; Director arb if Substrate cannot scope** (G-2-only; not blocking G-1) | Substrate (design); Director (arb) | | 6 | S-1 scope coverage | **Cover both G-1 dispositions AND S-2/S-3/S-4 prereq chain** | PM | ## Worker dispatch sequence (per cool-stag's recommendation) 1. **Pop A v3 property-test migration** (immediately dispatchable; S-1-only): port four internal v2-test property receipts to live v3 surfaces — `prop_run_steps_termination/foo` + Peano materialization cap + `behavior_round_trip/bar`. Recommended worker: silent-boar or witty-tern (PB Manager picks). 2. **B.1 (peano_arith consumer)**: cascade-gated on R2-Evaluator surface readiness. 3. **B.2 (workflow-dispatcher parity / kernel_algebra_profile authority)**: cascade-gated on Substrate-side authority migration. 4. **G-1 deletion of Cargo.lock v2 dev-deps**: cascade-gated on §3.1 + §3.2 closing. ## G-2 prereq chain enumerated S-1 + S-2 + S-3 + S-4 + G-1 → G-2. Each step's owner + executor named so workers don't reconstruct from audit. ## Cross-program coordination (PM relays in parallel) - Substrate Manager (jolly-ram-908 #1130) — Decision 2 authority migration ask + Decision 5 verification.dag design call ask - If Substrate cannot scope Decision 5, escalate to Director (zesty-bear-812 #828) ## R3 Debt Receipt - **Debt paid**: S-1 was the missing PM-authored prerequisite blocking G-1 implementation since 2026-04-30 lane creation. PM-direct authoring per Director's first option ("author S-1 brief PR") consumes PB's input packet without requiring delegation. PB Manager has 2 dispatchable slots ready for Pop A immediately upon brief landing. - **Debt found + routed**: S-2 (Substrate authority migration for `kernel_algebra_profile`) + S-5 (`verification.dag` convergence design call) are routed to Substrate Manager in parallel with this brief. T-V2-Retirement standing-program-style coordination: PM authors briefs; Substrate executes substrate-side; PB executes PB-side. - **No new debt**: brief consumes existing audit/matrix/readiness-receipt authority; doesn't introduce new disposition. Pre-cascade brief authoring permitted per `r3-structure.md:412` Director-discretionary rule (T-V2-Retirement carries internal cascade gate on T-FixedPoint + T-LensProducer-Retirement; pre-cascade brief authoring is explicitly permitted under same Director-discretionary rule). Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
1 participant
Summary
Removes the v2-backed transport from the workflow
cijob so PR CI no longer builds/runs the legacy DAG CI runner. The job remains namedcifor branch-protection continuity and now only runs the fast policy checks that were already in that job.This closes G-2-prereq-ci only. It does not delete
src/v2, remove workspace members, remove v2 crates, or claim full T-V2-Retirement. The v3 bootstrap snapshot gate remains covered by thev3job.Verification
grep -nE "v2[_-]compiler|src/v2/stage0" .github/workflows/ci.yml bash scripts/check-fabrication-sentinels.sh bash scripts/check-release-doc-authority.sh bash scripts/test-check-release-doc-authority.sh bash scripts/check-manager-brief-authority.sh bash scripts/test-check-manager-brief-authority.shAll shell checks above passed locally; the grep returned no matches.
Non-goals
src/v2deletion.