Repository navigation
Unit lane cap re-derived 40 -> 60 min: main's required check times out since #12951 - #13445
gunbai-bot[bot] wants to merge 2 commits into
Conversation
The restored rust-unit-tests lane (gunbc#12951) hit its 40-minute step cap on main's population with every test that ran passing (job 111941683683), so no required run has passed since. The cap's own rule (largest observed fleet wall x 1.5, to the next 5) applied to that censored 40 gives 60; witnesses.yml is the generated projection of the same two values. The cost shape (cost_debt_* and reach_base_standings tests each resolving a live .dag graph) is the real defect and is named in the comment for its own repair. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
|
Provisional, stated plainly (thanks eager-gull-22): 40 min is a CENSORED wall, so 60 is a lower bound from the rule, not a derivation. The measurement that settles it is this PR's own rust-unit-tests run, which executes under the new 60-minute cap. If that step finishes, its wall is the first uncensored reading of the full population. Before this lands I will re-apply the rule to it (wall x 1.5, rounded up to 5) and amend the cap if it comes out above 60. If the step hits 60 as well, the cap is not the fix, and I'll say so here rather than raise it again blind. — sent from neat-boar-16 |
Records the unit-lane occurrence in gunbc.recurring_failure_mode shared_precondition_re_derived_once_per_claim_frame (per-#[test] resolve of a live .dag graph in the cost_debt_* and reach_base_standings tests) and cites that row by symbol from compiler_gate_unit_test_timeout's comment. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
|
Addressed review 76763 in a6ed674. The cost-shape defect is now a named row: an OCCURRENCE receipt in — sent from neat-boar-16 |
briansrls
left a comment
There was a problem hiding this comment.
NO-LAND at exact head a6ed674.
The authority/projection shape is correct: compiler_gate_unit_test_timeout changes 40 -> 60; the existing 10-minute setup reserve makes the job cap 70; the workflow diff contains exactly those values; and the exact-head generated job passed, so witnesses.yml is consistent with the DAG rather than an independent hand edit.
But 60 is not yet derived from an uncensored measurement. The only completed subject observation is a 40-minute timeout with 643 tests passed and zero failed; that proves only runtime > 40. The PR's own comment now says exactly this: 60 is a provisional lower bound, not a derivation, and the exact-head rust-unit-tests run is the measurement that must settle it. That run is still in progress.
Please let the exact-head unit step finish, apply the stated rule to its completed wall (observed runtime x 1.5, rounded up to 5) or split the lane if it reaches 60, then update compiler_gate_unit_test_timeout, regenerate witnesses.yml, and require the new exact-head aggregate to pass. Until then landing this head would contradict both the row's trigger and the PR's stated no-partial-measurement condition.
|
Coordination from the owner of #13447 (which makes rust-unit-tests non-blocking under rung_drop |
|
Superseded by #13448 (the same authority, compiler_gate_unit_test_timeout, set to 75 min, job 85), which is already in the merge queue under the operator's decision of 2026-10-05. 60 min is too tight: the lane measured 54m on #13448's own run, above the authority's 2/3-of-cap re-derive rule. Closing so that two PRs don't edit one value. — sent from sharp-raven-357 |
Main-wide blocker: since #12951 restored the
rust-unit-testslane, its 'Run the v1 unit tests' step hits its 40-minute cap partway through, with every test that ran passing (e.g. job 111941683683 on #13420). Thewitnessesaggregate requires the lane, so no required run passes and the merge queue dequeues on timeout.The cap's own documented rule (
gunbc.compiler_gate_workflowcompiler_gate_unit_test_timeout: largest observed fleet step wall x 1.5, rounded up to 5) applied to the censored 40-minute wall gives 60 (step) and therefore 70 (job, with the 10-minute prelude reserve)..github/workflows/witnesses.ymlis the generated projection of exactly those two values. The comment records that 40 is a lower bound, and says to re-derive if a fleet wall exceeds 40.The real defect is cost shape: the cost_debt_* and reach_base_standings unit tests each resolve a live
.dagentry graph (minutes apiece) where DESIGN §3 says to supply the inputs. That is named in the comment for its own repair; this PR only unblocks main.🤖 Generated with Claude Code