Advisories 5.4: delete the GUNBC_REALIZE_ADVISORY logger and realize_advisory_soundness - #13016
Merged
Merged
Conversation
…advisory_soundness Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Contributor
Author
|
On the open question in review 74299: — sent from tidy-wolf-843 |
gunbai-bot Bot
pushed a commit
that referenced
this pull request
Oct 3, 2026
- structural_realization_bindings: take main's Peano fixture row and kernel_grounding_rows; the cut's deletion of the Boolean literal row and the connective-row family stands. - emit_rust: a type declaration realizes as a native alias (Bool, this cut) or a kernel- grounded decl (Nat, #12846) before falling back to the connective emission; the use-line filters keep both exclusions. - defork census: the open Nat/Bool row goes; both are in defork_census_resolved. - peano test: main's StructuralNat fixture, without the connective_rows argument or the BooleanUnfold arm. - realize_advisory_soundness: deleted on main (#13016), stays deleted. - Import lines: main's side, with Bool/True/False removed from v2.std.logic imports. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Step 5, item 4 of the advisory program (node adhoc-e84e492c-5ef).
Dead by consumer search at origin/main: no workflow, hook, script or
.dagemission setsGUNBC_REALIZE_ADVISORY. Its only readers were two opt-inif env::var(..).is_ok()gates.v2.workflow.realize_advisory_soundnesswas imported only by its own test module; no observation rows ever fed it, and the runs that would have produced them were cut.Consumers removed (§3c):
v1_compiler.cli_runemit_realize_advisory_for_rowsand its private helperrealize_advisory_optional_int(now unreferenced).bin/claim_batch.rsandcli_run::required_floor_runner.derived_realization_schedule::derive_discovery_schedule_width.emit_realize_advisory_for_rowsDeclarationRefrow ingunbc.interpreter_eval_correctness_seed_growth, since the declaration no longer exists.v2.workflow.realize_advisory_soundnessandv2.test.claim.realize_advisory_soundness_test(six witnesses). These are declared as sixWitnessDeletedarms infloor_grandfathered_removals, and the frozen cut is untouched, per that roster's contract.v2.compiler.self_host.native_routing_frontier.Kept:
std.realize_packrealize_advisory. It is live throughderived_realization_schedule::derive_discovery_schedule_width, which the required floor runner calls, and this PR does not touch it. The soundness witnesses guarded a law with no producer, so no real class loses evidence (§4b(4)).v1-maintenance purpose test (
gunbc.v1_maintenance_standing): this is pure subtraction of an unreached seed path. It removes host-Rust surface the self-host program would otherwise have to account for, and adds no v1 growth.cli_runis hand-authored seed host Rust, not a generated mirror, so no regeneration is involved.Checks:
cargo clippy -p v1-compiler --all-targets -- -D warningspasses (remote). The.dagside is checked by the CI floor.00_compile.dagand04_infer.dagare untouched.🤖 Generated with Claude Code