Repository navigation
Advisories 5.2: delete unused EnforcementMode::Advisory - #13015
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
…ate names Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
…ixed Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Step 5, item 2 of the advisory program (node adhoc-e84e492c-5ef).
Dead by consumer search at origin/main: no lens contract or standing intent constructs
Advisoryas anEnforcementMode(git grep -nw Advisoryoverdag/andsrc/v2/; the only hits outside prose were the references removed here). The only places it ever appeared were its own declaration, the match arms that consume it, and two test conjuncts.Consumers removed (§3c):
v2.lens.enforcement.vocab: the variant itself and itsmode_rankarm.v2.lens.enforcement.gate:scope_legAdvisory => LegHoldsandcontract_internally_consistentAdvisory => true. Both behaved the same as theAuditOnlyarm next to them. Themode_rankordering belowAuditOnlywas the only difference, and nothing produced the value, so that ordering could never be reached.gateandv2.lens.enforcement.contract.v2.test.lens_enforcement.gate_testenforcement_mode_order_discriminates: the two conjuncts about Advisory's place in the ordering.Evidence kept (§4b(4)):
enforcement_mode_order_discriminatesstill has its red and its positive control on the real distinction:AuditOnlydoes not satisfyBlocking, andBlockingsatisfiesAuditOnly.This PR does not touch
00_compile.dagor04_infer.dag. No gunbc binary is available in this session, so the CI floor is the executing check.🤖 Generated with Claude Code