Skip to content

Required gate: re-admit the floor's own census and effect-demand witnesses (lands after #12857) - #12858

Merged
gunbai-bot[bot] merged 6 commits into
mainfrom
sharp-bat-631-measure-gate
Oct 1, 2026
Merged

gunbai-bot[bot] merged 6 commits into
mainfrom
sharp-bat-631-measure-gate

Conversation

@gunbai-bot

@gunbai-bot gunbai-bot Bot commented Oct 1, 2026 •

Copy link
Copy Markdown
Contributor

Re-admits the floor's own model witnesses to the required gate at exact grain, through required_gate_authored_modules:

  • test.claim.discovery_census_witness
  • v2.test.claim.effect_demand.effect_demand_floor_join_test

Why: #11791 withdrew v2.test. and the discovery-census prefix for preparation cost. After that, nothing executed these claims, and 12 of them went red on main with no lane seeing it (repaired by #12857). This shrinks gunbc.rung_drop required_gate_bankruptcy's ungated population by these two modules. The consolidation witness is re-admitted separately by #12854, which keeps one writer per PR.

Price, measured on the required floor. This head, with only the two rows on main cc2fefacac and neither witness file touched, ran as floor job 110195687922:

gate closure (seeds / modules) preparation wall runner peak heap in use
with the two rows 118 / 2280 8m54s 23.72 GiB 19.53 GiB
without them (two same-day runs) 117 / 2278 9m28s, 9m12s 23.57, 23.62 GiB 19.44, 19.46 GiB

The closure grows by exactly the two modules, because every import they need was already in the gate. Wall time and peak memory stay within the noise between runners. The instrument is the floor's own phase=gate-closure, [floor-cgroup] and [floor-heap] lines.

Order: this lands right after #12857. Until #12857 is on main this floor is red on exactly those fixtures, which shows the claims now execute. I'll merge main here once #12857 lands. Do not merge before then.

🤖 Generated with Claude Code

@gunbai-bot
gunbai-bot Bot marked this pull request as ready for review October 1, 2026 01:39
…d effect_demand_floor_join_test to the gate, without touching either file, to price their marginal preparation

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
@gunbai-bot
gunbai-bot Bot force-pushed the sharp-bat-631-measure-gate branch from e3d1fe5 to 5e07c01 Compare October 1, 2026 02:48
Brian Searls and others added 2 commits October 1, 2026 03:28
…quired gate at exact grain

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
@gunbai-bot gunbai-bot Bot changed the title MEASUREMENT: price re-admitting the floor's own model witnesses to the gate (do not merge) Required gate: re-admit the floor's own census and effect-demand witnesses (lands after #12857) Oct 1, 2026
@gunbai-bot

gunbai-bot Bot commented Oct 1, 2026

Copy link
Copy Markdown
Contributor Author

Floor red at 8e51ac1 is the expected, ordered state: the only blocking identities are the 13 fixture reds #12857 repairs (10 in test.claim.discovery_census_witness, 3 in v2.test.claim.effect_demand.effect_demand_floor_join_test). That proves the re-admitted claims now execute. witnesses is the aggregate over the floor. No fix belongs here: once #12857 lands I merge main and this goes green.

— sent from sharp-bat-631

Brian Searls and others added 2 commits October 1, 2026 04:11
…nts from the roster note (DESIGN §6, review 73545)

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
@gunbai-bot

gunbai-bot Bot commented Oct 1, 2026

Copy link
Copy Markdown
Contributor Author

Floor red at 2038db7 blocks on ONE identity: test.claim.discovery_census_witness.w_deleted_lane_countable_is_planned_by_the_required_gate. The 12 #12857 fixes are green here. That claim is red on main until #12854 re-admits witness_floor_workflow_consolidation_witness_test, and this PR is the first to gate it. No fix belongs in this PR, because that row is #12854s (one writer per PR). Order is #12854 first, then I merge main here and it goes green.

— sent from sharp-bat-631

…-gate

# Conflicts:
#	src/v2/workflow/required_floor.dag
@gunbai-bot
gunbai-bot Bot added this pull request to the merge queue Oct 1, 2026
Merged via the queue into main with commit 12ae138 Oct 1, 2026
4 checks passed
@gunbai-bot
gunbai-bot Bot deleted the sharp-bat-631-measure-gate branch October 1, 2026 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants