Repository navigation
required_floor.dag: DeclinedNoCiWetLane arm with census control - #12854
Merged
Merged
Conversation
… its non-blocking standing, and its own census bucket Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
… admits The 2026-09-19 nominal roster withdrew `v2.test.` from required_gate_prefixes, and these witnesses were withdrawn with it, so their Planned fixtures (v2.test.claim.*, v2.test.probe_a) went stale unobserved. Repointing them into the admitted test.claim.infer_ family keeps each Planned arm discriminating against the gate as it stands. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
gunbai-bot Bot
pushed a commit
that referenced
this pull request
Oct 1, 2026
… also re-admit the deleted-lane countable); keep only the #12377 seam-home claim #12377 moved the Symbol seam pair from v2.std.compilers.lexing into v2.std.node and re-pointed effect_demand's seam rows; the roster is right and floor_join_witness_live_seam_modules_are_the_fourteen_seams_homes expected the old home. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
…rain Four rung drops name its w_RED_the_deleted_lanes_do_not_return as their countable; the 2026-09-19 nominal roster withdrew the module, so the countable ran on no required path. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
gunbai-bot Bot
pushed a commit
that referenced
this pull request
Oct 1, 2026
…516; #12854 reverted its duplicates) Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
gunbai-bot Bot
pushed a commit
that referenced
this pull request
Oct 1, 2026
…ission is decided in #12854 Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
The countable claim lived in the workflow-consolidation witness, whose import closure is the whole workflow emitter. The lane rosters (job ids, lane variables, required_lanes_roster, witness_floor_lane_roster) move to gunbc.witness_floor_lanes; the claim moves to test.claim.deleted_lanes_countable_witness_test, which the gate admits at exact grain in place of the consolidation module. Closure: 340 files against 1895 for the consolidation module. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
…ane arm Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
gunbai-bot Bot
pushed a commit
that referenced
this pull request
Oct 1, 2026
…nded) Seven conflicts, one shape: main modeled DeclinedNoCiWetLane in the .dag RequiredFloorDisposition (#12794's omission, closed) and this branch added PlannedAsReachConsumer, so every match carries both, and effect_demand_floor_join's FloorStandingCounts fold carries both counters. Three more breaks merged WITHOUT a conflict, each found by resolving the merged tree, not by git: - discovery_census census_counts_add: this branch's PlannedAsReachConsumer arm built CensusCounts without main's new declined_no_ci_wet_lane field. - floor_changed_witness changed_witness_decline_blocks, a match main added: no PlannedAsReachConsumer arm; it answers true like the other planned arms. - floor_changed_witness_test a_selected_declared_bin_wet_row_is_declined_no_ci_wet_lane, a match main added: no PlannedAsReachConsumer arm; false. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
DeclinedNoCiWetLane { pattern }to the.dagtypev2.workflow.required_floorRequiredFloorDisposition, mirroring the Rust arm landed by #12794/#12833.required_floor_disposition_with_changed_selectiontakesdeclared_wet_pattern: Optional<String>. A selected row withPresentbecomesDeclinedNoCiWetLane.v2.workflow.floor_changed_witnessgainschanged_witness_decline_blocks, an exhaustive match that returns false only for this arm.standing_blocksconsumes it.gunbc.discovery_censusCensusCounts.declined_no_ci_wet_laneis its own bucket, and its row partitions into the declined side. The arm is also carried throughFloorStandingCounts,v1_witness_census, and the exhaustiveness fixtures.a_selected_declared_bin_wet_row_is_declined_no_ci_wet_lanethe_no_ci_wet_lane_decline_does_not_block_and_other_declines_dothe_census_counts_a_declined_no_ci_wet_lane_row_in_its_own_bucket(uses a real hermetic-site row)Evidence (
gunbc run --claim-run, per file):The failures in the last two rows are pre-existing and not caused by this change.
Gaps found, not fixed here:
.dagtype still lacks the Rust armDeclinedChangedWitnessOutsideDiscovery..dagmirror exists for the Rust join predicatedecides_a_changed_selection.Reviewer: deep-ferret-305.
Narrowing the countable (deep-ferret-305, option C). Four rung drops name
w_RED_the_deleted_lanes_do_not_returnas their countable. It used to live intest.claim.witness_floor_workflow_consolidation_witness_test, whose import closure is the whole workflow emitter. The 2026-09-19 nominal roster withdrew that module, so the countable stopped running on any required path.gunbc.witness_floor_lanes: job ids, lane variables,required_lanes_roster,witness_floor_lane_roster,witness_floor_lane_job_idsandRequiredLane.gunbc.witness_floor_workflowandgunbc.required_lanes_gateimport them back, so the emitted workflow bytes are unchanged; thegeneratedlane checks that.test.claim.deleted_lanes_countable_witness_test, which the gate admits at exact grain.docs/design-rung-drops.mdis regenerated.Measured gate delta. I assembled the floor's nominal prepared subject on the real pool with
required_floor_nominal_subject_seedsandassemble_prepared_subject_closure. This is the subject a run prepares when it touches nothing, so no diff seeds are involved:deleted_lanes_countable_witness_testThe figures come from a one-off test run on
c80e644and are not committed.Fixture ownership. The stale census and floor-join fixtures belong to #12857. That PR lands first, and this one then merges main.
🤖 Generated with Claude Code