Skip to content

required_floor.dag: DeclinedNoCiWetLane arm with census control - #12854

Merged
gunbai-bot[bot] merged 7 commits into
mainfrom
session/bold-bat-516-wet-decline-dag
Oct 1, 2026
Merged

gunbai-bot[bot] merged 7 commits into
mainfrom
session/bold-bat-516-wet-decline-dag

Conversation

@gunbai-bot

@gunbai-bot gunbai-bot Bot commented Oct 1, 2026 •

Copy link
Copy Markdown
Contributor

Adds DeclinedNoCiWetLane { pattern } to the .dag type v2.workflow.required_floor RequiredFloorDisposition, mirroring the Rust arm landed by #12794/#12833.

  • required_floor_disposition_with_changed_selection takes declared_wet_pattern: Optional<String>. A selected row with Present becomes DeclinedNoCiWetLane.
  • v2.workflow.floor_changed_witness gains changed_witness_decline_blocks, an exhaustive match that returns false only for this arm. standing_blocks consumes it.
  • Census control: gunbc.discovery_census CensusCounts.declined_no_ci_wet_lane is its own bucket, and its row partitions into the declined side. The arm is also carried through FloorStandingCounts, v1_witness_census, and the exhaustiveness fixtures.
  • New tests:
    • a_selected_declared_bin_wet_row_is_declined_no_ci_wet_lane
    • the_no_ci_wet_lane_decline_does_not_block_and_other_declines_do
    • the_census_counts_a_declined_no_ci_wet_lane_row_in_its_own_bucket (uses a real hermetic-site row)

Evidence (gunbc run --claim-run, per file):

File Branch Main
floor_changed_witness 51/51 —
gate_selector 4/4 —
exhaustiveness 26/26 —
discovery_census_witness 13 pass / 10 fail 12 pass / 10 fail (same 10, at c95f906)
effect_demand_floor_join 9 pass / 3 fail 9 pass / 3 fail (same 3)

The failures in the last two rows are pre-existing and not caused by this change.

Gaps found, not fixed here:

  • The .dag type still lacks the Rust arm DeclinedChangedWitnessOutsideDiscovery.
  • No .dag mirror exists for the Rust join predicate decides_a_changed_selection.

Reviewer: deep-ferret-305.

Narrowing the countable (deep-ferret-305, option C). Four rung drops name w_RED_the_deleted_lanes_do_not_return as their countable. It used to live in test.claim.witness_floor_workflow_consolidation_witness_test, whose import closure is the whole workflow emitter. The 2026-09-19 nominal roster withdrew that module, so the countable stopped running on any required path.

  • Lane facts. The facts the countable reads moved to a new module, gunbc.witness_floor_lanes: job ids, lane variables, required_lanes_roster, witness_floor_lane_roster, witness_floor_lane_job_ids and RequiredLane. gunbc.witness_floor_workflow and gunbc.required_lanes_gate import them back, so the emitted workflow bytes are unchanged; the generated lane checks that.
  • The claim. It moved to test.claim.deleted_lanes_countable_witness_test, which the gate admits at exact grain.
  • Citations. The four rung drops, the census fixture, the grandfathered roster and the gate comments now cite the new identity. docs/design-rung-drops.md is regenerated.

Measured gate delta. I assembled the floor's nominal prepared subject on the real pool with required_floor_nominal_subject_seeds and assemble_prepared_subject_closure. This is the subject a run prepares when it touches nothing, so no diff seeds are involved:

Admitted module Nominal subject (modules) Added
Neither 2,281 —
deleted_lanes_countable_witness_test 2,282 +1 (the countable module itself)
Consolidation module instead 2,362 +81

The figures come from a one-off test run on c80e644 and are not committed.

Fixture ownership. The stale census and floor-join fixtures belong to #12857. That PR lands first, and this one then merges main.

🤖 Generated with Claude Code

gunbc-ci-auto-heal and others added 2 commits October 1, 2026 01:11
… its non-blocking standing, and its own census bucket

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
… admits

The 2026-09-19 nominal roster withdrew `v2.test.` from required_gate_prefixes, and these
witnesses were withdrawn with it, so their Planned fixtures (v2.test.claim.*, v2.test.probe_a)
went stale unobserved. Repointing them into the admitted test.claim.infer_ family keeps each
Planned arm discriminating against the gate as it stands.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
gunbai-bot Bot pushed a commit that referenced this pull request Oct 1, 2026
… also re-admit the deleted-lane countable); keep only the #12377 seam-home claim

#12377 moved the Symbol seam pair from v2.std.compilers.lexing into
v2.std.node and re-pointed effect_demand's seam rows; the roster is right
and floor_join_witness_live_seam_modules_are_the_fourteen_seams_homes
expected the old home.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
gunbc-ci-auto-heal and others added 2 commits October 1, 2026 02:08
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
…rain

Four rung drops name its w_RED_the_deleted_lanes_do_not_return as their countable; the
2026-09-19 nominal roster withdrew the module, so the countable ran on no required path.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
gunbai-bot Bot pushed a commit that referenced this pull request Oct 1, 2026
…516; #12854 reverted its duplicates)

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
gunbai-bot Bot pushed a commit that referenced this pull request Oct 1, 2026
…ission is decided in #12854

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
gunbc-ci-auto-heal and others added 3 commits October 1, 2026 04:51
The countable claim lived in the workflow-consolidation witness, whose import closure is the
whole workflow emitter. The lane rosters (job ids, lane variables, required_lanes_roster,
witness_floor_lane_roster) move to gunbc.witness_floor_lanes; the claim moves to
test.claim.deleted_lanes_countable_witness_test, which the gate admits at exact grain in place of
the consolidation module. Closure: 340 files against 1895 for the consolidation module.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
…ane arm

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
@gunbai-bot
gunbai-bot Bot added this pull request to the merge queue Oct 1, 2026
Merged via the queue into main with commit b1137ba Oct 1, 2026
4 checks passed
@gunbai-bot
gunbai-bot Bot deleted the session/bold-bat-516-wet-decline-dag branch October 1, 2026 07:32
gunbai-bot Bot pushed a commit that referenced this pull request Oct 1, 2026
…nded)

Seven conflicts, one shape: main modeled DeclinedNoCiWetLane in the .dag
RequiredFloorDisposition (#12794's omission, closed) and this branch added
PlannedAsReachConsumer, so every match carries both, and
effect_demand_floor_join's FloorStandingCounts fold carries both counters.

Three more breaks merged WITHOUT a conflict, each found by resolving the merged tree,
not by git:
- discovery_census census_counts_add: this branch's PlannedAsReachConsumer arm built
  CensusCounts without main's new declined_no_ci_wet_lane field.
- floor_changed_witness changed_witness_decline_blocks, a match main added: no
  PlannedAsReachConsumer arm; it answers true like the other planned arms.
- floor_changed_witness_test a_selected_declared_bin_wet_row_is_declined_no_ci_wet_lane,
  a match main added: no PlannedAsReachConsumer arm; false.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants