Skip to content

SH-1: v2 grammar cannot parse the corpus — fatal at weather.dag:267, both terminal entries - #11615

Closed
briansrls wants to merge 9 commits into
mainfrom
session/stern-koi-802
Closed

briansrls wants to merge 9 commits into
mainfrom
session/stern-koi-802

Conversation

@briansrls

Copy link
Copy Markdown
Contributor

Auto-opened by session-dashboard for session stern-koi-802.
Pushing to session/stern-koi-802 advances this PR.

Worker attestation

Before flipping this PR to ready for review, confirm each item:

  • Title describes the change (not the session id or branch).
  • PR body summarises what and why (replace the TODO below).
  • Tests run: name the command (e.g. npm test, cargo test) and the result.
  • If this closes a work item, the body contains a Closes #N directive.
  • No commits on this branch are surprises (no fork/cherry-pick I did not make).
  • No secrets / credentials / large binaries staged.

Summary

TODO: replace this paragraph with one or two sentences naming the change and its motivation. Reviewers read this first.

Test plan

  • TODO: list the commands that ran (or "no tests changed; relied on CI") and the outcome.

Brian Searls and others added 9 commits September 18, 2026 03:59
weather.dag's leftover `fn` was parse_g0_tokens_remain after `1.8` split into int+dot+int; postfix field access cannot take a digit. Match v1 scan_number (digits '.' digits) so the corpus prefix that stopped at weather continues.

Co-authored-by: Cursor <cursoragent@cursor.com>
Floor discovery refuses test-marked decls outside that suffix; the SH-1 probe was otherwise unenrolled.

Co-authored-by: Cursor <cursoragent@cursor.com>
… CLI.

The standing Locus fold grows a file+extent sibling; compile_cli consumes it. The four parse rows now name tokenize/parse_module so the safety case can resolve.

Co-authored-by: Cursor <cursoragent@cursor.com>
Floor discovery refuses test-marked decls outside that suffix. Also enroll longest-match controls: x.0 stays ident+dot+int, 1..2 stays four tokens, and a string is not a float.

Co-authored-by: Cursor <cursoragent@cursor.com>
StampClass made 1.8 and 2.5 the same atom. Capture the matched lexeme like int magnitude, and state that longest-match ties go to the later rule — these two patterns never tie.

Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
…capture.

Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
@gunbai-bot

gunbai-bot Bot commented Sep 18, 2026

Copy link
Copy Markdown
Contributor

review 67607 (dashboard artifact /api/reviews/67607/artifacts/stdout.log)

Finding (dag_node_is_float_literal_atom re-spells the Atom-identity match): fixed. It now consumes node_atom_identity_optional (Present { value: id } => id == ^dag_token_float_literal). The int/true/false siblings stay as the existing debt named by target_value_expr_int_literal_predicate_dissolve_on; this PR does not mint a fifth copy on the new row.

— sent from stern-koi-802

@gunbai-bot
gunbai-bot Bot marked this pull request as ready for review September 18, 2026 16:00
@gunbai-bot

gunbai-bot Bot commented Sep 18, 2026

Copy link
Copy Markdown
Contributor

Closing as a duplicate of #11575, on its author's explicit instruction in their handoff ("this session's leftover #11615 was the same SH-1 stack after #11575 landed; treat as duplicate, do not merge").

Verified before closing: this PR's eight files are the same eight #11575 touched, and all eight are already on main (SH-1 landed as 7accd8eb). Re-applying this stack on top of a main that has moved 19 commits past its base would re-propose landed content, not add anything.

Not deleting the branch — it shares history with in-flight runs, and deleting a branch out from under shared runs fails them onto the surviving PR.

What landed via #11575, for anyone arriving here: v2's G0 had no float literal (v1 scan_number emits ShLitFloat for digits '.' digits), so 1.8 lexed as int-dot-int, postfix field access failed, and the leftover fn at weather.dag byte 267 surfaced as parse_g0_tokens_remain. Closed with a lex rule plus primary/pattern terminals, resolve refusing a typed ^float_literal_not_lowered rather than misattributing an unbound symbol, and a standing RED on trailing-dot 1. because v1 also refuses it.

Still open, declared rather than hidden: the float is parsed but not lowered or evaluated — there is no body_lower/eval-literal/DecimalMagnitude analogue yet, and the trigger for that work is the retires_dissolution row on dag_float_literal_node_from_lexeme.

The native door's next fatal is dag/extdeps/access/posix_effective_principal.dag bytes 1077..1091, token nominal_opaque, dispatched as SH-2.

— sent from proud-bat-569

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant