Repository navigation
Remove cross-module imports of test fns and test modules - #11496
Merged
Merged
Conversation
- dag/test/parsecheck.dag (a plain module) imported a test fn from test.claim.installed_bom_reconcile_witness_test and conjoined it into memory_model_holds; the conjunct and the import are dropped. That test fn is enrolled and runs on its own. - src/v2/test/claim/long/no_dual_representation_test_test.dag only re-called the two test fns of v2.lens.no_dual_representation_test, which the floor already runs under their own identities (see floor_cost_debt); the wrapper sat in witness_deferral_freeze and executed nowhere. Module and freeze row deleted. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
test.probe.self_authored_map_probe imported fx_map from a test module to show an unadmitted call refuses. fx_map now lives in test.fixture.data_handling_map_fixture (no test items), with the same admit_callers list and authority; product.data_class admits it at the new path, and both the admission witness and the probe import it from there. The probe keeps its ConstructorCallAdmissionRefused, so data_class_refusal_probe_witness keeps its red (DESIGN §4b(4)). Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
gunbai-bot
Bot
changed the title
The previous move of fx_map into the fixture module failed the floor twice: its authority decl_ref cited a declaration the witness module does not declare (CITED-DECLARATION-ABSENT), and rebinding fx_map in seven sites produced unadjudicated TargetChanged namespace deltas. Instead, leave the admission witness and product.data_class untouched and give the probe its own caller-sealed builder in test.fixture.data_handling_map_fixture (sealed to a caller in that module, returning the public empty map, so no second route to the DataHandlingMap mint is admitted). The probe's third function still refuses as ConstructorCallAdmissionRefused, so data_class_refusal_probe_witness keeps its >= 2 count, and the probe no longer imports a test module. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove cross-module imports of test fns
dag/test/parsecheck.dag (a plain module) imported a test fn from
test.claim.installed_bom_reconcile_witness_test and conjoined it into
memory_model_holds; the conjunct and the import are dropped. That test
fn is enrolled and runs on its own.
src/v2/test/claim/long/no_dual_representation_test_test.dag only
re-called the two test fns of v2.lens.no_dual_representation_test,
which the floor already runs under their own identities (see
floor_cost_debt); the wrapper sat in witness_deferral_freeze and
executed nowhere. Module and freeze row deleted.
dag/test/probe/self_authored_map_probe.dagimportedfx_mapfrom a test module as the refusal under test. Its third function now callssealed_fixture_mapfrom the new ordinary fixture moduletest.fixture.data_handling_map_fixture, which isadmit_callers-sealed to a caller in its own module and returns the public empty map (no second admitted route to the sealedDataHandlingMapmint). The probe still yields theConstructorCallAdmissionRefusedthatdata_class_refusal_probe_witnesscounts (>= 2).product.data_classand the admission witness are unchanged.Sibling PRs: #11488 #11489 #11490 #11494 #11495.
🤖 Generated with Claude Code